Re: Release 3.01 error, using huge amounts of memory

2017-05-08 Thread Ralph Corderoy
Hi Jimmy,

> Does anyone know if this need to be raised on the Wiki/support forums,
> or is the fact that it's in the mailing list sufficient for it to be
> looked at for future releases and hopefully fixed?

I've also wondered that and just had a look.  "ALL... problem reports
should go to the support forums" —
https://github.com/get-iplayer/get_iplayer/wiki/help

You can always point to the list with the detail, e.g.
http://lists.infradead.org/pipermail/get_iplayer/2017-May/010669.html

-- 
Cheers, Ralph.
https://plus.google.com/+RalphCorderoy

___
get_iplayer mailing list
get_iplayer@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/get_iplayer


Re: Release 3.01 error, using huge amounts of memory

2017-05-08 Thread Jimmy Aitken
On Sun, May 7, 2017 at 9:53 PM, Ralph Corderoy  wrote:
> Hi Jimmy,
>
 [ deleted ]
> The code is assuming it will be able to strip off either `foo=bar' or
> `foo="xyzzy"' from the front of a comma-separated list.  When it can't, it
> prints the warning, and then tries again.  It has no better luck on any future
> attempt.  The warning shows what it was toiling over.
>
> BANDWIDTH=979000,CODECS="mp4a.40.5
>
> I expect this happily consumed `BANDWIDTH=979000', but then disliked the lack
> of double-quote termination to `CODECS="mp4a.40.5'.
>
> It needs to be raised with get_iplayer's authors.
>

Many thanks for looking into the issue.  I appreciate the time.

Does anyone know if this need to be raised on the Wiki/support forums,
or is the fact that it's in the mailing list sufficient for it to be
looked at for future releases and hopefully fixed?  I'm a bit wary of
running unattended get_iplayer runs in case it happens again and I'm
currently away from my machine so a reboot is not always possible.

Many thanks,
Jimmy

___
get_iplayer mailing list
get_iplayer@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/get_iplayer


Re: Release 3.01 error, using huge amounts of memory

2017-05-07 Thread Ralph Corderoy
Hi Jimmy,

> WARNING: Invalid attributes in HLS playlist:
> BANDWIDTH=979000,CODECS="mp4a.40.5
> (http://vod-hls-uk-live.bbcfmt.hs.llnwd.net/usp/auth/vod/piff_abr_full_sd_ad/ab83dd-b08pq8jz/vf_b08pq8jz_c46b7e01-c3af-44fe-ad32-d4
> 870b8505fd.ism/mobile_wifi_main_sd_abr_v2_hls_master.m3u8?s=1494129167=1494172367=7c0807ea016ea43f49302dd5004b9e1f)

It's an endless-loop bug in

# from https://github.com/osklil/hls-fetch
sub parse_m3u_attribs {
my ($url, $attr_str) = @_;
my %attr;
for (my $as = $attr_str; $as ne ''; ) {
$as =~ s/^?([^=]*)=([^,"]*|"[^"]*")\s*(,\s*|$)// or
main::logger "WARNING: Invalid attributes in HLS playlist: 
$attr_str ($url)\n";   
my ($key, $val) = ($1, $2);
$val =~ s/^"(.*)"$/$1/;
$attr{$key} = $val;
}
return %attr;
}

The code is assuming it will be able to strip off either `foo=bar' or
`foo="xyzzy"' from the front of a comma-separated list.  When it can't, it
prints the warning, and then tries again.  It has no better luck on any future
attempt.  The warning shows what it was toiling over.

BANDWIDTH=979000,CODECS="mp4a.40.5

I expect this happily consumed `BANDWIDTH=979000', but then disliked the lack
of double-quote termination to `CODECS="mp4a.40.5'.

It needs to be raised with get_iplayer's authors.

-- 
Cheers, Ralph.
https://plus.google.com/+RalphCorderoy

___
get_iplayer mailing list
get_iplayer@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/get_iplayer


Release 3.01 error, using huge amounts of memory

2017-05-07 Thread Jimmy Aitken
I downloaded version 3.01 last night and started my PVR run this
morning, and left it to run.  When I got back, my Mac had frozen, with
the Terminal process using 20G of RAM (not sure if it was just the
terminal or a combination of GIP and the terminal process) and the
kernel task using 11G (my machine has 16G, so there was a lot of
compressed memory and paging going on here.)

The get_iplayer process in the terminal was showing a continuous
looping error which I tried to interrupt, but the machine was so slow,
it was totally unresponsive.  I had to remotely log in, kill the
offending GIP process and reboot the machine to free up the kernel
memory.

My machine is running Yosemite and is fully patched.  I believe the
programme in question was 'Garden Rescue Episode 10 - Weston
Super-Mare' The last few lines of the errors being sent to the
terminal are below, recovered after the machine rebooted from the
terminal process.

WARNING: Invalid attributes in HLS playlist:
BANDWIDTH=979000,CODECS="mp4a.40.5
(http://vod-hls-uk-live.bbcfmt.hs.llnwd.net/usp/auth/vod/piff_abr_full_sd_ad/ab83dd-b08pq8jz/vf_b08pq8jz_c46b7e01-c3af-44fe-ad32-d4870b8505fd.ism/mobile_wifi_main_sd_abr_v2_hls_master.m3u8?s=1494129167=1494172367=7c0807ea016ea43f49302dd5004b9e1f)

WARNING: Invalid attributes in HLS playlist:
BANDWIDTH=979000,CODECS="mp4a.40.5
(http://vod-hls-uk-live.bbcfmt.hs.llnwd.net/usp/auth/vod/piff_abr_full_sd_ad/ab83dd-b08pq8jz/vf_b08pq8jz_c46b7e01-c3af-44fe-ad32-d4870b8505fd.ism/mobile_wifi_main_sd_abr_v2_hls_master.m3u8?s=1494129167=1494172367=7c0807ea016ea43f49302dd5004b9e1f)

WARNING: Invalid attributes in HLS playlist:
BANDWIDTH=979000,CODECS="mp4a.40.5
(http://vod-hls-uk-live.bbcfmt.hs.llnwd.net/usp/auth/vod/piff_abr_full_sd_ad/ab83dd-b08pq8jz/vf_b08pq8jz_c46b7e01-c3af-44fe-ad32-d4870b8505fd.ism/mobile_wifi_main_sd_abr_v2_hls_master.m3u8?s=1494129167=1494172367=7c0807ea016ea43f49302dd5004b9e1f)

WARNING: Invalid attributes in HLS playlist:
BANDWIDTH=979000,CODECS="mp4a.40.5
(http://vod-hls-uk-live.bbcfmt.hs.llnwd.net/usp/auth/vod/piff_abr_full_sd_ad/ab83dd-b08pq8jz/vf_b08pq8jz_c46b7e01-c3af-44fe-ad32-d4870b8505fd.ism/mobile_wifi_main_sd_abr_v2_hls_master.m3u8?s=1494129167=1494172367=7c0807ea016ea43f49302dd5004b9e1f)


Any ideas, and has anyone else seen anything similar?

Jimmy

___
get_iplayer mailing list
get_iplayer@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/get_iplayer