Re: Moving hadrian to submodule

[Boespflug, Mathieu]

Great! A submodule makes a lot more sense to me, at least short term. I
would hope that medium term the development processes of GHC-as-a-whole and
Hadrian(-a-part-of-GHC) can converge, so that a submodule is no longer
necessary. Submodules do have their downsides and it would be odd for such
a core part as the build system to be kept external to the main repo.

--
Mathieu Boespflug
Founder at http://tweag.io.

On 8 December 2017 at 20:10, Ara Adkins  wrote:

> Sounds good! Hopefully this doesn’t cause a flood of commit messages.
>
> _ara
>
> > On 8 Dec 2017, at 18:50, Ben Gamari  wrote:
> >
> > Hello everyone,
> >
> > A bit over a month ago we merged hadrian into the ghc tree as a subtree.
> > Unfortunately, those working on Hadrian have found the subtree mechanism
> > to provide a rather poor developer experience. Consequently, today I
> > will be ripping out the subtree and replacing it with a submodule.
> >
> > After pulling the commit performing this change you will likely need to
> > do the following to emplace the new submodule,
> >
> >$ git submodule update --init
> >$ git -C hadrian checkout .
> >
> > Cheers,
> >
> > - Ben
> > ___
> > ghc-devs mailing list
> > ghc-devs@haskell.org
> > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
> ___
> ghc-devs mailing list
> ghc-devs@haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Re: Moving hadrian to submodule

[Ara Adkins]

Sounds good! Hopefully this doesn’t cause a flood of commit messages. 

_ara

> On 8 Dec 2017, at 18:50, Ben Gamari  wrote:
> 
> Hello everyone,
> 
> A bit over a month ago we merged hadrian into the ghc tree as a subtree.
> Unfortunately, those working on Hadrian have found the subtree mechanism
> to provide a rather poor developer experience. Consequently, today I
> will be ripping out the subtree and replacing it with a submodule.
> 
> After pulling the commit performing this change you will likely need to
> do the following to emplace the new submodule,
> 
>$ git submodule update --init
>$ git -C hadrian checkout .
> 
> Cheers,
> 
> - Ben
> ___
> ghc-devs mailing list
> ghc-devs@haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Moving hadrian to submodule

[Ben Gamari]

Hello everyone,

A bit over a month ago we merged hadrian into the ghc tree as a subtree.
Unfortunately, those working on Hadrian have found the subtree mechanism
to provide a rather poor developer experience. Consequently, today I
will be ripping out the subtree and replacing it with a submodule.

After pulling the commit performing this change you will likely need to
do the following to emplace the new submodule,

$ git submodule update --init
$ git -C hadrian checkout .

Cheers,

- Ben


signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Re: Long standing annoying issue in ghci

[MarLinn]

I opened an issue on the Haskeline github 
(https://github.com/judah/haskeline/issues/72).


But it seems to be completely Haskeline-side, so I'm not sure if it's 
worth re-opening the one for ghci? As missing documentation maybe?
(BTW, I found this on the wiki: https://wiki.haskell.org/GHCi_in_colour. 
Might be a good place to put it, if linked.)


If you want to, here are my test cases rewritten as ghci prompts:

    -- single line, positioning error
:set prompt " \ESC[36m%\ESC[0m "
-- single line, works
    :set prompt " \ESC[36m\STX%\ESC[0m\STX "
-- multiline, bad output
    :set prompt "\ESC[32m\STX–––\ESC[0m\STX\n \ESC[36m\STX%\ESC[0m\STX "
-- multiline, works but is inconsistent
    :set prompt "\ESC[32m–––\ESC[0m\n \ESC[36m\STX%\ESC[0m\STX "

In my tests, the positioning errors consistently happen if there are any 
"unclosed" escape-sequences on the last line of the prompt, regardless 
of its length. Escape sequences on previous lines consistently create 
"weird characters", but don't influence the positioning. Also regardless 
of their lengths. That makes sense, as both sets of lines seem to be 
handled quite differently.


Are multiline prompts even used by a lot of people? I like mine because 
it gives me a both a list of modules and a consistent cursor position. 
But maybe I'm the exception?


Cheers.

On 2017-12-07 23:15, cheater00 cheater00 wrote:


Interesting. Would you mind reopening the issue and providing a buggy 
example? Amd alerting haskeline maintainers? How does it work on a 1 
line prompt that is so long it wraps?



On Thu, 7 Dec 2017 23:11 MarLinn, > wrote:



> Here's what I use:
>
> :set prompt "\ESC[46m\STX%s>\ESC[39;49m\STX "
>
> I believe \STX is a signal to haskeline for control sequences.
> Documentation is here:
> https://github.com/judah/haskeline/wiki/ControlSequencesInPrompt
Note: If you're using a multi-line prompt, things may be different
again. I don't know what the rules are, but I found that if I put \STX
on any but the last line of prompts I get weird characters. The same
goes for any \SOH you might want to add for some reason.

Cheers,
MarLinn



___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

RE: unix/tests/user001

[Ben Gamari]

Simon Peyton Jones via ghc-devs  writes:

> |  that your user doesn't have a valid group, which is quite odd. What
> |  does the `id` command say?
>
> simonpj@cam-05-unx:~/tmp$ id
> uid=501(simonpj) gid=1001 groups=1001,27(sudo)

Indeed it looks like your group doesn't have an entry in /etc/group.
Quite odd. Perhaps this was due to the upgrade?

Is there an entry for group id 501 in /etc/group?

Cheers,

- Ben


signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

RE: unix/tests/user001

[Simon Peyton Jones via ghc-devs]

|  that your user doesn't have a valid group, which is quite odd. What
|  does the `id` command say?

simonpj@cam-05-unx:~/tmp$ id
uid=501(simonpj) gid=1001 groups=1001,27(sudo)

|  -Original Message-
|  From: Ben Gamari [mailto:b...@well-typed.com]
|  Sent: 08 December 2017 15:13
|  To: Simon Peyton Jones ; ghc-devs@haskell.org
|  Subject: Re: unix/tests/user001
|  
|  Simon Peyton Jones via ghc-devs  writes:
|  
|  > On Linux I get this validate  failure all the time.  What should I
|  do?
|  > I've trained myself to ignore it, but that seems wrong Simon
|  >
|  > Unexpected failures:
|  >
|  >../libraries/unix/tests/user001.run  user001 [bad stdout]
|  (normal)
|  >
|  It sounds like your machine may be misconfigured. The test attempts to
|  lookup the entry in /etc/group corresponding to the process's group.
|  However, it appears that such an entry doesn't exist. This would imply
|  that your user doesn't have a valid group, which is quite odd. What
|  does the `id` command say?
|  
|  Cheers,
|  
|  - Ben
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Re: unix/tests/user001

[Ben Gamari]

Simon Peyton Jones via ghc-devs  writes:

> On Linux I get this validate  failure all the time.  What should I do?  I've 
> trained myself to ignore it, but that seems wrong
> Simon
>
> Unexpected failures:
>
>../libraries/unix/tests/user001.run  user001 [bad stdout] (normal)
>
It sounds like your machine may be misconfigured. The test attempts to
lookup the entry in /etc/group corresponding to the process's group.
However, it appears that such an entry doesn't exist. This would imply
that your user doesn't have a valid group, which is quite odd. What does
the `id` command say?

Cheers,

- Ben


signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

unix/tests/user001

[Simon Peyton Jones via ghc-devs]

On Linux I get this validate  failure all the time.  What should I do?  I've 
trained myself to ignore it, but that seems wrong
Simon

Unexpected failures:

   ../libraries/unix/tests/user001.run  user001 [bad stdout] (normal)







=> user001(normal) 1 of 1 [0, 0, 0]

cd "./user001.run" &&  "/5playpen/simonpj/HEAD/inplace/test   
spaces/ghc-stage2" -o user001 user001.hs -dcore-lint -dcmm-lint 
-no-user-package-db -rtsopts -fno-warn-missed-specialisations 
-fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show-caret 
-dno-debug-output  -package unix

cd "./user001.run" && ./user001

Actual stdout output differs from expected:

diff -uw "./user001.run/user001.stdout.normalised" 
"./user001.run/user001.run.stdout.normalised"

--- ./user001.run/user001.stdout.normalised2017-12-08 10:22:59.835931843 
+

+++ ./user001.run/user001.run.stdout.normalised   2017-12-08 
10:22:59.835931843 +

@@ -4,8 +4,8 @@

getEffectiveGroupID: OK

getGroups: OK

getEffectiveUserName: OK

-getGroupEntryForID: OK

-getGroupEntryForName: OK

+getGroupEntryForID: ERROR: getGroupEntryForID: does not exist (no such group)

+getGroupEntryForName: ERROR: getGroupEntryForID: does not exist (no such group)

getAllGroupEntries: OK

getUserEntryForID: OK

getAllUserEntries: OK

*** unexpected failure for user001(normal)
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

RE: Can't push to haddock

[Simon Peyton Jones via ghc-devs]

|  Yes, the mirroring has a little bit of latency (assuming the mirroring
|  trigger event notification from github to git.haskell.org didn't get
|  lost). How much time did you wait between pushing to github and
|  ghc.git?

I didn't allow any time -- I didn't know that time was needed. Perhaps we 
should add a note to 
https://ghc.haskell.org/trac/ghc/wiki/Repositories
to explain?  Under "Updating sub-repos" perhaps.

I wonder if it'd be worth us articulating the reason why some submodules live 
in github, but some live in git.haskell.org -- with only mirroring github.  I'm 
sure there's a rationale but I don't get it yet.

Simon


|  -Original Message-
|  From: Herbert Valerio Riedel [mailto:hvrie...@gmail.com]
|  Sent: 07 December 2017 17:57
|  To: Simon Peyton Jones 
|  Subject: Re: Can't push to haddock
|  
|  Hi Simon,
|  
|  Yes, the mirroring has a little bit of latency (assuming the mirroring
|  trigger event notification from github to git.haskell.org didn't get
|  lost). How much time did you wait between pushing to github and
|  ghc.git?
|  
|  On Thu, Dec 7, 2017 at 6:53 PM, Simon Peyton Jones via ghc-devs  wrote:
|  > But when I try to push the GHC patch, I get this message
|  >
|  > Ah… it worked after a while. Maybe a mirroring thing?
|  >
|  > But in pushing to GHC I saw:
|  >
|  > git push
|  >
|  > Counting objects: 45, done.
|  >
|  > Delta compression using up to 32 threads.
|  >
|  > Compressing objects: 100% (45/45), done.
|  >
|  > Writing objects: 100% (45/45), 27.56 KiB | 0 bytes/s, done.
|  >
|  > Total 45 (delta 43), reused 0 (delta 0)
|  >
|  > remote: performing commit message validations...
|  >
|  > remote: Commit message validation passed!
|  >
|  > remote: performing submodule-ref update validations...
|  >
|  > remote: Submodule update(s) detected in
|  > fa29df02a1b0b926afb2525a258172dcbf0ea460:
|  >
|  > remote:  utils/haddock => 24841386cff6fdccc11accf9daa815c2c7444d65
|  >
|  > remote:  utils/hsc2hs => 9483ad10064fbbb97ab525280623826b1ef63959
|  >
|  > remote:  OK
|  >
|  > remote: performing whitespace validations...
|  >
|  > remote: whitespace validation passed!
|  >
|  > remote: mirroring ssh://g...@git.haskell.org/ghc to
|  > ssh://g...@github.com/ghc/ghc ...
|  >
|  > remote: To ssh://g...@github.com/ghc/ghc
|  >
|  > remote:5f332e1..fa29df0  master -> master
|  >
|  > remote: running notifier
|  >
|  > To ssh://g...@git.haskell.org/ghc.git
|  >
|  >5f332e1..fa29df0  HEAD -> master
|  >
|  > simonpj@cam-05-unx:~/code/HEAD$
|  >
|  > I did not intend to monkey around with hsc2hs. I can’t think how
|  that
|  > happened, or whether it matter.
|  >
|  > With many apologies, would a wiser person that me like to see if
|  I’ve
|  > accidentally messed up hsc2hs.
|  >
|  > Thanks
|  >
|  > Simon
|  >
|  >
|  >
|  > From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of
|  > Simon Peyton Jones via ghc-devs
|  > Sent: 07 December 2017 17:32
|  > To: ghc-devs@haskell.org
|  > Subject: Can't push to haddock
|  >
|  >
|  >
|  > I’m trying to push a patch that needs a supporting change to
|  haddock.
|  >
|  > I’ve pushed the haddock change to the ghc-head branch of
|  > ssh://g...@github.com/haskell/haddock.git, which is (according to
|  > ‘packages’) the relevant haddock upstream repo.
|  >
|  > But when I try to push the GHC patch, I get this message
|  >
|  > bash$ git push
|  >
|  > Counting objects: 45, done.
|  >
|  > Delta compression using up to 32 threads.
|  >
|  > Compressing objects: 100% (45/45), done.
|  >
|  > Writing objects: 100% (45/45), 27.56 KiB | 0 bytes/s, done.
|  >
|  > Total 45 (delta 43), reused 0 (delta 0)
|  >
|  > remote: performing commit message validations...
|  >
|  > remote: Commit message validation passed!
|  >
|  > remote: performing submodule-ref update validations...
|  >
|  > remote: Submodule update(s) detected in
|  > fa29df02a1b0b926afb2525a258172dcbf0ea460:
|  >
|  > remote:  utils/haddock => 24841386cff6fdccc11accf9daa815c2c7444d65
|  >
|  > remote: *FAIL* commit not found in submodule repo ('../haddock.git')
|  >
|  > remote:or not reachable from persistent branches
|  >
|  > remote: hooklet hooks/update.secondary.d/check-submodule-refs failed
|  >
|  > remote: hooks/update.secondary died
|  >
|  > remote: error: hook declined to update refs/heads/master
|  >
|  > To ssh://g...@git.haskell.org/ghc.git
|  >
|  > ! [remote rejected] HEAD -> master (hook declined)
|  >
|  > error: failed to push some refs to
|  'ssh://g...@git.haskell.org/ghc.git'
|  >
|  > simonpj@cam-05-unx:~/code/HEAD$
|  >
|  >
|  >
|  > What’s up?  I  have pushed the haddock commit!
|  >
|  > THanks
|  >
|  > Simon
|  >
|  >
|  >
|  >
|  > ___
|  > ghc-devs mailing list
|  > ghc-devs@haskell.org
|  >
|  https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.h
|  > askell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-
|  devs&data=02%7C01%7Csimonpj%40microsoft.com%7C684b5c