Re: Evac.c

2020-06-11 Thread Phyx
Hi Ben,

Just FYI, gcc 9 added -fdiagnostics-format=json so that may be an option to
make this sort of thing easier to handle.

Kind regards
Tamar

Sent from my Mobile

On Thu, Jun 11, 2020, 17:50 Ben Gamari  wrote:

> Simon Peyton Jones via ghc-devs  writes:
>
> > I'm getting this in HEAD.  Should I worry?  It says "error"!
> > Simon
> >
> Indeed we probably ought to fix the error message handling here. The
> claim that this is an "error" is from GHC, which parses GCC's error
> output. You see, however, that GCC is merely giving us a warning.
>
> Regardless, the issue itself is non-critical. It's merely telling us
> that we asked for a function to be inlined yet GCC felt it wouldn't be
> wise to do so. This usually happens in the debug runtime due to
> additional assertion code. It's safe to ignore.
>
> Cheers,
>
> - Ben
> ___
> ghc-devs mailing list
> ghc-devs@haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Evac.c

2020-06-11 Thread Ben Gamari
Simon Peyton Jones via ghc-devs  writes:

> I'm getting this in HEAD.  Should I worry?  It says "error"!
> Simon
>
Indeed we probably ought to fix the error message handling here. The
claim that this is an "error" is from GHC, which parses GCC's error
output. You see, however, that GCC is merely giving us a warning.

Regardless, the issue itself is non-critical. It's merely telling us
that we asked for a function to be inlined yet GCC felt it wouldn't be
wise to do so. This usually happens in the debug runtime due to
additional assertion code. It's safe to ignore.

Cheers,

- Ben


signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Evac.c

2020-06-11 Thread Simon Peyton Jones via ghc-devs
I'm getting this in HEAD.  Should I worry?  It says "error"!
Simon



rts/sm/Evac.c:463:5: error:

 note: called from here

 ACQUIRE_SPIN_LOCK(>sync);

 ^

|

463 | ACQUIRE_SPIN_LOCK(>sync);

| ^



In file included from includes/Rts.h:196:0: error:

0,

 from rts/sm/Evac.c:15:



includes/rts/SpinLock.h:43:20: error:

 warning: inlining failed in call to 'ACQUIRE_SPIN_LOCK': call is unlikely 
and code size would grow [-Winline]

 INLINE_HEADER void ACQUIRE_SPIN_LOCK(SpinLock * p)

^

   |

43 | INLINE_HEADER void ACQUIRE_SPIN_LOCK(SpinLock * p)

   |^



rts/sm/Evac.c:515:31: error:

 note: called from here

 if (new_gen != gen) { ACQUIRE_SPIN_LOCK(_gen->sync); }

   ^

|

515 | if (new_gen != gen) { ACQUIRE_SPIN_LOCK(_gen->sync); }

|   ^
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs