Re: "Merge-buddy" request
Zubin has already kindly volunteered; if a second review is needed, I also don't mind taking a look - though I might need some context. I'm @rockbmb From: ghc-devs on behalf of Alan & Kim Zimmerman Sent: 27 October 2023 16:03 To: Zubin Duggal Cc: ghc-devs Subject: Re: "Merge-buddy" request Thanks Zubin. And to re-iterate on what Simon said, I will cheerfully have a discussion with anyone who needs context for these. Alan On Fri, 27 Oct 2023, 12:24 Zubin Duggal, mailto:zu...@well-typed.com>> wrote: Feel free to assign me for reviews. On 23/10/26 17:10, Alan & Kim Zimmerman wrote: >Hi all > >I have been landing a series of MRs to simplify the exact print annotations. >They are split into pieces so each change is not too big. >I still have quite a number of them to land, but am finding the process >slow, as I > >- make the MR >- wait for CI to go green >- wait for a review, or ping people on chat to do the review >- once approved, land it. > >I don't want to loudly shout for reviewers each time, and become a general >irritant. > >Is there anyone (ideally with an interest in the exact print annotations) >that would like to be my "merge buddy" that I can easily ask to do the >reviews? > >I am happy for each one to take a couple of days, so it is not a high >pressure thing, I just want to get into a cadence on them. > >My current one is https://gitlab.haskell.org/ghc/ghc/-/merge_requests/11496. >Admittedly only one reviewer requested, and he is always busy, and I do not >want to make him even more so. > >Alan >___ >ghc-devs mailing list >ghc-devs@haskell.org<mailto:ghc-devs@haskell.org> >http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: "Merge-buddy" request
Thanks Zubin. And to re-iterate on what Simon said, I will cheerfully have a discussion with anyone who needs context for these. Alan On Fri, 27 Oct 2023, 12:24 Zubin Duggal, wrote: > Feel free to assign me for reviews. > > On 23/10/26 17:10, Alan & Kim Zimmerman wrote: > >Hi all > > > >I have been landing a series of MRs to simplify the exact print > annotations. > >They are split into pieces so each change is not too big. > >I still have quite a number of them to land, but am finding the process > >slow, as I > > > >- make the MR > >- wait for CI to go green > >- wait for a review, or ping people on chat to do the review > >- once approved, land it. > > > >I don't want to loudly shout for reviewers each time, and become a general > >irritant. > > > >Is there anyone (ideally with an interest in the exact print annotations) > >that would like to be my "merge buddy" that I can easily ask to do the > >reviews? > > > >I am happy for each one to take a couple of days, so it is not a high > >pressure thing, I just want to get into a cadence on them. > > > >My current one is > https://gitlab.haskell.org/ghc/ghc/-/merge_requests/11496. > >Admittedly only one reviewer requested, and he is always busy, and I do > not > >want to make him even more so. > > > >Alan > > >___ > >ghc-devs mailing list > >ghc-devs@haskell.org > >http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs > > ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: "Merge-buddy" request
Feel free to assign me for reviews. On 23/10/26 17:10, Alan & Kim Zimmerman wrote: Hi all I have been landing a series of MRs to simplify the exact print annotations. They are split into pieces so each change is not too big. I still have quite a number of them to land, but am finding the process slow, as I - make the MR - wait for CI to go green - wait for a review, or ping people on chat to do the review - once approved, land it. I don't want to loudly shout for reviewers each time, and become a general irritant. Is there anyone (ideally with an interest in the exact print annotations) that would like to be my "merge buddy" that I can easily ask to do the reviews? I am happy for each one to take a couple of days, so it is not a high pressure thing, I just want to get into a cadence on them. My current one is https://gitlab.haskell.org/ghc/ghc/-/merge_requests/11496. Admittedly only one reviewer requested, and he is always busy, and I do not want to make him even more so. Alan ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: "Merge-buddy" request
I hope someone responds to Alan's call. Simplifying exact-print annotations is a noble goal, and Alan has been working hard on it. I hope someone feels able to support him. I don't think you need to be an exact-print expert. I'm sure Alan would be happy to teach you. And that learning journey might be very useful in itself, because it'll tell you want extra documentation (especially overview notes) is needed. Big thanks to Alan Simon On Thu, 26 Oct 2023 at 18:11, Alan & Kim Zimmerman wrote: > Hi all > > I have been landing a series of MRs to simplify the exact print > annotations. > They are split into pieces so each change is not too big. > I still have quite a number of them to land, but am finding the process > slow, as I > > - make the MR > - wait for CI to go green > - wait for a review, or ping people on chat to do the review > - once approved, land it. > > I don't want to loudly shout for reviewers each time, and become a general > irritant. > > Is there anyone (ideally with an interest in the exact print annotations) > that would like to be my "merge buddy" that I can easily ask to do the > reviews? > > I am happy for each one to take a couple of days, so it is not a high > pressure thing, I just want to get into a cadence on them. > > My current one is > https://gitlab.haskell.org/ghc/ghc/-/merge_requests/11496. Admittedly > only one reviewer requested, and he is always busy, and I do not want to > make him even more so. > > Alan > > ___ > ghc-devs mailing list > ghc-devs@haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs > ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
"Merge-buddy" request
Hi all I have been landing a series of MRs to simplify the exact print annotations. They are split into pieces so each change is not too big. I still have quite a number of them to land, but am finding the process slow, as I - make the MR - wait for CI to go green - wait for a review, or ping people on chat to do the review - once approved, land it. I don't want to loudly shout for reviewers each time, and become a general irritant. Is there anyone (ideally with an interest in the exact print annotations) that would like to be my "merge buddy" that I can easily ask to do the reviews? I am happy for each one to take a couple of days, so it is not a high pressure thing, I just want to get into a cadence on them. My current one is https://gitlab.haskell.org/ghc/ghc/-/merge_requests/11496. Admittedly only one reviewer requested, and he is always busy, and I do not want to make him even more so. Alan ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
