RE: [GHC] #16348: GHC HEAD regression: tyConAppArgs
On March 6, 2019 4:23:37 AM EST, Simon Peyton Jones wrote: >| * Tickets will have notes added when they are mentioned by a commit >| message. As we discussed earlier, messages won't include the >commit >| message text but rather only a reference to the referring commit >SHA. >| For instance, this looks like [1]. > >I thought we'd decided, for now anyway, to /include/ the commit message >text. (Matthew dissented.) Is that hard to do? > >Simon > > Oh dear, I will need to look back over my notes. I suspect my memory has failed me here. Regardless, it is not particularly hard to include commit messages. Cheers, - Ben -- Sent from my Android device with K-9 Mail. Please excuse my brevity. ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: [GHC] #16348: GHC HEAD regression: tyConAppArgs
On March 6, 2019 2:06:25 AM EST, Bryan Richter wrote: >Ben wrote: >> Unfortunately a mention of a ticket from a commit does not produce >a notification email. This is in my opinion a rather serious issue that >we will need to work around since it makes closing tickets after merge >far >more painful than necessary. > >Is there something in the GHC workflow that precludes the normal Gitlab >behavior of automatically closing issues after a merge? There just >needs to >be a commit message or MR description with the words "Closes #xxx" [1]. > >Or perhaps you were talking specifically about Trac? > >I'm just spectating this from a distance so might have misunderstood >the >problem. > >[1]: Full details at >https://docs.gitlab.com/ee/user/project/issues/closing_issues.html#via-merge-request > The problem is that you very often want to review the ticket before closing it. There might be several reasons for this: - You might believe that your commit closes the ticket but perhaps there is a facet of the problem that you are forgetting - You might want to write a final summary of the solution - Perhaps there is an additional refactoring that you thought of while writing your patch that you would like to open a new ticket to track. - Maybe you just want to mark the patch to be back ported to the stable branch. The general theme here is that looking over the ticket one last time before closing is a helpful practice that allows us to catch problems early and keep our issue tracker tidy. It would be quite unfortunate to lose this ability. Cheers, - Ben >On Wed, 6 Mar 2019, 5.57 Ben Gamari, wrote: > >> Simon Peyton Jones via ghc-devs writes: >> >> > Matthew, Ben >> > >> > I've just received 40-odd messages like this one. It looks as if >Marge >> > is now sending commit messages at Trac ticket messages, which is >> > great. Will that happen after the move to GitLab. >> > >> > Also, is this sudden wave because a whole lot of commits have now >> > landed in master? Or is it somehow an old backlog stuck in a mail >> > queue? >> > >> This happened because the GitLab -> git.haskell.org mirroring >> process was stuck. Yesterday I un-stuck it which then triggered the >push >> of approximately 40 commits, triggering the old Trac commit notifier >> which produced the messages you received. >> >> Regarding commit notifications after we migrate: >> >> * Tickets will have notes added when they are mentioned by a commit >>message. As we discussed earlier, messages won't include the >commit >>message text but rather only a reference to the referring commit >SHA. >>For instance, this looks like [1]. >> >>If we find the indirection between the ticket and the mentioning >>commit message to be problematic we can certainly revisit this. >> >> * Commit notifications will be sent to ghc-comm...@haskell.org; the >>format will change a bit but the overall content won't change. >> >> * Unfortunately a mention of a ticket from a commit does not produce >a >>notification email. This is in my opinion a rather serious issue >that >>we will need to work around since it makes closing tickets after >>merge far more painful than necessary. >> >> >> > There may be some housekeeping to do, to close tickets, check >> > regression tests and add pointers to the appropriate tests. Is >anyone >> > up for doing that? >> > >> Yes, I have been accumulating a sizeable queue of tickets to >> sort through. I've started working through this but certainly won't >> finish tonight. I have a few other obligations tomorrow but I'll try >to >> pick it up again later in the day. >> >> Cheers, >> >> - Ben >> >> >> >> [1] >https://gitlab.staging.haskell.org/ghc/ghc/issues/16260#note_173847 >> ___ >> ghc-devs mailing list >> ghc-devs@haskell.org >> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs >> -- Sent from my Android device with K-9 Mail. Please excuse my brevity. ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
RE: [GHC] #16348: GHC HEAD regression: tyConAppArgs
| * Tickets will have notes added when they are mentioned by a commit | message. As we discussed earlier, messages won't include the commit | message text but rather only a reference to the referring commit SHA. | For instance, this looks like [1]. I thought we'd decided, for now anyway, to /include/ the commit message text. (Matthew dissented.) Is that hard to do? Simon | -Original Message- | From: Ben Gamari | Sent: 06 March 2019 03:58 | To: Simon Peyton Jones ; Matthew Pickering | | Cc: ghc-devs@haskell.org | Subject: RE: [GHC] #16348: GHC HEAD regression: tyConAppArgs | | Simon Peyton Jones via ghc-devs writes: | | > Matthew, Ben | > | > I've just received 40-odd messages like this one. It looks as if Marge | > is now sending commit messages at Trac ticket messages, which is | > great. Will that happen after the move to GitLab. | > | > Also, is this sudden wave because a whole lot of commits have now | > landed in master? Or is it somehow an old backlog stuck in a mail | > queue? | > | This happened because the GitLab -> git.haskell.org mirroring process | was stuck. Yesterday I un-stuck it which then triggered the push of | approximately 40 commits, triggering the old Trac commit notifier which | produced the messages you received. | | Regarding commit notifications after we migrate: | | * Tickets will have notes added when they are mentioned by a commit | message. As we discussed earlier, messages won't include the commit | message text but rather only a reference to the referring commit SHA. | For instance, this looks like [1]. | | If we find the indirection between the ticket and the mentioning | commit message to be problematic we can certainly revisit this. | | * Commit notifications will be sent to ghc-comm...@haskell.org; the | format will change a bit but the overall content won't change. | | * Unfortunately a mention of a ticket from a commit does not produce a | notification email. This is in my opinion a rather serious issue that | we will need to work around since it makes closing tickets after | merge far more painful than necessary. | | | > There may be some housekeeping to do, to close tickets, check | > regression tests and add pointers to the appropriate tests. Is anyone | > up for doing that? | > | Yes, I have been accumulating a sizeable queue of tickets to sort | through. I've started working through this but certainly won't finish | tonight. I have a few other obligations tomorrow but I'll try to pick it | up again later in the day. | | Cheers, | | - Ben | | | | [1] https://gitlab.staging.haskell.org/ghc/ghc/issues/16260#note_173847 ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
RE: [GHC] #16348: GHC HEAD regression: tyConAppArgs
Simon Peyton Jones via ghc-devs writes: > Matthew, Ben > > I've just received 40-odd messages like this one. It looks as if Marge > is now sending commit messages at Trac ticket messages, which is > great. Will that happen after the move to GitLab. > > Also, is this sudden wave because a whole lot of commits have now > landed in master? Or is it somehow an old backlog stuck in a mail > queue? > This happened because the GitLab -> git.haskell.org mirroring process was stuck. Yesterday I un-stuck it which then triggered the push of approximately 40 commits, triggering the old Trac commit notifier which produced the messages you received. Regarding commit notifications after we migrate: * Tickets will have notes added when they are mentioned by a commit message. As we discussed earlier, messages won't include the commit message text but rather only a reference to the referring commit SHA. For instance, this looks like [1]. If we find the indirection between the ticket and the mentioning commit message to be problematic we can certainly revisit this. * Commit notifications will be sent to ghc-comm...@haskell.org; the format will change a bit but the overall content won't change. * Unfortunately a mention of a ticket from a commit does not produce a notification email. This is in my opinion a rather serious issue that we will need to work around since it makes closing tickets after merge far more painful than necessary. > There may be some housekeeping to do, to close tickets, check > regression tests and add pointers to the appropriate tests. Is anyone > up for doing that? > Yes, I have been accumulating a sizeable queue of tickets to sort through. I've started working through this but certainly won't finish tonight. I have a few other obligations tomorrow but I'll try to pick it up again later in the day. Cheers, - Ben [1] https://gitlab.staging.haskell.org/ghc/ghc/issues/16260#note_173847 signature.asc Description: PGP signature ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
RE: [GHC] #16348: GHC HEAD regression: tyConAppArgs
Matthew, Ben
I've just received 40-odd messages like this one. It looks as if Marge is now
sending commit messages at Trac ticket messages, which is great. Will that
happen after the move to GitLab.
Also, is this sudden wave because a whole lot of commits have now landed in
master? Or is it somehow an old backlog stuck in a mail queue?
There may be some housekeeping to do, to close tickets, check regression tests
and add pointers to the appropriate tests. Is anyone up for doing that?
Thanks
Simon
| -Original Message-
| From: ghc-tickets On Behalf Of GHC
| Sent: 04 March 2019 18:51
| Subject: Re: [GHC] #16348: GHC HEAD regression: tyConAppArgs
|
| #16348: GHC HEAD regression: tyConAppArgs
| -+-
| Reporter: RyanGlScott |Owner: (none)
| Type: bug | Status: closed
| Priority: highest |Milestone: 8.10.1
|Component: Compiler | Version: 8.7
| Resolution: fixed | Keywords:
| Operating System: Unknown/Multiple | Architecture:
| | Unknown/Multiple
| Type of failure: Compile-time |Test Case:
| crash or panic | simplCore/should_compile/T16348
| Blocked By:| Blocking:
| Related Tickets:| Differential Rev(s):
|Wiki Page:|
| https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha
| skell.org%2Fghc%2Fghc%2Fmerge_requests%2F416data=02%7C01%7Csimonpj%40m
| icrosoft.com%7C50e6bec9985e4121351808d6a0d2a90f%7C72f988bf86f141af91ab2d7cd
| 011db47%7C1%7C0%7C636873224010230414sdata=SvX8wLsObYmasJTvB6yT9CQbxoFK
| ZkdGpv7ZHfDRqYs%3Dreserved=0
| -+-
|
| Comment (by Matthew Pickering ):
|
| In [changeset:"c25b135ff5b9c69a90df0ccf51b04952c2dc6ee1/ghc"
| c25b135f/ghc]:
| {{{
| #!CommitTicketReference repository="ghc"
| revision="c25b135ff5b9c69a90df0ccf51b04952c2dc6ee1"
| Fix exprIsConApp_maybe
|
| In this commit
| commit 7833cf407d1f608bebb1d38bb99d3035d8d735e6
| Date: Thu Jan 24 17:58:50 2019 +0100
|Look through newtype wrappers (Trac #16254)
|
| we made exprIsConApp_maybe quite a bit cleverer. But I had not paid
| enough attention to keeping exactly the correct substitution and
| in-scope set, which led to Trac #16348.
|
| There were several buglets (like applying the substitution twice in
| exprIsConApp_maybe, but the proximate source of the bug was that we were
| calling addNewInScopeIds, which deleted things from the substitution as
| well as adding them to the in-scope set. That's usually right, but not
| here!
|
| This was quite tricky to track down. But it is nicer now.
| }}}
|
| --
| Ticket URL:
| <https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.haske
| ll.org%2Ftrac%2Fghc%2Fticket%2F16348%23comment%3A7data=02%7C01%7Csimon
| pj%40microsoft.com%7C50e6bec9985e4121351808d6a0d2a90f%7C72f988bf86f141af91a
| b2d7cd011db47%7C1%7C0%7C636873224010230414sdata=Hmm1p52EqBpdLX1sFkutPm
| Z8hSjY%2FtzS1FZqlFYCxYI%3Dreserved=0>
| GHC
| <https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.haske
| ll.org%2Fghc%2Fdata=02%7C01%7Csimonpj%40microsoft.com%7C50e6bec9985e41
| 21351808d6a0d2a90f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63687322401
| 0230414sdata=AuTz%2BM22brpeoXARiWrhvqlGd4w2myu1YNobnhj16L8%3Drese
| rved=0>
| The Glasgow Haskell Compiler
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
