Re: [commit: ghc] master: Remove -ddump-simpl-phases flag (ad8457f)

2014-11-06 Thread Johan Tibell
I think this flag is useful for debugging e.g. why something didn't
optimize the way you thought.
On Nov 6, 2014 1:05 PM, g...@git.haskell.org wrote:

 Repository : ssh://g...@git.haskell.org/ghc

 On branch  : master
 Link   :
 http://ghc.haskell.org/trac/ghc/changeset/ad8457f93807e3b7a9a24867ed69dc93662a29e3/ghc

 ---

 commit ad8457f93807e3b7a9a24867ed69dc93662a29e3
 Author: Jan Stolarek jan.stola...@p.lodz.pl
 Date:   Wed Nov 5 13:37:25 2014 +0100

 Remove -ddump-simpl-phases flag


 ---

 ad8457f93807e3b7a9a24867ed69dc93662a29e3
  compiler/main/DynFlags.hs| 15 +++
  compiler/simplCore/CoreMonad.lhs | 40
 ++--
  compiler/simplCore/SimplCore.lhs |  9 +
  docs/users_guide/debugging.xml   | 11 ---
  docs/users_guide/flags.xml   |  6 --
  5 files changed, 14 insertions(+), 67 deletions(-)

 Diff suppressed because of size. To see it, use:

 git diff-tree --root --patch-with-stat --no-color --find-copies-harder
 --ignore-space-at-eol --cc ad8457f93807e3b7a9a24867ed69dc93662a29e3
 ___
 ghc-commits mailing list
 ghc-comm...@haskell.org
 http://www.haskell.org/mailman/listinfo/ghc-commits

___
ghc-devs mailing list
ghc-devs@haskell.org
http://www.haskell.org/mailman/listinfo/ghc-devs


Re: [commit: ghc] master: Remove -ddump-simpl-phases flag (ad8457f)

2014-11-06 Thread Jan Stolarek
Simon Marlow wrote:
 isn't -ddump-simpl-phases useful?  what's the other way to do that?
-dverbose-core2core + -ddump-simple-stats

Johan Tibell wrote:
 I think this flag is useful for debugging e.g. why something didn't
 optimize the way you thought.
Well, you can get that information using flags mentioned above. It seemed that 
-ddump-simpl-phases 
is not used and can be safely removed. It wasn't documented at all, so the only 
way to figure out 
how it works was to look hard at the code. The output itself was rather cryptic 
- no information 
about the phase for which the stats are displayed. Again, the only way to make 
sense of that 
output was looking at the code to figure out the precise ordering of Core 
optimisations. 
With -dverbose-core2core the output makes a lot more sense because it directly 
follows the output 
of the phase.

Simon PJ and Austin spoke in favour of removing that flag, so I went ahead and 
did that. But if 
indeed was used by someone to do their work we could revert that.

Janek
___
ghc-devs mailing list
ghc-devs@haskell.org
http://www.haskell.org/mailman/listinfo/ghc-devs