Changes in Hoopl

2013-08-22 Thread Jan Stolarek
Me and Simon PJ had some discussion about modifying Hoopl. I summarized that 
discussion on a wiki page:

http://ghc.haskell.org/trac/ghc/wiki/Hoopl/Cleanup

I'd like to implement changes once there's a consensus on which changes exactly 
do we want in Hoopl.

Janek

___
ghc-devs mailing list
ghc-devs@haskell.org
http://www.haskell.org/mailman/listinfo/ghc-devs


Re: Changes in Hoopl

2013-08-22 Thread David Luposchainsky
Hey Janek,

as a remark, Hoopl is the only library in GHC that defines its own *
operation, which will clash with the AMP. Hoopl's * is conceptually
just `mappend`, so if you're doing a large-scale refactoring of the
module maybe consider adding a suitable Monoid instance to replace *
with  before it even becomes a problem.

David

___
ghc-devs mailing list
ghc-devs@haskell.org
http://www.haskell.org/mailman/listinfo/ghc-devs


Re: Changes in Hoopl

2013-08-22 Thread Simon Marlow

Hi Jan,

On 22/08/13 14:01, Jan Stolarek wrote:

Me and Simon PJ had some discussion about modifying Hoopl. I summarized that 
discussion on a wiki page:

http://ghc.haskell.org/trac/ghc/wiki/Hoopl/Cleanup

I'd like to implement changes once there's a consensus on which changes exactly 
do we want in Hoopl.


I'm all for cleaning up Hoopl.  It's definitely a bit of a mess in places.

I read through your wiki page and I'm not entirely clear about what 
changes you're proposing.  e.g. it's probably true that in forward 
analysis if you specify facts for all the input labels then fact_bot is 
never used (though I'm not 100% sure about that).  But you don't say 
what you want to do with that observation.  Could you list the API 
changes you want to make?


Cheers,
Simon


___
ghc-devs mailing list
ghc-devs@haskell.org
http://www.haskell.org/mailman/listinfo/ghc-devs


RE: Changes in Hoopl

2013-08-22 Thread Simon Peyton-Jones
I have elaborated (more clearly I hope)

S

| -Original Message-
| From: Simon Marlow [mailto:marlo...@gmail.com]
| Sent: 22 August 2013 15:14
| To: Jan Stolarek
| Cc: ghc-devs; Simon Peyton-Jones; n...@cs.tufts.edu; d...@cs.tufts.edu;
| Edward Z. Yang
| Subject: Re: Changes in Hoopl
| 
| Hi Jan,
| 
| On 22/08/13 14:01, Jan Stolarek wrote:
|  Me and Simon PJ had some discussion about modifying Hoopl. I
| summarized that discussion on a wiki page:
| 
|  http://ghc.haskell.org/trac/ghc/wiki/Hoopl/Cleanup
| 
|  I'd like to implement changes once there's a consensus on which
| changes exactly do we want in Hoopl.
| 
| I'm all for cleaning up Hoopl.  It's definitely a bit of a mess in
| places.
| 
| I read through your wiki page and I'm not entirely clear about what
| changes you're proposing.  e.g. it's probably true that in forward
| analysis if you specify facts for all the input labels then fact_bot is
| never used (though I'm not 100% sure about that).  But you don't say
| what you want to do with that observation.  Could you list the API
| changes you want to make?
| 
| Cheers,
|   Simon

___
ghc-devs mailing list
ghc-devs@haskell.org
http://www.haskell.org/mailman/listinfo/ghc-devs


Re: Changes in Hoopl

2013-08-22 Thread Jan Stolarek
Simon, you give this example:

   L1: ...blah blah...
   CondBranch e L1 L2

   L2: blah blah

and say that (...) on the first iteration, we don't have any fact from L1. So 
for backwards analysis the client really must give us a bottom element.  I 
think this example does not actually demonstrate that we must have a bottom 
element, because if we have fact from L2 then we still don't need bottom in the 
same way we don't need it in forward analysis. We need bottom only when all 
entry facts are unknown.

Janek

- Oryginalna wiadomość -
Od: Simon Peyton-Jones simo...@microsoft.com
Do: Simon Marlow marlo...@gmail.com, Jan Stolarek jan.stola...@p.lodz.pl
DW: ghc-devs ghc-devs@haskell.org, n...@cs.tufts.edu, d...@cs.tufts.edu, 
Edward Z. Yang ezy...@mit.edu
Wysłane: czwartek, 22 sierpień 2013 17:44:11
Temat: RE: Changes in Hoopl

I have elaborated (more clearly I hope)

S

| -Original Message-
| From: Simon Marlow [mailto:marlo...@gmail.com]
| Sent: 22 August 2013 15:14
| To: Jan Stolarek
| Cc: ghc-devs; Simon Peyton-Jones; n...@cs.tufts.edu; d...@cs.tufts.edu;
| Edward Z. Yang
| Subject: Re: Changes in Hoopl
| 
| Hi Jan,
| 
| On 22/08/13 14:01, Jan Stolarek wrote:
|  Me and Simon PJ had some discussion about modifying Hoopl. I
| summarized that discussion on a wiki page:
| 
|  http://ghc.haskell.org/trac/ghc/wiki/Hoopl/Cleanup
| 
|  I'd like to implement changes once there's a consensus on which
| changes exactly do we want in Hoopl.
| 
| I'm all for cleaning up Hoopl.  It's definitely a bit of a mess in
| places.
| 
| I read through your wiki page and I'm not entirely clear about what
| changes you're proposing.  e.g. it's probably true that in forward
| analysis if you specify facts for all the input labels then fact_bot is
| never used (though I'm not 100% sure about that).  But you don't say
| what you want to do with that observation.  Could you list the API
| changes you want to make?
| 
| Cheers,
|   Simon


___
ghc-devs mailing list
ghc-devs@haskell.org
http://www.haskell.org/mailman/listinfo/ghc-devs