Re: HsParTy

[Alan & Kim Zimmerman]

See 3b23f680c2b1f80b693eb8896fb21e4bbf8edc7e

On 26 May 2017 at 13:32, Simon Peyton Jones  wrote:

> I can try to strip then all out and see what happens.
>
> That’d be good!  With a Note to explain why…
>
>
>
> We still need ctxt_prec, I think, to pass to the ordinary type
> pretty-printer, when we have HsCoreTy.
>
>
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

RE: HsParTy

[Simon Peyton Jones via ghc-devs]

I can try to strip then all out and see what happens.
That’d be good!  With a Note to explain why…

We still need ctxt_prec, I think, to pass to the ordinary type pretty-printer, 
when we have HsCoreTy.

Simon

From: Alan & Kim Zimmerman [mailto:alan.z...@gmail.com]
Sent: 26 May 2017 12:14
To: Simon Peyton Jones <simo...@microsoft.com>
Cc: ghc-devs@haskell.org
Subject: Re: HsParTy

When I was working through the ppr to use HsParTy everywhere it was not clear 
whether there were any usages that required maybeParen, so I left it in.
I can try to strip then all out and see what happens.
Alan

On 26 May 2017 at 10:54, Simon Peyton Jones 
<simo...@microsoft.com<mailto:simo...@microsoft.com>> wrote:
Alan
Do you know why HsTypes.ppr_mono_ty contains any uses of ‘maybeParen’?  
Shouldn’t the parens all be put in by HsParTy?
I tripped over this when I mistakenly added what I thought were missing 
maybeParen calls for HsAppTy and HsAppTys, but that was flagged as an error by 
a test in tests/printer.
So why are there /any/ maybeParen calls?
Simon

___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Re: HsParTy

[Alan & Kim Zimmerman]

When I was working through the ppr to use HsParTy everywhere it was not
clear whether there were any usages that required maybeParen, so I left it
in.

I can try to strip then all out and see what happens.

Alan


On 26 May 2017 at 10:54, Simon Peyton Jones <simo...@microsoft.com> wrote:

> Alan
>
> Do you know why HsTypes.ppr_mono_ty contains any uses of ‘maybeParen’?
> Shouldn’t the parens all be put in by HsParTy?
>
> I tripped over this when I mistakenly added what I thought were missing
> maybeParen calls for HsAppTy and HsAppTys, but that was flagged as an error
> by a test in tests/printer.
>
> So why are there /any/ maybeParen calls?
>
> Simon
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

HsParTy

[Simon Peyton Jones via ghc-devs]

Alan
Do you know why HsTypes.ppr_mono_ty contains any uses of 'maybeParen'?  
Shouldn't the parens all be put in by HsParTy?
I tripped over this when I mistakenly added what I thought were missing 
maybeParen calls for HsAppTy and HsAppTys, but that was flagged as an error by 
a test in tests/printer.
So why are there /any/ maybeParen calls?
Simon
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs