Re: [Gimp-developer] Saving black/white TIFF with 'CCITT Group 4' encoding

2007-02-11 Thread Sven Neumann
Hi,

On Sun, 2007-02-11 at 19:44 +0100, Manfred Joerg wrote:

> I just checked your revised tiff patch. 
> 
> 1. It doesn't allow the user to save a rgb image as CCITT Datagroup 3/4 even 
> if it contains only black and white pixels. Instead the user has to convert 
> the image to indexed mode black/white first.

That is the intended behavior. The user should only be allowed to select
the new compression schemes if the image is indexed with a b/w colormap.
The radio buttons should be insensitive otherwise and an allowed
compression scheme should be preselected.

As long as images saved that way are also loaded in Indexed mode with a
b/w colormap, this should be fine.


Sven


___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] strange localization behaviour (gimp-2.3-svn)

2007-02-11 Thread Sven Neumann
Hi,

On Sun, 2007-02-11 at 23:16 +0100, Marco Ciampa wrote:

> Sorry, I was too hasty. It worked for the compilation but the problem
> remains, as you can see here:
> 
> http://www.ciampix.net/screenshot.png
> 
> very strange, all the other messages looks translated... 

Not your fault. We forgot to set the translation domain for the enum.
This is now fixed in trunk.


Sven


___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] strange localization behaviour (gimp-2.3-svn)

2007-02-11 Thread Sven Neumann
Hi,

On Sun, 2007-02-11 at 22:00 +0100, Marco Ciampa wrote:

> > Then do a rebuild. The problem here is that the Makefile rules to
> > generate the files used to be broken. We fixed the Makefiles but there's
> > no dependency that would cause the broken files to be regenerated.
> Great, it worked! Perhaps that operation could be insterted in the makefile
> with the command "make clean" (if it's not already present...)

No, it shouldn't. This was only necessary once after the Makefiles were
changed (some weeks ago). You shouldn't have to do this again.


Sven


___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] strange localization behaviour (gimp-2.3-svn)

2007-02-11 Thread Marco Ciampa
On Sun, Feb 11, 2007 at 10:00:21PM +0100, Marco Ciampa wrote:
> On Thu, Feb 08, 2007 at 07:40:53AM +0100, Sven Neumann wrote:
> > Hi Marco,
> > 
> > if I remember correctly this is fixed by removing the generated files
> > POTFILES in all po subdirectories. Try this command in the toplevel gimp
> > source directory:
> > 
> >   find . -name POTFILES -exec rm {} \;
> > 
> > Then do a rebuild. The problem here is that the Makefile rules to
> > generate the files used to be broken. We fixed the Makefiles but there's
> > no dependency that would cause the broken files to be regenerated.
> Great, it worked! Perhaps that operation could be insterted in the makefile
> with the command "make clean" (if it's not already present...)
Sorry, I was too hasty. It worked for the compilation but the problem
remains, as you can see here:

http://www.ciampix.net/screenshot.png

very strange, all the other messages looks translated... 

-- 

Marco Ciampa

++
| Linux User  #78271 |
| FSFE fellow   #364 |
++
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] strange localization behaviour (gimp-2.3-svn)

2007-02-11 Thread Marco Ciampa
On Thu, Feb 08, 2007 at 07:40:53AM +0100, Sven Neumann wrote:
> Hi Marco,
> 
> if I remember correctly this is fixed by removing the generated files
> POTFILES in all po subdirectories. Try this command in the toplevel gimp
> source directory:
> 
>   find . -name POTFILES -exec rm {} \;
> 
> Then do a rebuild. The problem here is that the Makefile rules to
> generate the files used to be broken. We fixed the Makefiles but there's
> no dependency that would cause the broken files to be regenerated.
Great, it worked! Perhaps that operation could be insterted in the makefile
with the command "make clean" (if it's not already present...)

Thanks again. 

-- 

Marco Ciampa

++
| Linux User  #78271 |
| FSFE fellow   #364 |
++
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Saving black/white TIFF with 'CCITT Group 4' encoding

2007-02-11 Thread Manfred Joerg
Hello Sven,

I just checked your revised tiff patch. 

1. It doesn't allow the user to save a rgb image as CCITT Datagroup 3/4 even 
if it contains only black and white pixels. Instead the user has to convert 
the image to indexed mode black/white first. For my sample image (4048 x 6648 
pixels) that takes 50 seconds on a Pentium IV 3 GHz machine (no colour 
dithering). 

There are three ways to improve this:
- Allow the user to save images of all modes as CCITT. The tiff library can 
handle this if the image contains only black and white pixels. Otherwise the 
tiff library returns an error code.
- Improve the speed of the conversion to indexed mode.
- Add an option to the threshold tool which automatically creates an indexed 
black white image


2. The tiff files created by the Gimp are 4% greater than the ones created by 
Irfanview. Are you using the latest version of the tiff library? However it's 
not so bad. The tiff files generated by XnView are 13% greater.


Apart from that the patch works fine. I checked it under Windows. I saved some 
files and opened them with Irfanview and XnView.


Regards
Manfred


On Thursday 01 February 2007 09:34, Sven Neumann wrote:
> Hi,
> I've attached a revised patch some days ago. Did you (or anyone else)
> get a chance to try it? I would like to commit this as soon as possible
> but the patch needs some more testing before it can go in.
>
>
> Sven
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer