Re: [Gimp-developer] Missing libgimpwidgets/gimpbusybox.h include file after GIMP installation
Hi! Fix confirmed. Thanks! > On 08 Jun 2018, at 19:00, Michael Natterer wrote: > > Thanks, fixed in master and gimp-2-10: > > ommit def91dfc59ad809317b943c51cdd65fc34d7f77b > Author: Michael Natterer > Date: Fri Jun 8 18:58:04 2018 +0200 > >libgimpwidgets: install gimpbusybox.h as public header > >(cherry picked from commit > b75cbcb417687eb3e245096d93af744c095db305) > > On Fri, 2018-06-08 at 18:10 +0200, Carmelo DrRaw wrote: >> Dear developers, >> >> today we noticed (thanks to Elle Stone for pointing this out) that >> the compilation of several plug-ins fails due to a missing >> "libgimpwidgets/gimpbusybox.h” include file. >> >> Here is a typical build error: >> >> In file included from /zyx/include/gimp-2.0/libgimp/gimpui.h:24:0, >> from resynth-gui.c:41: >> /zyx/include/gimp-2.0/libgimpwidgets/gimpwidgets.h:30:40: fatal >> error: libgimpwidgets/gimpbusybox.h: No such file or directory >> #include >> >> >> I guess this file should be included in the >> “libgimpwidgetsinclude_HEADERS” list in libgimpwidgets/Makefile.in in >> order to be correctly installed under “$prefix/include/gimp- >> 2.0/libgimpwidgets”. >> >> ___ >> gimp-developer-list mailing list >> List address:gimp-developer-list@gnome.org >> List membership: https://mail.gnome.org/mailman/listinfo/gimp-develop >> er-list >> List archives: https://mail.gnome.org/archives/gimp-developer-list ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
Re: [Gimp-developer] Missing libgimpwidgets/gimpbusybox.h include file after GIMP installation
Thanks, fixed in master and gimp-2-10: ommit def91dfc59ad809317b943c51cdd65fc34d7f77b Author: Michael Natterer Date: Fri Jun 8 18:58:04 2018 +0200 libgimpwidgets: install gimpbusybox.h as public header (cherry picked from commit b75cbcb417687eb3e245096d93af744c095db305) On Fri, 2018-06-08 at 18:10 +0200, Carmelo DrRaw wrote: > Dear developers, > > today we noticed (thanks to Elle Stone for pointing this out) that > the compilation of several plug-ins fails due to a missing > "libgimpwidgets/gimpbusybox.h” include file. > > Here is a typical build error: > > In file included from /zyx/include/gimp-2.0/libgimp/gimpui.h:24:0, > from resynth-gui.c:41: > /zyx/include/gimp-2.0/libgimpwidgets/gimpwidgets.h:30:40: fatal > error: libgimpwidgets/gimpbusybox.h: No such file or directory > #include > > > I guess this file should be included in the > “libgimpwidgetsinclude_HEADERS” list in libgimpwidgets/Makefile.in in > order to be correctly installed under “$prefix/include/gimp- > 2.0/libgimpwidgets”. > > ___ > gimp-developer-list mailing list > List address:gimp-developer-list@gnome.org > List membership: https://mail.gnome.org/mailman/listinfo/gimp-develop > er-list > List archives: https://mail.gnome.org/archives/gimp-developer-list ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
[Gimp-developer] Missing libgimpwidgets/gimpbusybox.h include file after GIMP installation
Dear developers, today we noticed (thanks to Elle Stone for pointing this out) that the compilation of several plug-ins fails due to a missing "libgimpwidgets/gimpbusybox.h” include file. Here is a typical build error: In file included from /zyx/include/gimp-2.0/libgimp/gimpui.h:24:0, from resynth-gui.c:41: /zyx/include/gimp-2.0/libgimpwidgets/gimpwidgets.h:30:40: fatal error: libgimpwidgets/gimpbusybox.h: No such file or directory #include I guess this file should be included in the “libgimpwidgetsinclude_HEADERS” list in libgimpwidgets/Makefile.in in order to be correctly installed under “$prefix/include/gimp-2.0/libgimpwidgets”. ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
Re: [Gimp-developer] GIMP Git gimp_too_cursors_get_resource error MacOS
On Fri, 2018-06-08 at 06:36 -0400, Partha Bagchi wrote: > On Fri, Jun 8, 2018 at 2:56 AM Michael Natterer > wrote: > > > On Thu, 2018-06-07 at 11:28 -0400, Partha Bagchi wrote: > > > I get the following: > > > > > > Undefined symbols for architecture x86_64: > > > "_gimp_tool_cursors_get_resource", referenced from: > > > -u command line option > > > ld: symbol(s) not found for architecture x86_64 > > > clang: error: linker command failed with exit code 1 (use -v to > > > see > > > invocation) > > > make[3]: *** [gimp-console-2.99] Error 1 > > > > > > > > > This is due to this line in ./app/Makefile > > > > > > #\ > > > # -Wl,-u,$(SYMPREFIX)gimp_tool_cursors_get_resource > > > > > > > > > I think this should not be there. After I comment it out, it > > > compiles > > > normally. > > > > But you probably have no cursors :) > > > > How do I verify that? Wouldn't I have had this issue when I was > compiling > GIMP 2.10? Little confused. :) Cursor resource genration was changed in master, we now generate them in the directory where they are compiled , but they have to be linked in by force because nothing in the source references the symbol. Just check if you tools have different cursors. > > > > The symbol must be there is the resource file was properly > > generated. > > > > I assume the resource file is ./app/widgets/gimp-tool-cursors.c? This > file > is identical to GIMP-2.10/cursors/gimp-tool-cursors.c. So, does that > mean > it was generated properly? > > I also noticed that GIMP 2.10 Makfile.am didn't include that line > while > GIMP 2.99.1 does. > > > > > --Mitch > > > > Thanks, > Partha ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
Re: [Gimp-developer] GIMP Git gimp_too_cursors_get_resource error MacOS
On Fri, Jun 8, 2018 at 2:56 AM Michael Natterer wrote: > On Thu, 2018-06-07 at 11:28 -0400, Partha Bagchi wrote: > > I get the following: > > > > Undefined symbols for architecture x86_64: > > "_gimp_tool_cursors_get_resource", referenced from: > > -u command line option > > ld: symbol(s) not found for architecture x86_64 > > clang: error: linker command failed with exit code 1 (use -v to see > > invocation) > > make[3]: *** [gimp-console-2.99] Error 1 > > > > > > This is due to this line in ./app/Makefile > > > > #\ > > # -Wl,-u,$(SYMPREFIX)gimp_tool_cursors_get_resource > > > > > > I think this should not be there. After I comment it out, it compiles > > normally. > > But you probably have no cursors :) > How do I verify that? Wouldn't I have had this issue when I was compiling GIMP 2.10? Little confused. :) > > The symbol must be there is the resource file was properly generated. > I assume the resource file is ./app/widgets/gimp-tool-cursors.c? This file is identical to GIMP-2.10/cursors/gimp-tool-cursors.c. So, does that mean it was generated properly? I also noticed that GIMP 2.10 Makfile.am didn't include that line while GIMP 2.99.1 does. > > --Mitch > Thanks, Partha ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
Re: [Gimp-developer] GIMP Git gimp_too_cursors_get_resource error MacOS
On Thu, 2018-06-07 at 11:28 -0400, Partha Bagchi wrote: > I get the following: > > Undefined symbols for architecture x86_64: > "_gimp_tool_cursors_get_resource", referenced from: > -u command line option > ld: symbol(s) not found for architecture x86_64 > clang: error: linker command failed with exit code 1 (use -v to see > invocation) > make[3]: *** [gimp-console-2.99] Error 1 > > > This is due to this line in ./app/Makefile > > #\ > # -Wl,-u,$(SYMPREFIX)gimp_tool_cursors_get_resource > > > I think this should not be there. After I comment it out, it compiles > normally. But you probably have no cursors :) The symbol must be there is the resource file was properly generated. --Mitch ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
