Re: [Gimp-developer] Spyrogimp plugin rewrite

[Jehan Pagès via gimp-developer-list]

P.S.: As you can guess, I never took the time to actually look into
re-implementing the clone as an available tool in your plug-in. That was a
cool feature, but I don't think if I will make the time to add it (as I
don't need it other than it's cool :P). So feel free to just add it back if
ever you manage to fix the issue previously raised. :-)

On Thu, Jan 24, 2019 at 1:23 AM Jehan Pagès 
wrote:

> Hi Elad,
>
> Sorry for the delay before inclusion. I must admit I completely forgot
> (just while doing something else tonight, I suddenly remembered this
> proposal for an updated Spyrogimp!).
>
> So I took some time tonight to review again, then finally pushed your
> plug-in.
> I just did some trailing whitespace cleaning, and also simply renamed it
> to "plug-in-spyrogimp", basically dropping the "Plus" part. I understand
> that the "plus" was about saying it is another more advanced plug-in, but I
> prefer to think of it as just a new version of the same plug-in (even
> though a total rewrite), so that we can later on just drop the old version
> (maybe when moving to GIMP 3?). When this happens, if there is only one
> plug-in and it is named "plus", it makes not much sense. I guess. :-)
>
> Anyway here is the commit for the initial code you provided, as-is:
> https://gitlab.gnome.org/GNOME/gimp/commit/a702c6a3270485e1320521c89499e1b3270477d4
> And here my commit with the slight changes:
> https://gitlab.gnome.org/GNOME/gimp/commit/e91028df2f9669fe2d98f05a969692695a62003f
>
> I hope you will stay around for any fixes which might be needed later on.
> :-)
> Do you have a GNOME gitlab account?
>
> Jehan
>
> On Sun, Nov 18, 2018 at 9:24 PM Jehan Pagès 
> wrote:
>
>> Hi!
>>
>> On Sun, Nov 18, 2018 at 8:58 PM Elad Shahar  wrote:
>>
>>> Hi Jehan,
>>>
>>> Thanks for the review!
>>> The new version is here
>>> 
>>>
>>> Here is what I have done:
>>>
>>> * The problem with the background color happens only in some themes,
>>> when using a notebook where the tabs are set to be invisible. That was what
>>> I was using.
>>> I did not manage to make the odd background color go away, so I just
>>> changed the UI to use a notebook with the tabs visible.  So this should be
>>> solved.
>>>
>>> * As for the clone issue, I did not manage to fix the issue, so I just
>>> removed "Clone" from the list of tools.
>>>
>>
>> Sad! The clone source seemed like a cool feature. I'll see if I can fix
>> this myself then. :-)
>>
>> Jehan
>>
>>
>>> Thanks!
>>> Elad
>>>
>>> On Wed, Nov 14, 2018 at 6:54 PM Jehan Pagès 
>>> wrote:
>>>
 Hi!

 On Sun, Oct 14, 2018 at 12:47 AM Elad Shahar 
 wrote:

> Hi Jehan,
>
> Thanks for your feedback!
> The new version is here
>  .
>
> Here is what I have done:
>
> * I made "Esc" close the dialog (and cancel the pattern).
> * The issue with the broken icon was part of a larger issue that made
> the plugin look different than other plugins. This was resolved by using
> gimpui.py
> * I added a non-interactive API.
> * I made the dialog less tall, by grouping parameters in notebook tabs.
>
> In addition:
>
> * Using the "selection" shape now draws multiple shapes - if several
> paths were generated from the selection-to-path conversion.
> * Several new multi-sided shapes were added as fixed rings, with
> additional options.
>   These produce drawings similar to many guilloche patterns. Examples
> for the new shapes are here
> .
> * I added "long-gradient" support, that spreads across the entire
> pattern.
>   This was available in the previous spyrogimp.scm, and produces nice
> results which are difficult to obtain when trying to tune the gradient 
> from
> tool settings.
> * Improved the speed of incremental drawing by using gobject.idle_add
> instead of timeouts.
>
> I'd be glad to fix any other issues.
>

 So I finally reviewed.

 * The background color of self.pattern_notebook is always white, which
 is especially a problem with darker themes. Is it only for me? Don't you
 have this issue too? I had a look and am unsure where this comes from
 though (maybe it's a problem in the theme, but I have no idea).

 * I had once a warning about broken undo when setting "Clone" (then I
 had a warning about no clone source, but this one is normal) then canceling
 with Esc.

 Apart from these, it looks good here. :-)

 Jehan


> If the plugin is indeed updated in the repository, could I write
> documentation for the manual?
>
> Thanks!
> Elad
>
> On Sun, Sep 16, 2018 at 10:34 PM Jehan Pagès <
> jehan.marmott...@gmail.com> wrote:
>
>> Hi Elad,
>>
>> On Sat, Sep 15, 

Re: [Gimp-developer] Spyrogimp plugin rewrite

[Jehan Pagès via gimp-developer-list]

Hi Elad,

Sorry for the delay before inclusion. I must admit I completely forgot
(just while doing something else tonight, I suddenly remembered this
proposal for an updated Spyrogimp!).

So I took some time tonight to review again, then finally pushed your
plug-in.
I just did some trailing whitespace cleaning, and also simply renamed it to
"plug-in-spyrogimp", basically dropping the "Plus" part. I understand that
the "plus" was about saying it is another more advanced plug-in, but I
prefer to think of it as just a new version of the same plug-in (even
though a total rewrite), so that we can later on just drop the old version
(maybe when moving to GIMP 3?). When this happens, if there is only one
plug-in and it is named "plus", it makes not much sense. I guess. :-)

Anyway here is the commit for the initial code you provided, as-is:
https://gitlab.gnome.org/GNOME/gimp/commit/a702c6a3270485e1320521c89499e1b3270477d4
And here my commit with the slight changes:
https://gitlab.gnome.org/GNOME/gimp/commit/e91028df2f9669fe2d98f05a969692695a62003f

I hope you will stay around for any fixes which might be needed later on.
:-)
Do you have a GNOME gitlab account?

Jehan

On Sun, Nov 18, 2018 at 9:24 PM Jehan Pagès 
wrote:

> Hi!
>
> On Sun, Nov 18, 2018 at 8:58 PM Elad Shahar  wrote:
>
>> Hi Jehan,
>>
>> Thanks for the review!
>> The new version is here
>> 
>>
>> Here is what I have done:
>>
>> * The problem with the background color happens only in some themes, when
>> using a notebook where the tabs are set to be invisible. That was what I
>> was using.
>> I did not manage to make the odd background color go away, so I just
>> changed the UI to use a notebook with the tabs visible.  So this should be
>> solved.
>>
>> * As for the clone issue, I did not manage to fix the issue, so I just
>> removed "Clone" from the list of tools.
>>
>
> Sad! The clone source seemed like a cool feature. I'll see if I can fix
> this myself then. :-)
>
> Jehan
>
>
>> Thanks!
>> Elad
>>
>> On Wed, Nov 14, 2018 at 6:54 PM Jehan Pagès 
>> wrote:
>>
>>> Hi!
>>>
>>> On Sun, Oct 14, 2018 at 12:47 AM Elad Shahar 
>>> wrote:
>>>
 Hi Jehan,

 Thanks for your feedback!
 The new version is here
  .

 Here is what I have done:

 * I made "Esc" close the dialog (and cancel the pattern).
 * The issue with the broken icon was part of a larger issue that made
 the plugin look different than other plugins. This was resolved by using
 gimpui.py
 * I added a non-interactive API.
 * I made the dialog less tall, by grouping parameters in notebook tabs.

 In addition:

 * Using the "selection" shape now draws multiple shapes - if several
 paths were generated from the selection-to-path conversion.
 * Several new multi-sided shapes were added as fixed rings, with
 additional options.
   These produce drawings similar to many guilloche patterns. Examples
 for the new shapes are here
 .
 * I added "long-gradient" support, that spreads across the entire
 pattern.
   This was available in the previous spyrogimp.scm, and produces nice
 results which are difficult to obtain when trying to tune the gradient from
 tool settings.
 * Improved the speed of incremental drawing by using gobject.idle_add
 instead of timeouts.

 I'd be glad to fix any other issues.

>>>
>>> So I finally reviewed.
>>>
>>> * The background color of self.pattern_notebook is always white, which
>>> is especially a problem with darker themes. Is it only for me? Don't you
>>> have this issue too? I had a look and am unsure where this comes from
>>> though (maybe it's a problem in the theme, but I have no idea).
>>>
>>> * I had once a warning about broken undo when setting "Clone" (then I
>>> had a warning about no clone source, but this one is normal) then canceling
>>> with Esc.
>>>
>>> Apart from these, it looks good here. :-)
>>>
>>> Jehan
>>>
>>>
 If the plugin is indeed updated in the repository, could I write
 documentation for the manual?

 Thanks!
 Elad

 On Sun, Sep 16, 2018 at 10:34 PM Jehan Pagès <
 jehan.marmott...@gmail.com> wrote:

> Hi Elad,
>
> On Sat, Sep 15, 2018 at 4:14 PM Elad Shahar via gimp-developer-list <
> gimp-developer-list@gnome.org> wrote:
>
>> Hi,
>>
>> Long ago, I have written a Spyrogimp plugin in scheme. The plugin is
>> currently included in gimp (under Filters -> Render -> Spyrogimp).
>> Now I
>> have done a rewrite in python which I hope is a big improvement:
>>
>> * It provides immediate feedback, by incremental drawing to a
>> temporary
>> layer.
>> * Supports using more tools to draw the pattern (e.g. stroke).
>> * You can use a