Re: [Gimp-developer] Big problem with Gimp G'MIC with upcoming Gimp 2.10
On 27.4.2014 at 2:05 AM Jehan Pagès wrote: On Sun, Apr 27, 2014 at 4:55 AM, Jon Nordby jono...@gmail.com wrote: One could set up g'mic or another well-maintained C++ plugin for GIMP to build on Jenkins? That way these errors would be quickly (and hopefully fixed). Actually more simply a very simple do-nothing C++ plugin, yet which includes all possible libgimp headers, could be integrated in the tree as a C++ compilation test to be run during `make check`. That would also catch these kind of bugs. Two souls are dwelling in my in my breast: As GIMP is also a platform for programming cutting-edge image processing algorithms by scientists and artists I think it's a good idea to test the exposed GIMP interface for this purpose. G'MIC with its scientific background seems to be a good candidate. I checked G'MIC's sources and at least there is an example to call the G'MIC-GIMP-plug-in from other Scheme plug-ins. They could work as test-drivers. On the other hand G'MIC with its many filters seems to be a quite good candidate to push our GEGL porting progress forward. From an technical- architectural point of view I rather see its place in the filter- processing-component, i.e. in GEGL (as code donation or through a wrapper interface). From this point of view the aforementioned part of GIMP's product vision suits better to GEGL and GIMP could fully focus on the artistic part. Also the G'MIC plug-in with its extra dialog currently looks like a duplication of the Filters menu and could be more integrated (like the FxFoundry for example). As I'm currently doing the Jenkins work almost alone I'd prefer a solution that's easy to maintain. Jehan's proposal looks good for its pureness. Kind regards, Sven ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
Re: [Gimp-developer] Big problem with Gimp G'MIC with upcoming Gimp 2.10
On Sun, 2014-04-27 at 12:05 +1200, Jehan Pagès wrote: Hi, On Sun, Apr 27, 2014 at 4:55 AM, Jon Nordby jono...@gmail.com wrote: One could set up g'mic or another well-maintained C++ plugin for GIMP to build on Jenkins? That way these errors would be quickly (and hopefully fixed). Actually more simply a very simple do-nothing C++ plugin, yet which includes all possible libgimp headers, could be integrated in the tree as a C++ compilation test to be run during `make check`. That would also catch these kind of bugs. Done, we have such a file already: commit a4773a559982dbf53a6f9b63c113452550e9e1ae Author: Michael Natterer mi...@gimp.org Date: Sun Apr 27 14:30:00 2014 +0200 plug-ins: include libgimp/gimp.h and gimpui.h in openexr-wrapper.cc The file does not need the includes, but including libgimp from a C ++ file makes sure the build fails if something forbidden gets added to any public libgimp header, such as a struct member named private. plug-ins/file-exr/openexr-wrapper.cc | 8 1 file changed, 8 insertions(+) No need for anything more complicated like adding make check targets... --Mitch ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
Re: [Gimp-developer] Big problem with Gimp G'MIC with upcoming Gimp 2.10
Hi,
On Sun, Apr 27, 2014 at 4:55 AM, Jon Nordby jono...@gmail.com wrote:
One could set up g'mic or another well-maintained C++ plugin for GIMP
to build on Jenkins? That way these errors would be quickly (and
hopefully fixed).
Actually more simply a very simple do-nothing C++ plugin, yet which
includes all possible libgimp headers, could be integrated in the tree
as a C++ compilation test to be run during `make check`. That would
also catch these kind of bugs.
Jehan
On 26 April 2014 18:44, Joao S. O. Bueno gwid...@gmail.com wrote:
And of course, becoming incompatible with C++ all of a sudden, if it
builds today, would be a serious bug - so
don't be afraid that would happen for free like that. And please,
complain otherwise.
On 26 April 2014 04:39, Thorsten Stettin thorsten.stet...@gmail.com wrote:
Am 26.04.2014 04:29, schrieb Michael Henning:
This was just fixed a day or two ago on gimp master. If you pull and
rebuild gimp, you should be fine.
https://git.gnome.org/browse/gimp/commit/?id=c808789e1df880046273c9de0a8e61b1b232ebd3
Great work. Thanks
But, thanks for the report!
2014-04-25 19:24 GMT-04:00 Thorsten Stettin thorsten.stet...@gmail.com:
Hi, folks,
I have a big problem. The Gimp G'MIC code is written in C++. The problem
is
the variable name private. It is a C++ keyword.
E.g:
*
struct _GimpColorProfileView**
**{**
** GtkTextView parent_instance;**
**
** GimpColorProfileViewPrivate *private;**
**};**
*
In file /usr/include/gimp-2.0/libgimpwidgets/gimpcolorprofileview.h
Please avoid using C++ keywords in C code. Could you change it?
Thanks in advance
Thorsten
--
Lao-Tse sagt: Nichtstun ist besser, als mit viel Mühe nichts zu schaffen.
Und er sagt auch: Ich habe drei Schätze, die ich hüte und hege. Der eine
ist
die Liebe, der zweite ist die Genügsamkeit, der dritte ist die Demut. Nur
der Liebende ist mutig, nur der Genügsame ist großzügig, nur der Demütige
ist fähig zu herrschen.
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership:
https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives: https://mail.gnome.org/archives/gimp-developer-list
--
Lao-Tse sagt: Nichtstun ist besser, als mit viel Mühe nichts zu schaffen.
Und er sagt auch: Ich habe drei Schätze, die ich hüte und hege. Der eine ist
die Liebe, der zweite ist die Genügsamkeit, der dritte ist die Demut. Nur
der Liebende ist mutig, nur der Genügsame ist großzügig, nur der Demütige
ist fähig zu herrschen.
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives: https://mail.gnome.org/archives/gimp-developer-list
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives: https://mail.gnome.org/archives/gimp-developer-list
--
Jon Nordby - www.jonnor.com
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives: https://mail.gnome.org/archives/gimp-developer-list
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives: https://mail.gnome.org/archives/gimp-developer-list
