Re: [Gimp-developer] Gimp-git pull today fails to build - Mac

2018-02-03 Thread Jehan Pagès 
Hi!

On Fri, Feb 2, 2018 at 5:50 PM, Partha Bagchi  wrote:
> On Fri, Feb 2, 2018 at 5:36 AM, Michael Natterer  wrote:
>
>> Hi Partha,
>>
>> you might need the right CPPFLAGS and LDFLAGS in tools/Makefile.am,
>> it doesn't look like they are there.
>>
>> Can you try that so it builds and then send a patch please?
>>
>> Thanks, Mitch
>> ...
>>
>
> Hi Mitch,
>
> I think the LDFLAGS is fine. However, we need to patch 2 files I believe:
> tools/Makefile.am and app/widgets/Makefile.am

Highly possible. The code was untested on macOS for lack of developer
availability.

> I've created a patch (attached), though I'm not sure if it's in the right
> format? :(

The mailing list doesn't accept attachment. Just make a git-formatted
patch please (git format-patch origin/master).

> Where should I upload it?

https://bugzilla.gnome.org/enter_bug.cgi?product=GIMP

Jehan

> Thanks,
> Partha
> ___
> gimp-developer-list mailing list
> List address:gimp-developer-list@gnome.org
> List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
> List archives:   https://mail.gnome.org/archives/gimp-developer-list



-- 
ZeMarmot open animation film
http://film.zemarmot.net
Liberapay: https://liberapay.com/ZeMarmot/
Patreon: https://patreon.com/zemarmot
Tipeee: https://www.tipeee.com/zemarmot

On Fri, Feb 2, 2018 at 5:50 PM, Partha Bagchi  wrote:
> On Fri, Feb 2, 2018 at 5:36 AM, Michael Natterer  wrote:
>
>> Hi Partha,
>>
>> you might need the right CPPFLAGS and LDFLAGS in tools/Makefile.am,
>> it doesn't look like they are there.
>>
>> Can you try that so it builds and then send a patch please?
>>
>> Thanks, Mitch
>> ...
>>
>
> Hi Mitch,
>
> I think the LDFLAGS is fine. However, we need to patch 2 files I believe:
> tools/Makefile.am and app/widgets/Makefile.am
>
> I've created a patch (attached), though I'm not sure if it's in the right
> format? :(
>
> Where should I upload it?
>
> Thanks,
> Partha
> ___
> gimp-developer-list mailing list
> List address:gimp-developer-list@gnome.org
> List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
> List archives:   https://mail.gnome.org/archives/gimp-developer-list



-- 
ZeMarmot open animation film
http://film.zemarmot.net
Liberapay: https://liberapay.com/ZeMarmot/
Patreon: https://patreon.com/zemarmot
Tipeee: https://www.tipeee.com/zemarmot
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list

Re: [Gimp-developer] Gimp-git pull today fails to build - Mac

2018-02-02 Thread Partha Bagchi 
On Fri, Feb 2, 2018 at 5:36 AM, Michael Natterer  wrote:

> Hi Partha,
>
> you might need the right CPPFLAGS and LDFLAGS in tools/Makefile.am,
> it doesn't look like they are there.
>
> Can you try that so it builds and then send a patch please?
>
> Thanks, Mitch
> ...
>

Hi Mitch,

I think the LDFLAGS is fine. However, we need to patch 2 files I believe:
tools/Makefile.am and app/widgets/Makefile.am

I've created a patch (attached), though I'm not sure if it's in the right
format? :(

Where should I upload it?

Thanks,
Partha
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list

Re: [Gimp-developer] Gimp-git pull today fails to build - Mac

2018-02-02 Thread Michael Natterer 
Hi Partha,

you might need the right CPPFLAGS and LDFLAGS in tools/Makefile.am,
it doesn't look like they are there.

Can you try that so it builds and then send a patch please?

Thanks, Mitch

On Thu, 2018-02-01 at 18:19 -0500, Partha Bagchi wrote:
> Mitch,
> 
> I get the following error while building:
> 
> Making all in tools
> >   CC   ../app/widgets/gimpdebug_2_0-gimpcriticaldialog.o
> > In file included from ../app/widgets/gimpcriticaldialog.c:35:
> > In file included from
> > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platfor
> > m/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Cocoa.fr
> > amework/Headers/Cocoa.h:12:
> > In file included from
> > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platfor
> > m/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Foundati
> > on.framework/Headers/Foundation.h:8:
> > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platfor
> > m/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Foundati
> > on.framework/Headers/NSObjCRuntime.h:503:1:
> > error:
> >   expected identifier or '('
> > @class NSString, Protocol;
> > ^
> > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platfor
> > m/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Foundati
> > on.framework/Headers/NSObjCRuntime.h:505:9:
> > error:
> >   unknown type name 'NSString'; did you mean 'GString'?
> > typedef NSString * NSExceptionName NS_EXTENSIBLE_STRING_ENUM;
> 
> 
> Thanks,
> Partha
> ___
> gimp-developer-list mailing list
> List address:gimp-developer-list@gnome.org
> List membership: https://mail.gnome.org/mailman/listinfo/gimp-develop
> er-list
> List archives:   https://mail.gnome.org/archives/gimp-developer-list
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list

[Gimp-developer] Gimp-git pull today fails to build - Mac

2018-02-01 Thread Partha Bagchi 
Mitch,

I get the following error while building:

Making all in tools
>   CC   ../app/widgets/gimpdebug_2_0-gimpcriticaldialog.o
> In file included from ../app/widgets/gimpcriticaldialog.c:35:
> In file included from
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:12:
> In file included from
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:8:
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:503:1:
> error:
>   expected identifier or '('
> @class NSString, Protocol;
> ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:505:9:
> error:
>   unknown type name 'NSString'; did you mean 'GString'?
> typedef NSString * NSExceptionName NS_EXTENSIBLE_STRING_ENUM;


Thanks,
Partha
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list