Re: [Gimp-developer] GIMP 2.8 on OS X fixes
Hi Sven, Am 27.05.2014 um 05:24 schrieb scl scl.gp...@gmail.com: Hi Simone, an honest thank you for your efforts. In my build I'm also patching gtk-mac-integration so this might be of your interest. The patches are in /build/osx/patches of the build-osx branch. 0002-Improve-internationalization-of-App-menu-and-other-s.patch: The current App menu implementation assumes that the application's name is at the end of the 'Hide' and 'Quit' menu item in all languages. This is grammatically incorrect for some languages, such as German. The patch inserts placeholders for the app name and fixes the translations where necessary. Fix references to the internationalization table (GtkOSXApplication) to ensure these strings are recognized at runtime. Fix broken encoding in the ro, ru, uk languages. Add language pt_BR (Brazilian Portuguese). Thank you. I’ve already included those changes in my forked version. BTW, if you convert the *strings files from UTF-16 to UTF-8 encoding, git will handle these as text and not as binary. And it will be easier to manipulate those files in shell scripts with sed, grep, cut, tr and other commands. Cocoa itself handles UTF-8 and UTF-16 encoded strings files interchangeable. 0003-Keep-separators-between-placeholders.patch: Keeps menu separators between menu placeholders. It fixes the issue that some separators got lost in the menus, for instance the one between File/Send as e-mail and File/Properties etc. yep, already done. Regards Simone ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
Re: [Gimp-developer] GIMP 2.8 on OS X fixes
Am 26.05.2014 um 21:17 schrieb Simone Karin Lehmann sim...@lisanet.de:
The patch I’ve mentioned is a fork of the gtk-mac-integration library which I
heavily modified and patched. I’m currently cleaning up the code so that it
would compile without the need to patch the gtk-mac-integrationn library. And
I’ll try to write some basic documentation, why I did this, and what I’ve
changed, and why I did it.
In a few words:
- no undocumented and unofficial function to make the Apple menu.
- just use the official Cocoa API and a stub MainMenu.nib,generated with Xcode
- the library itself now calls [NSApp finishLaunching] as soon as possible,
so there’S no need for an extra EventHandler to open files. This fixes the
mentioned bug.
- don’ hide the ApplicationDelate protocol and don’t hide the notification
protocol, so the application can fully use these protocols. This made it very
easy to implement working dock menus and file open events
So I’ll try to do my best to upload it in the next few days('til Thursday)….
I’ve just uploaded my patched version of the gtk-mac-integration library and
committed it into my svn repository.
https://sourceforge.net/p/gimponosx/code/HEAD/tree/
The README gives some information about why I did this, as I already mentioned
in my above quoted posting, and gives some basic documentation about how to use
the library.
I’ve patched GIMP’s 2.8.10 sources to use this forked library. The changes are
in app/gui/gui.c and app/gui/gui-unique.c. You can find the patches in my svn
too at
https://sourceforge.net/p/gimponosx/code/HEAD/tree/GimpPorts/ports/graphics/gimp2/files/
Regards
Simone Karin
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives: https://mail.gnome.org/archives/gimp-developer-list
Re: [Gimp-developer] GIMP 2.8 on OS X fixes
Hi Sven, On Sun, May 25, 2014 at 8:22 PM, scl scl.gp...@gmail.com wrote: Hi, I’ve updated the OS X builder. The changes include: - Bugfix 721482: bring back languages other than English and offer them in the Preferences’ language selection listbox, show a translated GIMP app menu in various languages, - Bugfix 683177: bring back GIMP’s online user help in a web browser, - Bugfix 721449 and other fixes to make GIMP 2.8 build on OS X again, - add a configuration to build GIMP master, - a UI theme with better integration into the OS X look and feel, - an improved build how-to, - updated dependencies and - various fixes. Known remaining issues are: - Stock buttons in plug-in dialogs still read English instead of the users' language, - GIMP opens the user manual still in English when GIMP was started the usual way by clicking the program icon. It shows the proper language when started from a terminal window. If somebody has a clue on how to fix this I'd be grateful. In other issues, do you have an idea about this: https://bugzilla.gnome.org/show_bug.cgi?id=719723 Simone Karin Lehmann (added in Cc) was saying she already had a fix for this crash, but she has not uploaded her patch and we are still waiting. Since you apparently take good care of the OSX version, do you have an idea of the fix she meant in her explanation? Or maybe Simone, if you read this, we would really welcome the patch you wrote about. Thanks all! :-) Jehan You find the update in GIMP’s osx-build branch and if we find no deal breaker it can go into the next GIMP 2.8 release. Thanks to all who helped me getting the job done. Mac developers, it would be nice if someone of you could build it on a platform other than OS X 10.9. and report back. The updated how to is /build/osx/README and here: https://git.gnome.org/browse/gimp/plain/build/osx/README?h=osx-build Kind regards, Sven ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
Re: [Gimp-developer] GIMP 2.8 on OS X fixes
Hi Jehan,
sorry for answering so late. I’m really very busy in the last few weeks.
The patch I’ve mentioned is a fork of the gtk-mac-integration library which I
heavily modified and patched. I’m currently cleaning up the code so that it
would compile without the need to patch the gtk-mac-integrationn library. And
I’ll try to write some basic documentation, why I did this, and what I’ve
changed, and why I did it.
In a few words:
- no undocumented and unofficial function to make the Apple menu.
- just use the official Cocoa API and a stub MainMenu.nib,generated with Xcode
- the library itself now calls [NSApp finishLaunching] as soon as possible, so
there’S no need for an extra EventHandler to open files. This fixes the
mentioned bug.
- don’ hide the ApplicationDelate protocol and don’t hide the notification
protocol, so the application can fully use these protocols. This made it very
easy to implement working dock menus and file open events
So I’ll try to do my best to upload it in the next few days('til Thursday)….
Simone
Am 26.05.2014 um 18:40 schrieb Jehan Pagès jehan.marmott...@gmail.com:
Hi Sven,
On Sun, May 25, 2014 at 8:22 PM, scl scl.gp...@gmail.com wrote:
Hi,
I’ve updated the OS X builder. The changes include:
- Bugfix 721482: bring back languages other than English and
offer them in the Preferences’ language selection listbox,
show a translated GIMP app menu in various languages,
- Bugfix 683177: bring back GIMP’s online user help in a web browser,
- Bugfix 721449 and other fixes to make GIMP 2.8 build on OS X again,
- add a configuration to build GIMP master,
- a UI theme with better integration into the OS X look and feel,
- an improved build how-to,
- updated dependencies and
- various fixes.
Known remaining issues are:
- Stock buttons in plug-in dialogs still read English instead
of the users' language,
- GIMP opens the user manual still in English when GIMP was
started the usual way by clicking the program icon. It shows
the proper language when started from a terminal window.
If somebody has a clue on how to fix this I'd be grateful.
In other issues, do you have an idea about this:
https://bugzilla.gnome.org/show_bug.cgi?id=719723
Simone Karin Lehmann (added in Cc) was saying she already had a fix
for this crash, but she has not uploaded her patch and we are still
waiting. Since you apparently take good care of the OSX version, do
you have an idea of the fix she meant in her explanation?
Or maybe Simone, if you read this, we would really welcome the patch
you wrote about.
Thanks all! :-)
Jehan
You find the update in GIMP’s osx-build branch and if we find
no deal breaker it can go into the next GIMP 2.8 release.
Thanks to all who helped me getting the job done.
Mac developers, it would be nice if someone of you could build
it on a platform other than OS X 10.9. and report back. The
updated how to is /build/osx/README and here:
https://git.gnome.org/browse/gimp/plain/build/osx/README?h=osx-build
Kind regards,
Sven
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives: https://mail.gnome.org/archives/gimp-developer-list
—
stay hungry, stay foolish
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives: https://mail.gnome.org/archives/gimp-developer-list
Re: [Gimp-developer] GIMP 2.8 on OS X fixes
On 26.5.2014 at 6:40 PM Jehan Pagès wrote: In other issues, do you have an idea about this: https://bugzilla.gnome.org/show_bug.cgi?id=719723 I tried yesterday with my GIMP 2.8.11 build of the build-osx branch which is based on GIMP 2.8 (commit c4dc168 from 25.05.2014) and uses lcms 1.19. I can confirm that GIMP doesn't crash anymore. It still shows the error message from comment 2 of this bug, but keeps running. For the GIMP users this means that it should work in the next release GIMP 2.8.12. Kind regards, Sven ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
Re: [Gimp-developer] GIMP 2.8 on OS X fixes
Hi Simone, an honest thank you for your efforts. In my build I'm also patching gtk-mac-integration so this might be of your interest. The patches are in /build/osx/patches of the build-osx branch. 0002-Improve-internationalization-of-App-menu-and-other-s.patch: The current App menu implementation assumes that the application's name is at the end of the 'Hide' and 'Quit' menu item in all languages. This is grammatically incorrect for some languages, such as German. The patch inserts placeholders for the app name and fixes the translations where necessary. Fix references to the internationalization table (GtkOSXApplication) to ensure these strings are recognized at runtime. Fix broken encoding in the ro, ru, uk languages. Add language pt_BR (Brazilian Portuguese). 0003-Keep-separators-between-placeholders.patch: Keeps menu separators between menu placeholders. It fixes the issue that some separators got lost in the menus, for instance the one between File/Send as e-mail and File/Properties etc. As you're forking gtk-mac-integration you might want to integrate them, too. Kind regards, Sven ___ gimp-developer-list mailing list List address:gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
