[jira] [Updated] (GIRAPH-124) Combiner should return Iterable instead of M or null.
[ https://issues.apache.org/jira/browse/GIRAPH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claudio Martella updated GIRAPH-124: Attachment: GIRAPH-124.diff Fixes indentation and Exception messages according to Avery's comments. > Combiner should return Iterable instead of M or null. > > > Key: GIRAPH-124 > URL: https://issues.apache.org/jira/browse/GIRAPH-124 > Project: Giraph > Issue Type: Improvement > Components: graph >Affects Versions: 0.1.0 >Reporter: Claudio Martella > Attachments: GIRAPH-124.diff, GIRAPH-124.diff > > > Currently VertexCombiner is expected to return a single message combining the > input messages, or null in case no message should be sent. The new expected > interface should return an Iterable, possibly empty. The number of > elements in the returned Iterable is supposed to be smaller than the number > of input messages, by the initial definition of a Combiner (defined as a > function to reduce I/O by combining multiple messages into 1). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-124) Combiner should return Iterable instead of M or null.
[ https://issues.apache.org/jira/browse/GIRAPH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190381#comment-13190381 ] Claudio Martella commented on GIRAPH-124: - 1) Weird... I'll take a look at it. 2) To be honest I didn't remember what we had agreed exactly, but <= sounds reasonable. > Combiner should return Iterable instead of M or null. > > > Key: GIRAPH-124 > URL: https://issues.apache.org/jira/browse/GIRAPH-124 > Project: Giraph > Issue Type: Improvement > Components: graph >Affects Versions: 0.1.0 >Reporter: Claudio Martella > Attachments: GIRAPH-124.diff > > > Currently VertexCombiner is expected to return a single message combining the > input messages, or null in case no message should be sent. The new expected > interface should return an Iterable, possibly empty. The number of > elements in the returned Iterable is supposed to be smaller than the number > of input messages, by the initial definition of a Combiner (defined as a > function to reduce I/O by combining multiple messages into 1). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-124) Combiner should return Iterable instead of M or null.
[ https://issues.apache.org/jira/browse/GIRAPH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190351#comment-13190351 ] Avery Ching commented on GIRAPH-124: Nice, Claudio. I haven't had a chance to fully test it, but wanted to give you some early feedback. 1) Some changes have messed up indenting a little (here are some examples) -public FloatWritable combine(LongWritable vertexIndex, +public Iterable combine(LongWritable vertexIndex, Iterable msgList) - public abstract M combine(I vertexIndex, + public abstract Iterable combine(I vertexIndex, Iterable messages) throws IOException; -M combinedMsg = combiner.combine(entry.getKey(), +Iterable messages = combiner.combine(entry.getKey(), entry.getValue()); -public IntWritable combine(LongWritable vertexIndex, +public Iterable combine(LongWritable vertexIndex, Iterable messages) 2) Should we make the requirement that the returned result has a size < input size? I think the argument was that some classification of messages might not always reduce the number of messages? Perhaps <=? > Combiner should return Iterable instead of M or null. > > > Key: GIRAPH-124 > URL: https://issues.apache.org/jira/browse/GIRAPH-124 > Project: Giraph > Issue Type: Improvement > Components: graph >Affects Versions: 0.1.0 >Reporter: Claudio Martella > Attachments: GIRAPH-124.diff > > > Currently VertexCombiner is expected to return a single message combining the > input messages, or null in case no message should be sent. The new expected > interface should return an Iterable, possibly empty. The number of > elements in the returned Iterable is supposed to be smaller than the number > of input messages, by the initial definition of a Combiner (defined as a > function to reduce I/O by combining multiple messages into 1). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
