[jira] [Updated] (GIRAPH-184) Upgrade to junit4
[ https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj K updated GIRAPH-184: - Attachment: GIRAPH-184-1.patch Upgrade to junit4 - Key: GIRAPH-184 URL: https://issues.apache.org/jira/browse/GIRAPH-184 Project: Giraph Issue Type: Bug Reporter: Devaraj K Attachments: GIRAPH-184-1.patch, GIRAPH-184.patch Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-180) Publish SNAPSHOTs and released artifacts in the Maven repository
[ https://issues.apache.org/jira/browse/GIRAPH-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255466#comment-13255466 ] Benjamin Heitmann commented on GIRAPH-180: -- The general process for publishing a Maven archetype (via a catalog file) is outlined here: http://www.sonatype.com/books/mvnref-book/reference/archetype-sect-publishing.html Publish SNAPSHOTs and released artifacts in the Maven repository Key: GIRAPH-180 URL: https://issues.apache.org/jira/browse/GIRAPH-180 Project: Giraph Issue Type: Improvement Components: build Affects Versions: 0.1.0 Reporter: Paolo Castagna Priority: Minor Original Estimate: 4h Remaining Estimate: 4h Currently Giraph uses Maven to drive its build. However, no Maven artifacts nor SNAPSHOTs are published in the Apache Maven repository or Maven central. It would be useful to have Apache Giraph artifacts and SNAPSHOTs published and enable people to use Giraph without recompiling themselves. Right now users can checkout Giraph, mvn install it and use this for their dependency: dependency groupIdorg.apache.giraph/groupId artifactIdgiraph/artifactId version0.2-SNAPSHOT/version /dependency So, it's not that bad, but it can be better. :-) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-183) Add Claudio's FOSDEM presentation (slides and video) to the site
[
https://issues.apache.org/jira/browse/GIRAPH-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255845#comment-13255845
]
Eugene Koontz commented on GIRAPH-183:
--
I found that {{mvn clean compile site}} works on trunk (you may also shorten
build time with: {{mvn -DskipTests clean compile site}}).
The key is that the 'compile' phase prevents the default 'compiler:compile'
('compiler' plugin and 'compile' goal) from executing.
{{mvn -PX clean compile site}} also works for {{X}} in {{{hadoop_trunk,
hadoop_facebook*, hadoop_0.23, hadoop_1.0, hadoop_0.20.203,
hadoop_non_secure}}}.
*with {{-Dhadoop.jar.path=$HOME/hadoop-20/build/hadoop-0.20.1-dev-core.jar}}
I think it would be good to get 'mvn site' working on its own, though, which
will work *if* we can get maven to always run the 'compile' phase prior to the
'site' phase, whenever a user runs 'mvn site'.
Add Claudio's FOSDEM presentation (slides and video) to the site
Key: GIRAPH-183
URL: https://issues.apache.org/jira/browse/GIRAPH-183
Project: Giraph
Issue Type: Improvement
Components: site
Reporter: Claudio Martella
Assignee: Claudio Martella
Priority: Trivial
Labels: newbie
Attachments: GIRAPH-183.diff
Presentation:
http://prezi.com/9ake_klzwrga/apache-giraph-distributed-graph-processing-in-the-cloud/
Video: http://www.youtube.com/watch?v=3ZrqPEIPRe4,
http://www.youtube.com/watch?v=BmRaejKGeDM
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-185) Improve concurrency of putMsg / putMsgList
[ https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255933#comment-13255933 ] Bo Wang commented on GIRAPH-185: putVertexIdMessagesList can be improved together Improve concurrency of putMsg / putMsgList -- Key: GIRAPH-185 URL: https://issues.apache.org/jira/browse/GIRAPH-185 Project: Giraph Issue Type: Improvement Components: graph Affects Versions: 0.2.0 Reporter: Bo Wang Fix For: 0.2.0 Original Estimate: 2h Remaining Estimate: 2h Currently in putMsg / putMsgList, a synchronized closure is used to protect the whole transientInMessages when adding the new message. This lock prevents other concurrent calls to putMsg/putMsgList and increases the response time. We should use fine-grain locks to allow high concurrency in message communication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-183) Add Claudio's FOSDEM presentation (slides and video) to the site
[ https://issues.apache.org/jira/browse/GIRAPH-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255950#comment-13255950 ] Claudio Martella commented on GIRAPH-183: - OK, great, I'll test that. Just one minor thing. We shouldn't use -DskipTests because it creates a site stating no test coverage. Add Claudio's FOSDEM presentation (slides and video) to the site Key: GIRAPH-183 URL: https://issues.apache.org/jira/browse/GIRAPH-183 Project: Giraph Issue Type: Improvement Components: site Reporter: Claudio Martella Assignee: Claudio Martella Priority: Trivial Labels: newbie Attachments: GIRAPH-183.diff Presentation: http://prezi.com/9ake_klzwrga/apache-giraph-distributed-graph-processing-in-the-cloud/ Video: http://www.youtube.com/watch?v=3ZrqPEIPRe4, http://www.youtube.com/watch?v=BmRaejKGeDM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-185) Improve concurrency of putMsg / putMsgList
[ https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255952#comment-13255952 ] Claudio Martella commented on GIRAPH-185: - totally agree with that. I actually addressed that in GIRAPH-45, but it hasn't seen the light yet... :) So go on! Improve concurrency of putMsg / putMsgList -- Key: GIRAPH-185 URL: https://issues.apache.org/jira/browse/GIRAPH-185 Project: Giraph Issue Type: Improvement Components: graph Affects Versions: 0.2.0 Reporter: Bo Wang Fix For: 0.2.0 Original Estimate: 2h Remaining Estimate: 2h Currently in putMsg / putMsgList, a synchronized closure is used to protect the whole transientInMessages when adding the new message. This lock prevents other concurrent calls to putMsg/putMsgList and increases the response time. We should use fine-grain locks to allow high concurrency in message communication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (GIRAPH-186) Improve concurrency of putVertexList
Improve concurrency of putVertexList Key: GIRAPH-186 URL: https://issues.apache.org/jira/browse/GIRAPH-186 Project: Giraph Issue Type: Improvement Components: graph Affects Versions: 0.2.0 Reporter: Bo Wang Fix For: 0.2.0 It's pretty similar to GIRAPH-185. The whole inPartitionVertexMap is locked when there is a call to it. We should allow multiple calls adding different partitions to the same worker at the same time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GIRAPH-185) Improve concurrency of putMsg / putMsgList
[ https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching reassigned GIRAPH-185: -- Assignee: Bo Wang Improve concurrency of putMsg / putMsgList -- Key: GIRAPH-185 URL: https://issues.apache.org/jira/browse/GIRAPH-185 Project: Giraph Issue Type: Improvement Components: graph Affects Versions: 0.2.0 Reporter: Bo Wang Assignee: Bo Wang Fix For: 0.2.0 Original Estimate: 2h Remaining Estimate: 2h Currently in putMsg / putMsgList, a synchronized closure is used to protect the whole transientInMessages when adding the new message. This lock prevents other concurrent calls to putMsg/putMsgList and increases the response time. We should use fine-grain locks to allow high concurrency in message communication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GIRAPH-186) Improve concurrency of putVertexList
[ https://issues.apache.org/jira/browse/GIRAPH-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching reassigned GIRAPH-186: -- Assignee: Bo Wang Go for it Bo! Improve concurrency of putVertexList Key: GIRAPH-186 URL: https://issues.apache.org/jira/browse/GIRAPH-186 Project: Giraph Issue Type: Improvement Components: graph Affects Versions: 0.2.0 Reporter: Bo Wang Assignee: Bo Wang Fix For: 0.2.0 Original Estimate: 2h Remaining Estimate: 2h It's pretty similar to GIRAPH-185. The whole inPartitionVertexMap is locked when there is a call to it. We should allow multiple calls adding different partitions to the same worker at the same time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-184) Upgrade to junit4
[
https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256115#comment-13256115
]
Jakob Homan commented on GIRAPH-184:
We can dramatically shrink this patch with static imports to make this type of
change unnecessary:
{code}-assertFalse(ComparisonUtils.equal(one, two));
-assertFalse(ComparisonUtils.equal(two, one));
+Assert.assertFalse(ComparisonUtils.equal(one, two));
+Assert.assertFalse(ComparisonUtils.equal(two, one));{code}
Upgrade to junit4
-
Key: GIRAPH-184
URL: https://issues.apache.org/jira/browse/GIRAPH-184
Project: Giraph
Issue Type: Bug
Reporter: Devaraj K
Attachments: GIRAPH-184-1.patch, GIRAPH-184.patch
Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-175) Replace manual array copy to utility method call
[
https://issues.apache.org/jira/browse/GIRAPH-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256127#comment-13256127
]
Hudson commented on GIRAPH-175:
---
Integrated in Giraph-trunk-Commit #104 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/104/])
GIRAPH-175. Replace manual array copy to utility method call. Contributed
by Devaraj K. (Revision 1327344)
Result = SUCCESS
jghoman :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1327344
Files :
* /incubator/giraph/trunk/CHANGELOG
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java
Replace manual array copy to utility method call
Key: GIRAPH-175
URL: https://issues.apache.org/jira/browse/GIRAPH-175
Project: Giraph
Issue Type: Improvement
Reporter: Jakob Homan
Assignee: Devaraj K
Priority: Trivial
Fix For: 0.2.0
Attachments: GIRAPH-175.patch
{code} String[] zkJavaOptsArray = zkJavaOptsString.split( );
if (zkJavaOptsArray != null) {
for (String javaOpt : zkJavaOptsArray) {
commandList.add(javaOpt);
}
}{code}
Rather than doing the loop ourselves, Collections.addAll would be simpler
(and faster, though that doesn't matter with such a small array). Still
cleaner, though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-176) BasicRPCCommunications has unnecessary cast of Vertex
[
https://issues.apache.org/jira/browse/GIRAPH-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256128#comment-13256128
]
Hudson commented on GIRAPH-176:
---
Integrated in Giraph-trunk-Commit #104 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/104/])
GIRAPH-176. BasicRPCCommunications has unnecessary cast of Vertex.
Contributed by Devaraj K. (Revision 1327348)
Result = SUCCESS
jghoman :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1327348
Files :
* /incubator/giraph/trunk/CHANGELOG
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
BasicRPCCommunications has unnecessary cast of Vertex
-
Key: GIRAPH-176
URL: https://issues.apache.org/jira/browse/GIRAPH-176
Project: Giraph
Issue Type: Improvement
Reporter: Jakob Homan
Assignee: Devaraj K
Priority: Minor
Fix For: 0.2.0
Attachments: GIRAPH-176.patch
BasicRPCCommunications.java, 1224:
{code} BasicVertexI, V, E, M vertex =
vertexResolver.resolve(vertexIndex,
originalVertex,
vertexMutations,
messages);{code}
and then a few lines later at 1248:
{code}partition.putVertex((BasicVertexI, V, E, M) vertex);{code}
vertex gets cast to its own type. This cast can be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
