[jira] [Updated] (GIRAPH-184) Upgrade to junit4
[ https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj K updated GIRAPH-184: - Attachment: GIRAPH-184-1.patch Upgrade to junit4 - Key: GIRAPH-184 URL: https://issues.apache.org/jira/browse/GIRAPH-184 Project: Giraph Issue Type: Bug Reporter: Devaraj K Attachments: GIRAPH-184-1.patch, GIRAPH-184.patch Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-184) Upgrade to junit4
[ https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj K updated GIRAPH-184: - Attachment: GIRAPH-184.patch Upgrade to junit4 - Key: GIRAPH-184 URL: https://issues.apache.org/jira/browse/GIRAPH-184 Project: Giraph Issue Type: Bug Reporter: Devaraj K Assignee: Devaraj K Attachments: GIRAPH-184.patch Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-178) TestPredicate lock has lots of boolean expressions to be simplified
[
https://issues.apache.org/jira/browse/GIRAPH-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devaraj K updated GIRAPH-178:
-
Attachment: GIRAPH-178.patch
TestPredicate lock has lots of boolean expressions to be simplified
---
Key: GIRAPH-178
URL: https://issues.apache.org/jira/browse/GIRAPH-178
Project: Giraph
Issue Type: Improvement
Reporter: Jakob Homan
Priority: Trivial
Labels: newbie
Attachments: GIRAPH-178.patch
TestPredicateLock.java has several instances of
{code}assertTrue(gotPredicate == false);{code} (or {{== true}}) that can be
simplified to more idiomatic Java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-176) BasicRPCCommunications has unnecessary cast of Vertex
[
https://issues.apache.org/jira/browse/GIRAPH-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devaraj K updated GIRAPH-176:
-
Attachment: GIRAPH-176.patch
BasicRPCCommunications has unnecessary cast of Vertex
-
Key: GIRAPH-176
URL: https://issues.apache.org/jira/browse/GIRAPH-176
Project: Giraph
Issue Type: Improvement
Reporter: Jakob Homan
Priority: Minor
Attachments: GIRAPH-176.patch
BasicRPCCommunications.java, 1224:
{code} BasicVertexI, V, E, M vertex =
vertexResolver.resolve(vertexIndex,
originalVertex,
vertexMutations,
messages);{code}
and then a few lines later at 1248:
{code}partition.putVertex((BasicVertexI, V, E, M) vertex);{code}
vertex gets cast to its own type. This cast can be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-175) Replace manual array copy to utility method call
[
https://issues.apache.org/jira/browse/GIRAPH-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devaraj K updated GIRAPH-175:
-
Attachment: GIRAPH-175.patch
Replace manual array copy to utility method call
Key: GIRAPH-175
URL: https://issues.apache.org/jira/browse/GIRAPH-175
Project: Giraph
Issue Type: Improvement
Reporter: Jakob Homan
Priority: Trivial
Attachments: GIRAPH-175.patch
{code} String[] zkJavaOptsArray = zkJavaOptsString.split( );
if (zkJavaOptsArray != null) {
for (String javaOpt : zkJavaOptsArray) {
commandList.add(javaOpt);
}
}{code}
Rather than doing the loop ourselves, Collections.addAll would be simpler
(and faster, though that doesn't matter with such a small array). Still
cleaner, though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-179) BspServiceMaster's PathFilter can be simplified
[
https://issues.apache.org/jira/browse/GIRAPH-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devaraj K updated GIRAPH-179:
-
Attachment: GIRAPH-179.patch
BspServiceMaster's PathFilter can be simplified
---
Key: GIRAPH-179
URL: https://issues.apache.org/jira/browse/GIRAPH-179
Project: Giraph
Issue Type: Improvement
Affects Versions: 0.2.0
Reporter: Jakob Homan
Priority: Trivial
Labels: newbie
Attachments: GIRAPH-179.patch
{code} /**
* Only get the finalized checkpoint files
*/
public static class FinalizedCheckpointPathFilter implements PathFilter {
@Override
public boolean accept(Path path) {
if (path.getName().endsWith(
BspService.CHECKPOINT_FINALIZED_POSTFIX)) {
return true;
}
return false;
}
}{code}
we can simplify this, eliminating the if statement and just returning the
result of {{endsWith()}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
