[EGIT] [admin/devs] master 01/01: probies: Add Sungtaek Hong aka taxi2se

[Jean-Philippe Andre]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/admin/devs.git/commit/?id=6b4b518bfb9845b1911cc1598ee9990874086085

commit 6b4b518bfb9845b1911cc1598ee9990874086085
Author: Jean-Philippe Andre 
Date:   Mon Nov 13 14:46:06 2017 +0900

probies: Add Sungtaek Hong aka taxi2se
---
 probies/taxi2se/id_ed25519.pub | 1 +
 probies/taxi2se/info.txt   | 8 
 2 files changed, 9 insertions(+)

diff --git a/probies/taxi2se/id_ed25519.pub b/probies/taxi2se/id_ed25519.pub
new file mode 100644
index 000..be96883
--- /dev/null
+++ b/probies/taxi2se/id_ed25519.pub
@@ -0,0 +1 @@
+ssh-ed25519 
C3NzaC1lZDI1NTE5IOEFiclXXJ6I1urADMUEyVa29EcJNuwoUwmNf2Sqy4CB
diff --git a/probies/taxi2se/info.txt b/probies/taxi2se/info.txt
new file mode 100644
index 000..5bb77d4
--- /dev/null
+++ b/probies/taxi2se/info.txt
@@ -0,0 +1,8 @@
+Login:taxi2se
+IRC Nick: taxi2se
+Name: Sungtaek Hong
+Location: Seoul, Republic of Korea
+E-Mail:   taxi...@gmail.com, sth253.h...@samsung.com
+Contributing: efl
+Group:Libraries
+Platform: Ubuntu

-- 

[EGIT] [core/efl] master 02/08: eina: Add API doxygen for eina_rbtree_inline_lookup()

[Bryce Harrington]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=d0ded365e9d8b06c89c9f18f6a56709d705e62d6

commit d0ded365e9d8b06c89c9f18f6a56709d705e62d6
Author: Bryce Harrington 
Date:   Mon Nov 13 12:04:39 2017 +0900

eina: Add API doxygen for eina_rbtree_inline_lookup()

Reviewers: cedric, ajwillia.ms

Subscribers: segfaultxavi, jpeg

Differential Revision: https://phab.enlightenment.org/D5460
---
 src/lib/eina/eina_inline_rbtree.x |  2 +-
 src/lib/eina/eina_rbtree.h| 13 -
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/lib/eina/eina_inline_rbtree.x 
b/src/lib/eina/eina_inline_rbtree.x
index 6ebbb98642..b97e5944af 100644
--- a/src/lib/eina/eina_inline_rbtree.x
+++ b/src/lib/eina/eina_inline_rbtree.x
@@ -22,7 +22,7 @@
 /**
  * @addtogroup Eina_Rbtree_Group Red-Black tree
  *
- * @brief These functions provide Red-Black trees management.
+ * @brief These functions provide Red-Black tree management.
  *
  * @{
  */
diff --git a/src/lib/eina/eina_rbtree.h b/src/lib/eina/eina_rbtree.h
index 5f1e085ac0..fad916aa66 100644
--- a/src/lib/eina/eina_rbtree.h
+++ b/src/lib/eina/eina_rbtree.h
@@ -184,10 +184,21 @@ EAPI Eina_Rbtree  
*eina_rbtree_inline_remove(Eina_Rbtree *root, Eina_Rbt
  * @param root The root of a valid red black tree.
  * @param func The callback that will free each node.
  * @param data Private data to help the compare function.
- *
  */
 EAPI void  eina_rbtree_delete(Eina_Rbtree *root, 
Eina_Rbtree_Free_Cb func, void *data) EINA_ARG_NONNULL(2);
 
+/**
+ * @brief Searches tree for a key using a comparison function.
+ *
+ * @param root The root of a valid red black tree.
+ * @param key The key value to search for.
+ * @param length The length of the specified key.
+ * @param cmp Callback routine to compare two nodes.
+ * @param data Private data to help the compare function.
+ *
+ * @return The first matching node found in the red black tree, or
+ * @p root if nothing was found.
+ */
 static inline Eina_Rbtree *eina_rbtree_inline_lookup(const Eina_Rbtree *root, 
const void *key, int length, Eina_Rbtree_Cmp_Key_Cb cmp, const void *data) 
EINA_PURE EINA_ARG_NONNULL(2, 4) EINA_WARN_UNUSED_RESULT;
 
 

-- 

[EGIT] [core/efl] master 07/08: elm: evaluate MULTISELECTABLE state for genlist and gengrid

[Lukasz Stanislawski]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=6505f535f681bbca21c7f60878fe13414641b8f8

commit 6505f535f681bbca21c7f60878fe13414641b8f8
Author: Lukasz Stanislawski 
Date:   Mon Nov 13 12:08:57 2017 +0900

elm: evaluate MULTISELECTABLE state for genlist and gengrid

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5452
---
 src/lib/elementary/elm_gengrid.c | 3 +++
 src/lib/elementary/elm_genlist.c | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/src/lib/elementary/elm_gengrid.c b/src/lib/elementary/elm_gengrid.c
index 69d53dc8cf..025db3035e 100644
--- a/src/lib/elementary/elm_gengrid.c
+++ b/src/lib/elementary/elm_gengrid.c
@@ -5606,6 +5606,9 @@ _elm_gengrid_efl_access_state_set_get(Eo *obj, 
Elm_Gengrid_Data *sd EINA_UNUSED)
 
STATE_TYPE_SET(ret, EFL_ACCESS_STATE_MANAGES_DESCENDANTS);
 
+   if (elm_gengrid_multi_select_get(obj))
+ STATE_TYPE_SET(ret, EFL_ACCESS_STATE_MULTISELECTABLE);
+
return ret;
 }
 
diff --git a/src/lib/elementary/elm_genlist.c b/src/lib/elementary/elm_genlist.c
index 25aa0b1bd5..6fb54d3b2b 100644
--- a/src/lib/elementary/elm_genlist.c
+++ b/src/lib/elementary/elm_genlist.c
@@ -8634,6 +8634,9 @@ _elm_genlist_efl_access_state_set_get(Eo *obj, 
Elm_Genlist_Data *sd EINA_UNUSED)
 
STATE_TYPE_SET(ret, EFL_ACCESS_STATE_MANAGES_DESCENDANTS);
 
+   if (elm_genlist_multi_select_get(obj))
+ STATE_TYPE_SET(ret, EFL_ACCESS_STATE_MULTISELECTABLE);
+
return ret;
 }
 

-- 

[EGIT] [core/efl] master 08/08: eina: Fix spelling/punctuation errors in docs (quaternion..rectangle)

[Bryce Harrington]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=7764abe8f60e88749c2f2f09383dfdccfb8ce4d2

commit 7764abe8f60e88749c2f2f09383dfdccfb8ce4d2
Author: Bryce Harrington 
Date:   Mon Nov 13 12:09:21 2017 +0900

eina: Fix spelling/punctuation errors in docs (quaternion..rectangle)

Reviewers: cedric, ajwillia.ms

Subscribers: segfaultxavi, jpeg

Differential Revision: https://phab.enlightenment.org/D5450
---
 src/lib/eina/eina_quaternion.h |  4 ++--
 src/lib/eina/eina_rbtree.h | 35 ++-
 src/lib/eina/eina_rectangle.h  | 35 ++-
 3 files changed, 34 insertions(+), 40 deletions(-)

diff --git a/src/lib/eina/eina_quaternion.h b/src/lib/eina/eina_quaternion.h
index 9606036c88..156d12b213 100644
--- a/src/lib/eina/eina_quaternion.h
+++ b/src/lib/eina/eina_quaternion.h
@@ -144,10 +144,10 @@ EAPI void eina_quaternion_matrix4_to(Eina_Matrix4 *m,
 /**
  * @brief Compute the inverse of the given quaternion.
  *
- * @param out The quaternion to inverse.
+ * @param out The quaternion to invert.
  * @param q The quaternion matrix.
  *
- * This function inverse the quaternion @p q and stores the result in
+ * This function inverses the quaternion @p q and stores the result in
  * @p out.
  *
  * @since 1.17
diff --git a/src/lib/eina/eina_rbtree.h b/src/lib/eina/eina_rbtree.h
index fad916aa66..ae0f82d2af 100644
--- a/src/lib/eina/eina_rbtree.h
+++ b/src/lib/eina/eina_rbtree.h
@@ -28,12 +28,12 @@
 /**
  * @addtogroup Eina_Rbtree_Group Red-Black tree
  *
- * @brief These functions provide Red-Black trees management.
+ * @brief These functions provide Red-Black tree management.
  *
  * For a brief description look at http://en.wikipedia.org/wiki/Red-black_tree 
.
  * This code is largely inspired from a tutorial written by Julienne Walker at 
:
  * http://eternallyconfuzzled.com/tuts/datastructures/jsw_tut_rbtree.aspx . The
- * main difference is that this set of function never allocate any data, making
+ * main difference is that this set of functions never allocate any data, 
making
  * them particularly useful for memory management.
  */
 
@@ -109,13 +109,13 @@ struct _Eina_Rbtree
 
 /**
  * @def EINA_RBTREE_CONTAINER_GET
- * find back the container of an red black tree.
+ * find back the container of a red black tree.
  */
 #define EINA_RBTREE_CONTAINER_GET(Ptr, Type) ((Type *)((char *)Ptr - 
offsetof(Type, __rbtree)))
 
 /**
  * @typedef Eina_Rbtree_Cmp_Node_Cb
- * Function used compare two nodes and see which direction to navigate.
+ * Function used to compare two nodes and see which direction to navigate.
  */
 typedef Eina_Rbtree_Direction (*Eina_Rbtree_Cmp_Node_Cb)(const Eina_Rbtree 
*left, const Eina_Rbtree *right, void *data);
 
@@ -130,6 +130,7 @@ typedef Eina_Rbtree_Direction 
(*Eina_Rbtree_Cmp_Node_Cb)(const Eina_Rbtree *left
  * Function used compare node with a given key of specified length.
  */
 typedef int (*Eina_Rbtree_Cmp_Key_Cb)(const Eina_Rbtree *node, const void 
*key, int length, void *data);
+
 /**
  * @def EINA_RBTREE_CMP_KEY_CB
  * Cast using #Eina_Rbtree_Cmp_Key_Cb
@@ -138,16 +139,16 @@ typedef int (*Eina_Rbtree_Cmp_Key_Cb)(const Eina_Rbtree 
*node, const void *key,
 
 /**
  * @typedef Eina_Rbtree_Free_Cb
- * Function used free a node.
+ * Function used to free a node.
  */
 typedef void (*Eina_Rbtree_Free_Cb)(Eina_Rbtree *node, void *data);
+
 /**
  * @def EINA_RBTREE_FREE_CB
  * Cast using #Eina_Rbtree_Free_Cb
  */
 #define EINA_RBTREE_FREE_CB(Function) ((Eina_Rbtree_Free_Cb)Function)
 
-
 /**
  * @brief Inserts a new node inside an existing red black tree.
  *
@@ -157,7 +158,7 @@ typedef void (*Eina_Rbtree_Free_Cb)(Eina_Rbtree *node, void 
*data);
  * @param data Private data to help the compare function.
  * @return The new root of the red black tree.
  *
- * This function insert a new node in a valid red black tree. @c NULL is
+ * This function inserts a new node in a valid red black tree. @c NULL is
  * an empty valid red black tree. The resulting new tree is a valid red
  * black tree. This function doesn't allocate any data.
  */
@@ -172,7 +173,7 @@ EAPI Eina_Rbtree  
*eina_rbtree_inline_insert(Eina_Rbtree *root, Eina_Rbt
  * @param data Private data to help the compare function.
  * @return The new root of the red black tree.
  *
- * This function remove a new node in a valid red black tree that should
+ * This function removes a new node in a valid red black tree that should
  * contain the node that you are removing. This function will return @c NULL
  * when the red black tree got empty. This function doesn't free any data.
  */
@@ -203,17 +204,17 @@ static inline Eina_Rbtree 
*eina_rbtree_inline_lookup(const Eina_Rbtree *root, co
 
 
 /**
- * @brief Returns a new prefix iterator associated to a rbtree.
+ * @brief Returns a new prefix iterator associated with a rbtree.
  *
  * @param root The root of rbtree.
  * @return A 

[EGIT] [core/efl] master 05/08: elm: set accurate access role for elm_popup

[Lukasz Stanislawski]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=2ea179d3734d7abfd620a31f1458cc662d69521f

commit 2ea179d3734d7abfd620a31f1458cc662d69521f
Author: Lukasz Stanislawski 
Date:   Mon Nov 13 12:08:24 2017 +0900

elm: set accurate access role for elm_popup

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5454
---
 src/lib/elementary/elc_popup.c| 2 +-
 src/tests/elementary/elm_test_popup.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/elementary/elc_popup.c b/src/lib/elementary/elc_popup.c
index 3a2f2213c1..e21c6311bc 100644
--- a/src/lib/elementary/elc_popup.c
+++ b/src/lib/elementary/elc_popup.c
@@ -1529,7 +1529,7 @@ _elm_popup_efl_object_constructor(Eo *obj, Elm_Popup_Data 
*_pd EINA_UNUSED)
obj = efl_constructor(efl_super(obj, MY_CLASS));
efl_canvas_object_type_set(obj, MY_CLASS_NAME_LEGACY);
evas_object_smart_callbacks_descriptions_set(obj, _smart_callbacks);
-   efl_access_role_set(obj, EFL_ACCESS_ROLE_NOTIFICATION);
+   efl_access_role_set(obj, EFL_ACCESS_ROLE_DIALOG);
 
return obj;
 }
diff --git a/src/tests/elementary/elm_test_popup.c 
b/src/tests/elementary/elm_test_popup.c
index 1cd29163d2..17b8433b1d 100644
--- a/src/tests/elementary/elm_test_popup.c
+++ b/src/tests/elementary/elm_test_popup.c
@@ -18,7 +18,7 @@ START_TEST (elm_atspi_role_get)
popup = elm_popup_add(win);
role = efl_access_role_get(popup);
 
-   ck_assert(role == EFL_ACCESS_ROLE_NOTIFICATION);
+   ck_assert(role == EFL_ACCESS_ROLE_DIALOG);
 
elm_shutdown();
 }

-- 

[EGIT] [core/efl] master 06/08: elm: set accurate access role for elm_icon

[Lukasz Stanislawski]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b9f31b183608ab4b29fc8741e1d7f9283d07a6b6

commit b9f31b183608ab4b29fc8741e1d7f9283d07a6b6
Author: Lukasz Stanislawski 
Date:   Mon Nov 13 12:08:43 2017 +0900

elm: set accurate access role for elm_icon

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5453
---
 src/lib/elementary/elm_icon.c| 2 +-
 src/tests/elementary/elm_test_icon.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/elementary/elm_icon.c b/src/lib/elementary/elm_icon.c
index 5fdc294776..1db6b6f87b 100644
--- a/src/lib/elementary/elm_icon.c
+++ b/src/lib/elementary/elm_icon.c
@@ -615,7 +615,7 @@ _elm_icon_efl_object_constructor(Eo *obj, Elm_Icon_Data *sd)
 
efl_canvas_object_type_set(obj, MY_CLASS_NAME_LEGACY);
evas_object_smart_callbacks_descriptions_set(obj, _smart_callbacks);
-   efl_access_role_set(obj, EFL_ACCESS_ROLE_IMAGE);
+   efl_access_role_set(obj, EFL_ACCESS_ROLE_ICON);
 
return obj;
 }
diff --git a/src/tests/elementary/elm_test_icon.c 
b/src/tests/elementary/elm_test_icon.c
index eec0072707..2b2150665d 100644
--- a/src/tests/elementary/elm_test_icon.c
+++ b/src/tests/elementary/elm_test_icon.c
@@ -18,7 +18,7 @@ START_TEST (elm_atspi_role_get)
icon = elm_icon_add(win);
role = efl_access_role_get(icon);
 
-   ck_assert(role == EFL_ACCESS_ROLE_IMAGE);
+   ck_assert(role == EFL_ACCESS_ROLE_ICON);
 
elm_shutdown();
 }

-- 

[EGIT] [core/efl] master 01/08: eina: Improve eina_alloca API dox

[Bryce Harrington]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=3830cbaa25329b94252eccc7ac00449d023d5a6b

commit 3830cbaa25329b94252eccc7ac00449d023d5a6b
Author: Bryce Harrington 
Date:   Mon Nov 13 12:04:32 2017 +0900

eina: Improve eina_alloca API dox

Reviewers: cedric, ajwillia.ms

Subscribers: segfaultxavi, jpeg

Differential Revision: https://phab.enlightenment.org/D5461
---
 src/lib/eina/eina_alloca.h | 13 +
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/lib/eina/eina_alloca.h b/src/lib/eina/eina_alloca.h
index c0e1b10217..db6a3945a6 100644
--- a/src/lib/eina/eina_alloca.h
+++ b/src/lib/eina/eina_alloca.h
@@ -24,8 +24,8 @@
 
 /**
  * @file eina_alloca.h
- * simplifies usage of alloca() by including the proper file
- * depending on the platform.
+ * Check if GCC's alloca() is available.  If it is available via a different 
spelling,
+ * define alloca to that spelling.
  */
 
 # ifdef EINA_HAVE_ALLOCA_H
@@ -43,8 +43,13 @@
 extern "C"
 #   endif
 /**
- * Allocates memory in the stack frame of the caller, so it's automatically
- * freed when the caller returns. See alloca(3) for details.
+ * @brief Allocates memory in the stack frame of the caller, so that it
+ * is automatically freed when the caller returns.
+ *
+ * @param size Number of bytes of space to allocate.
+ * @return Pointer to beginning of the allocated space.
+ *
+ * @see alloca(3) for more details.
  */
 void *alloca(size_t size);
 #  endif

-- 

[EGIT] [core/efl] master 03/08: eina: Fix spelling/punctuation errors in documentation (thread..xattr)

[Bryce Harrington]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=dab3a6fca3732c14dec86c341948c0a24f0f1c68

commit dab3a6fca3732c14dec86c341948c0a24f0f1c68
Author: Bryce Harrington 
Date:   Mon Nov 13 12:04:59 2017 +0900

eina: Fix spelling/punctuation errors in documentation (thread..xattr)

Summary:
Also makes some of the doxygen comment line spacing/formatting
consistent.

Interesting ref on grammar of 'an uniform' vs. 'a uniform':
  
https://english.stackexchange.com/questions/4700/is-it-a-uniform-or-an-uniform
It is AN honor to work with such A uniform language as English. *sigh*

Reviewers: cedric, ajwillia.ms

Subscribers: segfaultxavi, jpeg

Differential Revision: https://phab.enlightenment.org/D5459
---
 src/lib/eina/Eina.h  |   2 +-
 src/lib/eina/eina_thread.h   |   4 +-
 src/lib/eina/eina_thread_queue.h |   3 +-
 src/lib/eina/eina_tiler.h|  24 +++---
 src/lib/eina/eina_tmpstr.h   |   2 +-
 src/lib/eina/eina_types.h|  39 +++--
 src/lib/eina/eina_unicode.h  |  19 ++---
 src/lib/eina/eina_ustrbuf.h  |   8 +-
 src/lib/eina/eina_value.h| 165 ---
 src/lib/eina/eina_value_util.h   |   4 +
 src/lib/eina/eina_xattr.h|   8 +-
 11 files changed, 217 insertions(+), 61 deletions(-)

diff --git a/src/lib/eina/Eina.h b/src/lib/eina/Eina.h
index 76b6d0adf6..7ed03e6673 100644
--- a/src/lib/eina/Eina.h
+++ b/src/lib/eina/Eina.h
@@ -142,7 +142,7 @@
  * @ingroup Eina
  *
  * @defgroup Eina_Content_Access_Group Content Access
- * @brief Eina provides an uniform way to access elements of a container,
+ * @brief Eina provides a uniform way to access elements of a container,
  *either sequential or indexed.
  * @ingroup Eina_Data_Types_Group
  *
diff --git a/src/lib/eina/eina_thread.h b/src/lib/eina/eina_thread.h
index 7f31d4a3e4..6ac5968749 100644
--- a/src/lib/eina/eina_thread.h
+++ b/src/lib/eina/eina_thread.h
@@ -34,7 +34,7 @@
 /**
  * @defgroup Eina_Thread_Group Thread
  *
- * Abstracts platform threads, providing an uniform API. It's modelled
+ * Abstracts platform threads, providing a uniform API. It's modelled
  * after POSIX THREADS (pthreads), on Linux they are almost 1:1
  * mapping.
  *
@@ -305,7 +305,7 @@ typedef void *(*Eina_Thread_Cancellable_Run_Cb)(void *data);
  *   in the case the thread was already canceled and that was
  *   pending.
  *
- * This helper does exactly the following code. Shall you need a
+ * This helper does exactly the following code. Should you need a
  * slightly different behavior, use the base calls yourself.
  *
  * @code
diff --git a/src/lib/eina/eina_thread_queue.h b/src/lib/eina/eina_thread_queue.h
index cff986da00..4009a0efb5 100644
--- a/src/lib/eina/eina_thread_queue.h
+++ b/src/lib/eina/eina_thread_queue.h
@@ -19,7 +19,7 @@
  * designed with the idea of sending large volumes of messages with no
  * copies from one thread to another (or from/to the mainloop). The idea
  * is that a thread queue is created and then one or more threads send
- * messages in one end and fetch messages on the other end. If you set a
+ * messages in one end and fetch messages off the other end. If you set a
  * parent message queue to 1 or more queues, then this parent will wake up
  * with a sub queue message, indicating which child queue woke up. This can
  * be used to implement the ability to listen to multiple queues at once.
@@ -41,6 +41,7 @@ typedef struct _Eina_Thread_Queue Eina_Thread_Queue;
  * @since 1.11
  */
 typedef struct _Eina_Thread_Queue_Msg Eina_Thread_Queue_Msg;
+
 /**
  * @typedef Eina_Thread_Queue_Msg_Sub
  *
diff --git a/src/lib/eina/eina_tiler.h b/src/lib/eina/eina_tiler.h
index 6c11a7949d..12ca23bc33 100644
--- a/src/lib/eina/eina_tiler.h
+++ b/src/lib/eina/eina_tiler.h
@@ -86,7 +86,7 @@
 /**
  * @defgroup Eina_Tiler_Group Tiler
  *
- * @warning This is a very low level tool, in most situations(for example if
+ * @warning This is a very low level tool, in most situations (for example if
  * you're using evas) you won't need this.
  *
  * @section basic Basic usage
@@ -184,6 +184,7 @@ typedef struct _Eina_Tile_Grid_Slicer Eina_Tile_Grid_Slicer;
  * @see eina_tiler_free()
  */
 EAPI Eina_Tiler*eina_tiler_new(int w, int h);
+
 /**
  * @brief Frees a tiler.
  *
@@ -193,6 +194,7 @@ EAPI Eina_Tiler*eina_tiler_new(int w, int h);
  * elements of @p t.
  */
 EAPI void   eina_tiler_free(Eina_Tiler *t);
+
 /**
  * @brief Sets the size of tiles for a tiler.
  *
@@ -246,7 +248,7 @@ EAPI void   eina_tiler_strict_set(Eina_Tiler 
*t, Eina_Bool strict);
  * @brief Tells if a tiler is empty or not.
  *
  * @param t The tiler to apply the strict rules to.
- * @return EINA_TRUE when empty, EINA_FALSE when not.
+ * @return #EINA_TRUE when empty, #EINA_FALSE when not.
  *
  * @since 1.8
  */
@@ -262,6 +264,7 @@ EAPI Eina_Bool 

[EGIT] [core/efl] master 04/08: eina: Fix spelling/punctuation errors in documentation (safepointer..strbuf)

[Bryce Harrington]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b60c3fb3ba49f854167f86a29c3686b7660e7974

commit b60c3fb3ba49f854167f86a29c3686b7660e7974
Author: Bryce Harrington 
Date:   Mon Nov 13 12:05:09 2017 +0900

eina: Fix spelling/punctuation errors in documentation (safepointer..strbuf)

Reviewers: cedric, ajwillia.ms

Subscribers: segfaultxavi, jpeg

Differential Revision: https://phab.enlightenment.org/D5458
---
 src/lib/eina/eina_safepointer.h   | 16 
 src/lib/eina/eina_safety_checks.h |  6 +++---
 src/lib/eina/eina_simple_xml_parser.h | 18 +-
 src/lib/eina/eina_slstr.h |  2 +-
 src/lib/eina/eina_str.h   |  6 +++---
 src/lib/eina/eina_strbuf.h| 14 +++---
 6 files changed, 31 insertions(+), 31 deletions(-)

diff --git a/src/lib/eina/eina_safepointer.h b/src/lib/eina/eina_safepointer.h
index 16a52ce8ed..72bade407a 100644
--- a/src/lib/eina/eina_safepointer.h
+++ b/src/lib/eina/eina_safepointer.h
@@ -24,16 +24,16 @@
  *
  * @brief These functions provide a wrapper that protect access to pointers
  *
- * Eina_Safepointer is an pointer to index converter that allow an increased
+ * Eina_Safepointer is an pointer to index converter that allows an increased
  * level of safety by forbidding direct access to the pointer. The protection
- * work by using a set of indirection table that are mmapped and mprotected
- * against write access. This the pointer they store and that map to a specific
+ * works by using a set of indirection tables that are mmapped and mprotected
+ * against write access. Thus the pointer they store and that map to a specific
  * index is always correct. Also once a pointer is unregistered the index
  * won't be served back for 2^8 on 32 bits system and 2^28 on 64 bits system
- * for that specific slot. Finally we do guarantee that the lower 2 bits of the
+ * for that specific slot. Finally we guarantee that the lower 2 bits of the
  * returned index are actually never used and completly ignored by our API.
  * So you can safely store whatever information you want in it, we will ignore
- * it and threat as if it wasn't there.
+ * it and treat as if it wasn't there.
  *
  * @note The use of Eina_Safepointer is thread safe.
  */
@@ -63,7 +63,7 @@
 typedef struct _Eina_Safepointer Eina_Safepointer;
 
 /**
- * @brief Register a pointer and get an Eina_Safepointer that map to it.
+ * @brief Register a pointer and get an Eina_Safepointer that maps to it.
  *
  * @param target The pointer to register.
  * @return A valid pointer that is an index to the mapped pointer.
@@ -72,7 +72,7 @@ typedef struct _Eina_Safepointer Eina_Safepointer;
  *
  * @note The lower 2 bits of the returned pointer will always be 0.
  *
- * @note The returned pointer can be used like a pointer, but can not
+ * @note The returned pointer can be used like a pointer, but cannot
  * be touched except with Eina_Safepointer functions.
  *
  * @since 1.18
@@ -80,7 +80,7 @@ typedef struct _Eina_Safepointer Eina_Safepointer;
 EAPI const Eina_Safepointer *eina_safepointer_register(const void *target);
 
 /**
- * @brief Unregister an Eina_Safepointer and the pointer that map to it.
+ * @brief Unregister an Eina_Safepointer and the pointer that maps to it.
  *
  * @param safe The index to unregister from the mapping.
  *
diff --git a/src/lib/eina/eina_safety_checks.h 
b/src/lib/eina/eina_safety_checks.h
index 656054bfa6..52d58f7231 100644
--- a/src/lib/eina/eina_safety_checks.h
+++ b/src/lib/eina/eina_safety_checks.h
@@ -52,7 +52,7 @@
  * #include 
  *
  * #include 
- * // all these files below will NOT emit warning from EINA_ARG_NONNULL(),
+ * // all the files below will NOT emit warning from EINA_ARG_NONNULL(),
  * // but this is required to have the functions defined there to be checked
  * // for NULL pointers
  * #include "my_functions1.h"
@@ -68,10 +68,10 @@
  * that should never happen, it is similar in concept to assert(), but
  * will log and return instead of abort() your program.
  *
- * Since these cases should never happen, one may wantto keep safety
+ * Since these cases should never happen, one may want to keep safety
  * checks enabled during tests but disable then during deploy, not
  * doing any checks at all. This is a common requirement for embedded
- * systems. Whenever to check or not should be set during compile time
+ * systems. When to check or not should be set during compile time
  * by using @c --disable-safety-checks or @c --enable-safety-checks
  * options to @c configure script.
  *
diff --git a/src/lib/eina/eina_simple_xml_parser.h 
b/src/lib/eina/eina_simple_xml_parser.h
index 85169d4b89..a31a14ea96 100644
--- a/src/lib/eina/eina_simple_xml_parser.h
+++ b/src/lib/eina/eina_simple_xml_parser.h
@@ -229,7 +229,7 @@ typedef Eina_Bool (*Eina_Simple_XML_Attribute_Cb)(void 
*data, const char *key, c
  * @param func What to call back 

[EGIT] [apps/terminology] master 01/01: meson.build: remove teamwork check

[Boris Faure]

billiob pushed a commit to branch master.

http://git.enlightenment.org/apps/terminology.git/commit/?id=98f2726b96b8b4feb6d0ba0200272721cdb71435

commit 98f2726b96b8b4feb6d0ba0200272721cdb71435
Author: Boris Faure 
Date:   Sun Nov 12 19:52:17 2017 +0100

meson.build: remove teamwork check
---
 meson.build | 13 -
 1 file changed, 13 deletions(-)

diff --git a/meson.build b/meson.build
index e9d4451..3e05a9b 100644
--- a/meson.build
+++ b/meson.build
@@ -97,10 +97,6 @@ url_head_code = '''#include 
 int main(int argc, char *argv[]) { ecore_con_url_head(NULL); return 0; }
 '''
 
-elementary_teamwork_code = '''#include 
-int main(int argc, char *argv[]) { elm_win_teamwork_uri_show(NULL); return 0; }
-'''
-
 found = 'Not found'
 
 if cc.links(url_head_code, dependencies: terminology_dependencies)
@@ -110,15 +106,6 @@ endif
 
 message('Checking for ecore_con_url_head: ' + found)
 
-if cc.links(elementary_teamwork_code, dependencies: terminology_dependencies)
-  config_data.set('HAVE_ELM_WIN_TEAMWORK', 1)
-  found = 'Found'
-else
-  found = 'Not Found'
-endif
-
-message('Checking for elm_win_teamwork_uri_show: ' + found)
-
 edje_cc = get_option('edje-cc')
 
 if edje_cc == ''

-- 

[EGIT] [core/efl] master 01/01: libinput check - move up to requiring 1.6 as a minimum for libinput

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=f40c91941d5992b4a12802c42e709cbd9861faa1

commit f40c91941d5992b4a12802c42e709cbd9861faa1
Author: Carsten Haitzler (Rasterman) 
Date:   Sun Nov 12 21:44:42 2017 +0900

libinput check - move up to requiring 1.6 as a minimum for libinput
---
 configure.ac| 34 ++
 src/lib/ecore_drm/ecore_drm_evdev.c |  8 
 src/lib/elput/elput_evdev.c |  7 ---
 3 files changed, 2 insertions(+), 47 deletions(-)

diff --git a/configure.ac b/configure.ac
index fe9be24fd9..ba9b78318e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3740,7 +3740,6 @@ EFL_LIB_END([Eldbus])
 
 
  Ecore_Drm
-have_libinput_new="no"
 EFL_LIB_START_OPTIONAL([Ecore_Drm], [test "${want_ecore_drm}" = "yes"])
 
 ### Additional options to configure
@@ -3763,24 +3762,10 @@ EFL_INTERNAL_DEPEND_PKG([ECORE_DRM], [efl])
 EFL_INTERNAL_DEPEND_PKG([ECORE_DRM], [eina])
 
 EFL_DEPEND_PKG([ECORE_DRM], [DRM], [libdrm >= 2.4 xkbcommon >= 0.3.0 gbm])
-EFL_DEPEND_PKG([ECORE_DRM], [LIBINPUT], [libinput >= 0.6.0])
+EFL_DEPEND_PKG([ECORE_DRM], [LIBINPUT], [libinput >= 1.6.0])
 
 EFL_ADD_LIBS([ECORE_DRM], [-lm])
 
-# API change from 0.7 to 0.8. So we define this to support both for now.
-PKG_CHECK_EXISTS([libinput >= 0.8.0],
- [have_libinput_new="yes"],
- [have_libinput_new="no"])
-AC_MSG_CHECKING([Use new libinput API (newer than 0.8.0)])
-AC_MSG_RESULT([${have_libinput_new}])
-if test "x${have_libinput_new}" = "xyes";then
-  AC_DEFINE_UNQUOTED([LIBINPUT_HIGHER_08], [1], [libinput version >= 0.8])
-fi
-if test "x${have_libinput_new}" = "xno";then
-  AC_DEFINE_UNQUOTED([LIBINPUT_HIGHER_08], [0], [libinput version >= 0.8])
-fi
-
-
 EFL_EVAL_PKGS([ECORE_DRM])
 
 ### Checks for header files
@@ -3800,7 +3785,6 @@ EFL_LIB_END_OPTIONAL([Ecore_Drm])
 
 
  Elput
-have_libinput_new="no"
 EFL_LIB_START_OPTIONAL([Elput], [test "${want_elput}" = "yes"])
 
 ### Additional options to configure
@@ -3821,26 +3805,13 @@ EFL_INTERNAL_DEPEND_PKG([ELPUT], [eeze])
 EFL_INTERNAL_DEPEND_PKG([ELPUT], [eo])
 EFL_INTERNAL_DEPEND_PKG([ELPUT], [eina])
 
-EFL_DEPEND_PKG([ELPUT], [LIBINPUT], [libinput >= 0.6.0 xkbcommon >= 0.3.0 
libudev])
+EFL_DEPEND_PKG([ELPUT], [LIBINPUT], [libinput >= 1.6.0 xkbcommon >= 0.3.0 
libudev])
 
 EFL_OPTIONAL_DEPEND_PKG([ELPUT], [${want_systemd}], [SYSTEMD], [libsystemd])
 EFL_ADD_FEATURE([ELPUT], [systemd-logind], [${want_systemd}])
 
 EFL_ADD_LIBS([ELPUT], [-lm])
 
-# API change from 0.7 to 0.8. So we define this to support both for now.
-PKG_CHECK_EXISTS([libinput >= 0.8.0],
- [have_libinput_new="yes"],
- [have_libinput_new="no"])
-AC_MSG_CHECKING([Use new libinput API (newer than 0.8.0)])
-AC_MSG_RESULT([${have_libinput_new}])
-if test "x${have_libinput_new}" = "xyes";then
-  AC_DEFINE_UNQUOTED([LIBINPUT_HIGHER_08], [1], [libinput version >= 0.8])
-fi
-if test "x${have_libinput_new}" = "xno";then
-  AC_DEFINE_UNQUOTED([LIBINPUT_HIGHER_08], [0], [libinput version >= 0.8])
-fi
-
 
 EFL_EVAL_PKGS([ELPUT])
 
@@ -3860,7 +3831,6 @@ EFL_LIB_END_OPTIONAL([Elput])
  End of Elput
 
  Ecore_Drm2
-have_libinput_new="no"
 EFL_LIB_START_OPTIONAL([Ecore_Drm2], [test "${want_drm}" = "yes"])
 
 ### Additional options to configure
diff --git a/src/lib/ecore_drm/ecore_drm_evdev.c 
b/src/lib/ecore_drm/ecore_drm_evdev.c
index 4e5ad4527b..3cc1f74bce 100644
--- a/src/lib/ecore_drm/ecore_drm_evdev.c
+++ b/src/lib/ecore_drm/ecore_drm_evdev.c
@@ -585,7 +585,6 @@ _device_handle_button(struct libinput_device *device, 
struct libinput_event_poin
  ecore_event_add(ECORE_EVENT_MOUSE_BUTTON_UP, ev, NULL, NULL);
 }
 
-#if LIBINPUT_HIGHER_08
 static double
 _event_scroll_get(struct libinput_event_pointer *pe, enum 
libinput_pointer_axis axis)
 {
@@ -599,7 +598,6 @@ _event_scroll_get(struct libinput_event_pointer *pe, enum 
libinput_pointer_axis
  }
return 0.0;
 }
-#endif
 
 static void 
 _device_handle_axis(struct libinput_device *device, struct 
libinput_event_pointer *event)
@@ -631,7 +629,6 @@ _device_handle_axis(struct libinput_device *device, struct 
libinput_event_pointe
ev->root.x = ev->x;
ev->root.y = ev->y;
 
-#if LIBINPUT_HIGHER_08
axis = LIBINPUT_POINTER_AXIS_SCROLL_VERTICAL;
if (libinput_event_pointer_has_axis(event, axis))
  ev->z = _event_scroll_get(event, axis);
@@ -642,11 +639,6 @@ _device_handle_axis(struct libinput_device *device, struct 
libinput_event_pointe
 ev->direction = 1;
 ev->z = _event_scroll_get(event, axis);
  }
-#else
-   axis = libinput_event_pointer_get_axis(event);
-   if (axis == LIBINPUT_POINTER_AXIS_SCROLL_HORIZONTAL) ev->direction = 1;
-   ev->z = libinput_event_pointer_get_axis_value(event);
-#endif
 
ecore_event_add(ECORE_EVENT_MOUSE_WHEEL, ev, NULL, NULL);
 }
diff --git a/src/lib/elput/elput_evdev.c b/src/lib/elput/elput_evdev.c
index 

[EGIT] [core/efl] master 01/02: genlist: implement item focus

[Marcel Hollerbach]

bu5hm4n pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b364293b0c2238c74a8450c4d27787ebe027b483

commit b364293b0c2238c74a8450c4d27787ebe027b483
Author: Marcel Hollerbach 
Date:   Sat Nov 11 18:26:53 2017 +0100

genlist: implement item focus

this implements item-content focus for genlist. feel free to notify me
if there are any crashes or something simular.

ref T6181
---
 src/lib/elementary/elm_genlist.c| 105 
 src/lib/elementary/elm_genlist.eo   |  13 ++--
 src/lib/elementary/elm_genlist_item.eo  |   5 +-
 src/lib/elementary/elm_widget_genlist.h |   3 +
 4 files changed, 108 insertions(+), 18 deletions(-)

diff --git a/src/lib/elementary/elm_genlist.c b/src/lib/elementary/elm_genlist.c
index 6c77edff13..25aa0b1bd5 100644
--- a/src/lib/elementary/elm_genlist.c
+++ b/src/lib/elementary/elm_genlist.c
@@ -8,6 +8,7 @@
 #define EFL_ACCESS_SELECTION_PROTECTED
 #define ELM_INTERFACE_ATSPI_WIDGET_ACTION_PROTECTED
 #define ELM_WIDGET_ITEM_PROTECTED
+#define EFL_UI_FOCUS_COMPOSITION_PROTECTED
 
 #include 
 #include 
@@ -15,6 +16,8 @@
 #include "elm_priv.h"
 #include "elm_widget_genlist.h"
 #include "elm_interface_scrollable.h"
+#include "efl_ui_focus_parent_provider_gen.eo.h"
+#include "efl_ui_focus_composition_adapter.eo.h"
 #include "elm_genlist_item.eo.h"
 #include "elm_genlist_pan.eo.h"
 #include "elm_genlist.eo.h"
@@ -403,6 +406,8 @@ _item_content_realize(Elm_Gen_Item *it,
Eina_List *source;
const char *key;
 
+   ELM_GENLIST_DATA_GET_FROM_ITEM(it, sd);
+
if (!parts)
  {
 EINA_LIST_FREE(*contents, content)
@@ -437,6 +442,7 @@ _item_content_realize(Elm_Gen_Item *it,
 
 if (content != old)
   {
+ eina_hash_add(sd->content_item_map, , it->base->eo_obj);
  // FIXME: Genlist item doesn't update its size when the size of
  // content is changed, so deferred calculation for content should
  // be performed before realization.
@@ -472,6 +478,7 @@ out:
   {
  *contents = eina_list_remove(*contents, old);
  evas_object_del(old);
+ eina_hash_del_by_key(sd->content_item_map, );
   }
  }
 }
@@ -1684,6 +1691,7 @@ _item_cache_find(Elm_Gen_Item *it)
 static Eina_List *
 _content_cache_add(Elm_Gen_Item *it, Eina_List **cache)
 {
+   ELM_GENLIST_DATA_GET_FROM_ITEM(it, pd);
Evas_Object *content = NULL;
EINA_LIST_FREE(it->contents, content)
  {
@@ -1691,6 +1699,7 @@ _content_cache_add(Elm_Gen_Item *it, Eina_List **cache)
   elm_widget_disabled_set(content, EINA_FALSE);
 
 *cache = eina_list_append(*cache, content);
+eina_hash_del_by_key(pd->content_item_map, );
  }
 
return *cache;
@@ -5786,16 +5795,50 @@ elm_genlist_add(Evas_Object *parent)
return elm_legacy_add(MY_CLASS, parent);
 }
 
+static void
+_genlist_element_focused(void *data, const Efl_Event *ev)
+{
+   ELM_GENLIST_DATA_GET(data, pd);
+   Elm_Widget *focused = efl_ui_focus_manager_focus_get(ev->object);
+   Elm_Widget_Item *item;
+
+   if (!focused) return;
+
+   if (efl_isa(focused, EFL_UI_FOCUS_COMPOSITION_ADAPTER_CLASS))
+ item = efl_parent_get(focused);
+   else
+ item = efl_ui_focus_parent_provider_find_logical_parent(pd->provider, 
focused);
+
+   if (efl_isa(item, ELM_GENLIST_ITEM_CLASS))
+ {
+_elm_genlist_item_focused(item);
+_all_items_deselect(pd);
+elm_genlist_item_selected_set(item, EINA_TRUE);
+elm_genlist_item_bring_in(item, ELM_GENLIST_ITEM_SCROLLTO_MIDDLE);
+ }
+}
+
 EOLIAN static Eo *
 _elm_genlist_efl_object_constructor(Eo *obj, Elm_Genlist_Data *sd)
 {
obj = efl_constructor(efl_super(obj, MY_CLASS));
+
+   sd->content_item_map = eina_hash_pointer_new(NULL);
+   sd->provider = efl_add(EFL_UI_FOCUS_PARENT_PROVIDER_GEN_CLASS, obj,
+efl_ui_focus_parent_provider_gen_container_set(efl_added, obj),
+efl_ui_focus_parent_provider_gen_content_item_map_set(efl_added, 
sd->content_item_map));
+
+   efl_ui_focus_composition_custom_manager_set(obj, obj);
+   efl_ui_focus_composition_logical_mode_set(obj, EINA_TRUE);
+
sd->obj = obj;
 
efl_canvas_object_type_set(obj, MY_CLASS_NAME_LEGACY);
evas_object_smart_callbacks_descriptions_set(obj, _smart_callbacks);
efl_access_role_set(obj, EFL_ACCESS_ROLE_LIST);
 
+   efl_event_callback_add(obj, EFL_UI_FOCUS_MANAGER_EVENT_FOCUSED, 
_genlist_element_focused, obj);
+
return obj;
 }
 
@@ -5924,17 +5967,7 @@ _item_select(Elm_Gen_Item *it)
 
if (!(sd->focus_on_selection_enabled || 
_elm_config->item_select_on_focus_disable))
  {
-Evas_Object *swallow_obj;
-Eina_List *l;
-EINA_LIST_FOREACH(it->contents, l, swallow_obj)
-  {
- if (elm_widget_is(swallow_obj) && 
elm_object_focus_get(swallow_obj))
-   {
-  elm_object_focus_set(obj, EINA_FALSE);
- 

[EGIT] [core/efl] master 02/02: elm_widget_item_static_focus: do not accept the adapter as subchild

[Marcel Hollerbach]

bu5hm4n pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=a2a0ccf36b5becdd5f339e03bb19154f8fdc

commit a2a0ccf36b5becdd5f339e03bb19154f8fdc
Author: Marcel Hollerbach 
Date:   Sun Nov 12 12:02:17 2017 +0100

elm_widget_item_static_focus: do not accept the adapter as subchild

The problem here was that the adapter we have created would be
recognized as our subchild, and thus we delete our own subchild, which
is wrong. This fixes that problem and keeps the adapter alive.
---
 src/lib/elementary/elm_widget_item_static_focus.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/lib/elementary/elm_widget_item_static_focus.c 
b/src/lib/elementary/elm_widget_item_static_focus.c
index 905bc264ec..8c56e0e154 100644
--- a/src/lib/elementary/elm_widget_item_static_focus.c
+++ b/src/lib/elementary/elm_widget_item_static_focus.c
@@ -15,11 +15,14 @@ typedef struct {
 EOLIAN static void
 _elm_widget_item_static_focus_efl_ui_focus_object_prepare_logical(Eo *obj, 
Elm_Widget_Item_Static_Focus_Data *pd EINA_UNUSED)
 {
+   Eo *logical_child;
Elm_Widget_Item_Data *wpd = efl_data_scope_get(obj, ELM_WIDGET_ITEM_CLASS);
 
efl_ui_focus_object_prepare_logical(efl_super(obj, 
ELM_WIDGET_ITEM_STATIC_FOCUS_CLASS));
+   logical_child = efl_ui_focus_manager_request_subchild(wpd->widget, obj);
 
-   if (!efl_ui_focus_manager_request_subchild(wpd->widget, obj))
+
+   if (!logical_child)
  {
 if (!pd->adapter)
   {
@@ -28,7 +31,7 @@ 
_elm_widget_item_static_focus_efl_ui_focus_object_prepare_logical(Eo *obj, Elm_W
  efl_ui_focus_manager_calc_register(wpd->widget, pd->adapter, obj, 
NULL);
   }
  }
-   else if (pd->adapter)
+   else if (logical_child && logical_child != pd->adapter)
  {
 efl_ui_focus_manager_calc_unregister(wpd->widget, pd->adapter);
 efl_del(pd->adapter);

--