[EGIT] [bindings/python/python-efl] master 01/01: Do not fail when build with CC="clang"
davemds pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=5a02f132107abc6a7d022eb349f7ff6338b71feb commit 5a02f132107abc6a7d022eb349f7ff6338b71feb Author: Dave Andreoli Date: Thu Jun 25 18:54:03 2020 +0200 Do not fail when build with CC="clang" clang seems much better in building elementary, while gcc need a lot of ram and tend to fail badly So for now on clang is the suggested compiler to use --- setup.py | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/setup.py b/setup.py index 3ed0028..a863a19 100755 --- a/setup.py +++ b/setup.py @@ -211,13 +211,17 @@ ext_modules = [] py_modules = [] packages = ["efl"] common_cflags = [ -"-fno-var-tracking-assignments", # seems to lower the mem used during build -"-Wno-misleading-indentation", # not needed (we don't indent the C code) -"-Wno-deprecated-declarations", # we bind deprecated functions -"-Wno-unused-variable", # eo_instance_from_object() is unused -"-Wno-format-security", # some cc don't like the way cython use EINA_LOG macros -# "-Werror", "-Wfatal-errors" # use this to stop build on first warnings +"-fno-var-tracking-assignments", # seems to lower the mem used during build +"-Wno-misleading-indentation", # not needed (we don't indent the C code) +"-Wno-deprecated-declarations", # we bind deprecated functions +"-Wno-unused-variable", # eo_instance_from_object() is unused +"-Wno-format-security", # some cc don't like the way cython use EINA_LOG macros +# "-Werror", "-Wfatal-errors" # use this to stop build on first warnings ] +# remove clang unknown flags +if os.getenv("CC") == "clang": +common_cflags.remove('-fno-var-tracking-assignments') + if set(("build", "build_ext", "install", "bdist", "sdist")) & set(sys.argv): sys.stdout.write("Python-EFL: %s\n" % RELEASE) --
[EGIT] [website/www-content] master 01/01: news - fix link for e24.1
raster pushed a commit to branch master. http://git.enlightenment.org/website/www-content.git/commit/?id=282cdba299438b746d433b0f240a6a7bb78703b3 commit 282cdba299438b746d433b0f240a6a7bb78703b3 Author: Carsten Haitzler (Rasterman) Date: Thu Jun 25 14:13:04 2020 +0100 news - fix link for e24.1 --- pages/news/e24.1.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pages/news/e24.1.txt b/pages/news/e24.1.txt index 3b16fc3f6..7b55c7a00 100644 --- a/pages/news/e24.1.txt +++ b/pages/news/e24.1.txt @@ -14,8 +14,7 @@ Hilights: == Download == ^ ** LINK ** ^ ** SHA256 ** ^ -| [[ -http://download.enlightenment.org/rel/apps/enlightenment/enlightenment-0.24.0.tar.xz | Enlightenment DR 0.24.1 XZ]] | aee2b6178c918d71ebe661129f4008d773e70e5784651dadbcf56eec0a6d4a09 | +| [[ http://download.enlightenment.org/rel/apps/enlightenment/enlightenment-0.24.1.tar.xz | Enlightenment DR 0.24.1 XZ]] | aee2b6178c918d71ebe661129f4008d773e70e5784651dadbcf56eec0a6d4a09 | == Building and Dependencies == --
[EGIT] [core/efl] master 01/01: gengrid: Fix memory leak
sanghyeonlee pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=6ab86d50523c75e06948f9fe62ec6dfac96750b4 commit 6ab86d50523c75e06948f9fe62ec6dfac96750b4 Author: Subhransu Mohanty Date: Thu Jun 25 17:02:22 2020 +0900 gengrid: Fix memory leak Reviewers: SanghyeonLee Reviewed By: SanghyeonLee Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11930 --- src/lib/elementary/elm_gengrid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/elm_gengrid.c b/src/lib/elementary/elm_gengrid.c index c42f8c354a..13427ec00f 100644 --- a/src/lib/elementary/elm_gengrid.c +++ b/src/lib/elementary/elm_gengrid.c @@ -3993,7 +3993,7 @@ _item_select(Elm_Gen_Item *it) efl_access_state_changed_signal_emit(eo_it, EFL_ACCESS_STATE_TYPE_SELECTED, EINA_TRUE); } - efl_ref(eo_it); + efl_unref(eo_it); sd->walking--; if ((sd->clear_me) && (!sd->walking)) _internal_elm_gengrid_clear(WIDGET(it), EINA_TRUE); --
[EGIT] [core/efl] master 01/03: Fix typos
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=3e7f317313687aef41f0c21b2af990f98afd0682 commit 3e7f317313687aef41f0c21b2af990f98afd0682 Author: Elyes HAOUAS Date: Mon Jun 22 18:24:38 2020 + Fix typos Fix some typos Reviewed-by: Stefan Schmidt Differential Revision: https://phab.enlightenment.org/D12015 --- doc/ephysics_examples.dox | 4 ++-- old/ChangeLog.evas | 2 +- old/NEWS.evas | 2 +- src/bin/elementary/test_factory.c | 2 +- src/lib/edje/edje_embryo.c | 2 +- src/lib/efl/interfaces/efl_gfx_path.c | 2 +- src/lib/elementary/efl_ui_widget.c | 4 ++-- src/lib/elementary/elm_factory.c | 2 +- src/lib/elementary/elm_gengrid.c | 4 ++-- src/lib/elementary/elm_gesture_layer.c | 2 +- src/lib/elementary/elm_photocam.h | 2 +- src/lib/elementary/elm_table_eo.h | 4 ++-- src/lib/elementary/elm_table_eo.legacy.h | 4 ++-- src/lib/elementary/elm_widget_gengrid.h| 2 +- src/lib/elementary/elm_widget_item_eo.h| 2 +- src/lib/elementary/elm_widget_item_eo.legacy.h | 2 +- src/lib/eo/eo_ptr_indirection.c| 4 ++-- src/lib/evas/canvas/evas_clip.c| 2 +- src/modules/evas/vg_loaders/svg/evas_vg_load_svg.c | 2 +- src/tests/efl_mono/EinaTestData.cs | 2 +- 20 files changed, 26 insertions(+), 26 deletions(-) diff --git a/doc/ephysics_examples.dox b/doc/ephysics_examples.dox index 6d99ed78ee..ba509b05f7 100644 --- a/doc/ephysics_examples.dox +++ b/doc/ephysics_examples.dox @@ -297,7 +297,7 @@ * The purpose of this example is to demonstrate the EPhysics_Camera usage. * * The EPhysics_Camera facilitates the usage of scenarios bigger than the - * viewport, thats because the EPhysics handles the position of objects + * viewport, that's because the EPhysics handles the position of objects * which has control. * * @image html camera.png @@ -426,7 +426,7 @@ * usage. * * The EPhysics_Camera facilitates the usage of scenarios bigger than the - * viewport, thats because the EPhysics handles the position of objects + * viewport, that's because the EPhysics handles the position of objects * which has control. * * @image html camera_track.png diff --git a/old/ChangeLog.evas b/old/ChangeLog.evas index 3bc62e3d22..4b81090e92 100644 --- a/old/ChangeLog.evas +++ b/old/ChangeLog.evas @@ -296,7 +296,7 @@ 2011-05-04 Carsten Haitzler (The Rasterman) - * Improved table layout for homogenous mode to handle not column + * Improved table layout for homogeneous mode to handle not column or row multiple sized table better. 2011-05-04 Jiyoun Park diff --git a/old/NEWS.evas b/old/NEWS.evas index 3271bbe905..3cc32ad5fa 100644 --- a/old/NEWS.evas +++ b/old/NEWS.evas @@ -240,7 +240,7 @@ Improvements: * speed and memory usage of textblock * cache handler to also use file size, mode and sub-second timestamp * textblock to re-layout only paragraphs that have changed -* homogenous table layout alignment and sizing +* homogeneous table layout alignment and sizing * textblock linebreaking by using liblinebreak * image loader to drop out instantly if image file is a directory * object allocation to use mempools diff --git a/src/bin/elementary/test_factory.c b/src/bin/elementary/test_factory.c index daae81b63d..71ca204023 100644 --- a/src/bin/elementary/test_factory.c +++ b/src/bin/elementary/test_factory.c @@ -5,7 +5,7 @@ // 16 ^ 4 = 65k #define BLOK 16 -// homogenous layout +// homogeneous layout //#define HOMOG 1 // aligned to top of box #define ZEROALIGN 1 diff --git a/src/lib/edje/edje_embryo.c b/src/lib/edje/edje_embryo.c index 9f50bd2afc..df102b35b8 100644 --- a/src/lib/edje/edje_embryo.c +++ b/src/lib/edje/edje_embryo.c @@ -4701,7 +4701,7 @@ _edje_embryo_test_run(Edje *ed, Edje_Program *pr, const char *sig, const char *s pdata = embryo_program_data_get(ed->collection->script); embryo_program_data_set(ed->collection->script, ed); /* 5 million instructions is an arbitrary number. on my p4-2.6 here */ -/* IF embryo is ONLY running embryo stuff and NO native calls thats */ +/* IF embryo is ONLY running embryo stuff and NO native calls that's */ /* about 0.016 seconds, and longer on slower cpu's. if a simple */ /* embryo script snippet hasn't managed to do its work in 5 MILLION */ /* embryo virtual machine instructions - something is wrong, or */ diff --git a/src/lib/efl/interfaces/efl_gfx_path.c b/src/lib/efl/interfaces/efl_gfx_path.c index 5f2898f06e..df476921f2 100644 --- a/src/lib/efl/interfaces/efl_gfx_path.c +++ b/src/lib/efl/interfaces/efl_gfx_path.c @@ -683,7
[EGIT] [core/efl] master 02/03: Fix typos - (Part #5)
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=dc4fd17a9c131d4154b828810fd16231c5968470 commit dc4fd17a9c131d4154b828810fd16231c5968470 Author: Elyes HAOUAS Date: Sat Jun 20 13:00:10 2020 + Fix typos - (Part #5) Fix some typos Reviewed-by: Stefan Schmidt Differential Revision: https://phab.enlightenment.org/D12019 --- src/lib/edje/edje_match.c | 2 +- src/lib/eet/Eet.h | 2 +- src/lib/efreet/efreet_menu.c | 4 ++-- src/lib/eio/eio_file.c | 4 ++-- src/lib/eio/eio_private.h | 2 +- src/lib/eldbus/Eldbus.h| 2 +- src/lib/eldbus/eldbus_connection.h | 2 +- src/lib/eldbus/eldbus_message.h| 4 ++-- src/lib/eolian/Eolian.h| 6 +++--- 9 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/lib/edje/edje_match.c b/src/lib/edje/edje_match.c index c58c91e53d..021a891856 100644 --- a/src/lib/edje/edje_match.c +++ b/src/lib/edje/edje_match.c @@ -478,7 +478,7 @@ edje_match_programs_exec_check_finals(const unsigned int *signal_finals, unsigned int i; unsigned int j; - /* when not enought memory, they could be NULL */ + /* when not enough memory, they could be NULL */ if (!signal_finals || !source_finals) return EINA_TRUE; for (i = 0; i < signal_states->size; ++i) diff --git a/src/lib/eet/Eet.h b/src/lib/eet/Eet.h index c3016d9b67..ef7832914c 100644 --- a/src/lib/eet/Eet.h +++ b/src/lib/eet/Eet.h @@ -932,7 +932,7 @@ eet_list(Eet_File *ef, * @ingroup Eet_File_Group * @brief Returns an iterator that will describe each entry of an Eet_File. * @param ef A valid eet file handle. - * @return An interator of Eet_Entry. + * @return An iterator of Eet_Entry. * * @since 1.8.0 */ diff --git a/src/lib/efreet/efreet_menu.c b/src/lib/efreet/efreet_menu.c index e45cb678b4..890934fc22 100644 --- a/src/lib/efreet/efreet_menu.c +++ b/src/lib/efreet/efreet_menu.c @@ -65,7 +65,7 @@ struct Efreet_Menu_Internal Eina_List *layout; /**< This menus layout */ Eina_List *default_layout; /**< Default layout */ signed char show_empty;/**< Whether to show empty menus */ -signed char in_line; /**< Whether this meny can be inlined */ +signed char in_line; /**< Whether this menu can be inlined */ signed char inline_limit; /**< Number of elements which triggers inline */ signed char inline_header; /**< Whether we should use the header name when this menu is inlined */ signed char inline_alias; /**< Whether we should use the menu name when inlining */ @@ -143,7 +143,7 @@ struct Efreet_Menu_Layout /* The items below are for Menuname Layout elements */ signed char show_empty;/**< Whether to show empty menus */ -signed char in_line; /**< Whether this meny can be inlined */ +signed char in_line; /**< Whether this menu can be inlined */ signed char inline_limit; /**< Number of elements which triggers inline */ signed char inline_header; /**< Whether we should use the header name when this menu is inlined */ signed char inline_alias; /**< Whether we should use the menu name when inlining */ diff --git a/src/lib/eio/eio_file.c b/src/lib/eio/eio_file.c index d66b035404..ae36d50ac7 100644 --- a/src/lib/eio/eio_file.c +++ b/src/lib/eio/eio_file.c @@ -769,7 +769,7 @@ eio_file_associate_add(Eio_File *ls, { EINA_SAFETY_ON_NULL_RETURN_VAL(ls, EINA_FALSE); EINA_SAFETY_ON_NULL_RETURN_VAL(key, EINA_FALSE); - /* FIXME: Check if we are in the right worker thred */ + /* FIXME: Check if we are in the right worker thread */ if (!ls->worker.associated) ls->worker.associated = eina_hash_string_small_new(eio_associate_free); @@ -785,7 +785,7 @@ eio_file_associate_direct_add(Eio_File *ls, { EINA_SAFETY_ON_NULL_RETURN_VAL(ls, EINA_FALSE); EINA_SAFETY_ON_NULL_RETURN_VAL(key, EINA_FALSE); - /* FIXME: Check if we are in the right worker thred */ + /* FIXME: Check if we are in the right worker thread */ if (!ls->worker.associated) ls->worker.associated = eina_hash_string_small_new(eio_associate_free); diff --git a/src/lib/eio/eio_private.h b/src/lib/eio/eio_private.h index e8f9c856a4..3fd2c09237 100644 --- a/src/lib/eio/eio_private.h +++ b/src/lib/eio/eio_private.h @@ -53,7 +53,7 @@ typedef struct stat _eio_stat_t; # include #endif -/* Keeping 8 Eio_File_Progress alive should be enought */ +/* Keeping 8 Eio_File_Progress alive should be enough */ #define EIO_PROGRESS_LIMIT 8 /* Huge TLB == 16M on most system */ diff --git a/src/lib/eldbus/Eldbus.h b/src/lib/eldbus/Eldbus.h index 808084231e..d307c384ed 100644 --- a/src/lib/eldbus/Eldbus.h +++ b/src/lib/eldbus/Eldbus.h @@ -21,7 +21,7 @@ * * * @ref Eldbus_Core - * @ref Eldbus_Conneciton + * @ref Eldbus_Connection * @ref Eldbus_Object_Mapper * @ref Eldbus_Proxy * @ref Eldbus_Message diff --git
[EGIT] [core/efl] master 03/03: eina_array: micro optimize eina_array_push
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=2dcb18acac4d1384e0651d353c2b1f15a8c5e4d4 commit 2dcb18acac4d1384e0651d353c2b1f15a8c5e4d4 Author: Marcel Hollerbach Date: Wed Jun 10 20:48:37 2020 +0200 eina_array: micro optimize eina_array_push This commit does two things: - Tell the compiler that it is unlikely that we need to grow, and that it is unlikely that data is NULL. Sometimes the if check for data would get dropped out by the compiler when it can be ensured that it is != NULL. However, if we for example efl_add something and eina_push the result, the condition would not be removed, as there is no assertion efl_add would be != NULL. - Do not hide the array assignment in a branch, but make it the default branch, this way instruction cache caches the correct instruction, as branch prediction will now hopefully, due to the hinting, take the correct branch. While benchmarking this here (simply in elementary_perf), this reduced pipeline faults in eina_array_push quite a bit. (Btw. it is hard to track *which* exact calls to eina_array_push do cause that, as mostly this API gets inlined, so it was easier optimizing that, instead of the method arround) Reviewed-by: Stefan Schmidt Differential Revision: https://phab.enlightenment.org/D11997 --- src/lib/eina/eina_inline_array.x | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/lib/eina/eina_inline_array.x b/src/lib/eina/eina_inline_array.x index 8367d61e7b..a78b674edd 100644 --- a/src/lib/eina/eina_inline_array.x +++ b/src/lib/eina/eina_inline_array.x @@ -44,16 +44,13 @@ EAPI Eina_Bool eina_array_grow(Eina_Array *array); static inline Eina_Bool eina_array_push(Eina_Array *array, const void *data) { - if (data) - { -if (EINA_UNLIKELY((array->count + 1) > array->total)) goto do_grow; + if (EINA_UNLIKELY(data == NULL)) return EINA_FALSE; + if (EINA_UNLIKELY((array->count + 1) > array->total)) goto do_grow; do_grow_back: -array->data[array->count++] = (void*) data; + array->data[array->count++] = (void*) data; -return EINA_TRUE; - } - return EINA_FALSE; + return EINA_TRUE; do_grow: if (!eina_array_grow(array)) return EINA_FALSE; goto do_grow_back; --
[EGIT] [apps/terminology] master 01/01: themes: make GLOW_TXT color_class work as expected
billiob pushed a commit to branch master. http://git.enlightenment.org/apps/terminology.git/commit/?id=e4114bc4b7b36ebbe71cb03b5e1122e6420b7284 commit e4114bc4b7b36ebbe71cb03b5e1122e6420b7284 Author: Boris Faure Date: Thu Jun 25 08:10:41 2020 +0200 themes: make GLOW_TXT color_class work as expected --- data/themes/default/colors.edc | 4 ++-- data/themes/default/tab_drag_thumb.edc | 3 +++ data/themes/nord.edc | 6 +++--- data/themes/papercolor.edc | 4 ++-- data/themes/solarized.edc | 4 ++-- data/themes/solarized_light.edc| 4 ++-- 6 files changed, 14 insertions(+), 11 deletions(-) diff --git a/data/themes/default/colors.edc b/data/themes/default/colors.edc index 6eb9dc0..7c41183 100644 --- a/data/themes/default/colors.edc +++ b/data/themes/default/colors.edc @@ -3,8 +3,8 @@ color_class { name: "FG"; color: FG_COLOR ; } color_class { name: "GLOW"; color: 51 153 255 255; } color_class { name: "GLOW_TXT"; color: 255 255 255 255; - color2: 51 153 255 128; - color3: 51 153 255 20; + color2: 51 153 255 255; + color3: 51 153 255 255; } color_class { name: "c0"; color: 170 170 170 255; } // COL_DEF diff --git a/data/themes/default/tab_drag_thumb.edc b/data/themes/default/tab_drag_thumb.edc index 3934bd3..d956704 100644 --- a/data/themes/default/tab_drag_thumb.edc +++ b/data/themes/default/tab_drag_thumb.edc @@ -104,6 +104,9 @@ group { name: "terminology/tab_drag_thumb"; description { state: "default" 0.0; rel1.to: "terminology.content"; rel2.to: "terminology.content"; +color: 255 255 255 255; +color2: 255 255 255 128; +color3: 255 255 255 20; color_class: "GLOW_TXT"; align: 0.5 1.0; text { font: "Sans"; size: 10; diff --git a/data/themes/nord.edc b/data/themes/nord.edc index 44d9504..4d2d7c5 100644 --- a/data/themes/nord.edc +++ b/data/themes/nord.edc @@ -51,9 +51,9 @@ color_classes { color_class { name: "FG" ; color: FG_COLOR; } color_class { name: "GLOW"; color: 51 153 255 255; } color_class { name: "GLOW_TXT"; - color: 255 255 255 255; - color2: 51 153 255 128; - color3: 51 153 255 20; + color: 255 255 255 255; + color2: 51 153 255 255; + color3: 51 153 255 255; } color_class { name: "C0"; color: ANSI0; } // COL_BLACK diff --git a/data/themes/papercolor.edc b/data/themes/papercolor.edc index 21b453d..b113afc 100644 --- a/data/themes/papercolor.edc +++ b/data/themes/papercolor.edc @@ -32,8 +32,8 @@ color_classes { color_class { name: "GLOW"; color: 85 139 46 128; } color_class { name: "GLOW_TXT"; color: 255 255 255 255; - color2: 85 139 46 128; - color3: 85 139 46 20; + color2: 85 139 46 255; + color3: 85 139 46 255; } color_class { name: "C0"; color: ANSI7; } // COL_BLACK diff --git a/data/themes/solarized.edc b/data/themes/solarized.edc index e516d92..4772453 100644 --- a/data/themes/solarized.edc +++ b/data/themes/solarized.edc @@ -28,8 +28,8 @@ color_classes { color_class { name: "GLOW"; color: 51 153 255 255; } color_class { name: "GLOW_TXT"; color: 255 255 255 255; - color2: 51 153 255 128; - color3: 51 153 255 20; + color2: 51 153 255 255; + color3: 51 153 255 255; } color_class { name: "c0"; color: S_base0; } diff --git a/data/themes/solarized_light.edc b/data/themes/solarized_light.edc index 2bc0038..14b6476 100644 --- a/data/themes/solarized_light.edc +++ b/data/themes/solarized_light.edc @@ -28,8 +28,8 @@ color_classes { color_class { name: "GLOW"; color: 51 153 255 255; } color_class { name: "GLOW_TXT"; color: 255 255 255 255; - color2: 51 153 255 128; - color3: 51 153 255 20; + color2: 51 153 255 255; + color3: 51 153 255 255; } color_class { name: "c0"; color: S_base0; } --