Re: [PATCH] git-contacts: do not fail parsing of good diffs

[Lars Gullik Bjønnes]

On 19 February 2014 00:14, Junio C Hamano gits...@pobox.com wrote:
[...]
 The patch was whitespace damaged, by the way.  It was easy to hand
 tweak so there is no need to resend this particular patch, but if
 you are planning to send more patches, please check your MUA and
 tell it not to.

Suits me right for doing cut-n-paste. Emacs/Gnus usually does not do
stupid things
like that.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] git-contacts: do not fail parsing of good diffs

[Lars Gullik Bjønnes]

If a line in a patch starts with ---  it will be deemed
malformed unless it also contains the proper diff header
format. This situation can happen with a valid patch if
it has a line starting with --  and that line is removed.

This patch just removes the check in git-contacts.

Signed-off-by: Lars Gullik Bjønnes lar...@gullik.org
---
 contrib/contacts/git-contacts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/contrib/contacts/git-contacts b/contrib/contacts/git-contacts
index 428cc1a..dbe2abf 100755
--- a/contrib/contacts/git-contacts
+++ b/contrib/contacts/git-contacts
@@ -96,8 +96,6 @@ sub scan_patches {
next unless $id;
if (m{^--- (?:a/(.+)|/dev/null)$}) {
$source = $1;
-   } elsif (/^--- /) {
-   die Cannot parse hunk source: $_\n;
} elsif (/^@@ -(\d+)(?:,(\d+))?/  $source) {
my $len = defined($2) ? $2 : 1;
push @{$sources-{$source}{$id}}, [$1, $len] if $len;
-- 
1.9.0

-- 
Lgb
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/11] Call it Git User Manual and remove reference to very old Git version

[Lars Gullik Bjønnes]

Junio C Hamano gits...@pobox.com writes:

| Thomas Ackermann th.ac...@arcor.de writes:

 Reviewed-by: Jonathan Nieder jrnie...@gmail.com
 Signed-off-by: Thomas Ackermann th.ac...@arcor.de
 ---

| I tend to agree with Jonathan that this should be User's Manual.

Not going into which one might be more correct, but a  quick google
search for User's Manual and User Manual give these results:

User's Manual: 5.7M hits.
User Manual: ~29M hits.

-- 
Lgb

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Wrap commit messages on `git commit -m`

[Lars Gullik Bjønnes]

Ramkumar Ramachandra artag...@gmail.com writes:

| Hi,

| Some of my colleagues are lazy to fire up an editor and write proper
| commit messages- they often write one-liners using `git commit -m`.
| However, that line turns out to be longer than 72 characters, and the
| resulting `git log` output is ugly.  So, I was wondering if it would
| be a good idea to wrap these one-liners to 72 characters
| automatically.

git commit -m 'foo: fix this problem

This problem is fixed by doing foo,
bar and baz.

Signed-off-by: me
'

works.

-- 
Lgb

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html