Issue with git-gui and font used for widgets
Hi,
I have set my UI font in the git-gui preferences, but it only affects
the menus and certain widgets. It does not apply the font to labels
and buttons. This creates a problem for my HiDPI display because the
fonts are quite small. I've never programmed in TCL/TK before so I
don't know exactly what is wrong, but looking at the code I see where
it's supposed to apply the font option to the widgets in a foreach
loop.
foreach class {Button Checkbutton Entry Label
Labelframe Listbox Message
Radiobutton Spinbox Text} {
option add *$class.font font_ui
}
But that doesn't seem to work. As an experiment I added the -font
parameter (according to the docs) to where the branch label is created
and that worked as expected.
${NS}::label .branch.l1 \
-text [mc "Current Branch:"] \
-anchor w \
-justify left \
-font font_ui
I don't know what is the expected behavior in terms of setting fonts,
but I would assume that is not expected? It appears to be using
TkDefaultFont instead. The default font being small is really a tk
problem, where as setting the widget font is a git-gui problem. I
created the following bug report against tk to get some feedback on
the small default font issue as well as documented a workaround to
allow per user default fonts.
https://core.tcl-lang.org/tk/tktview/dccd82bdc70dc25bb6709a6c14880a92104dda43
Any suggestions?
-Eric
Re: [PATCH 1/2] Modified flag field type in rev_list_info struct in bisect.h. There is no need for flag field to be signed, as it is not supposed to be used as decimal.
Yep. Thanks for your remarks. I have made a bit more research about using old rev_list_info struct (with signed int flag) and realized, that it doesn't appear in expressions, where using signed integer will differ from unsigned one. I'll take using 'unsigned' instead of 'unsigned int' in account, so if needed, I can remake the patch in order to get it accepted. On 03/25/2016 09:18 AM, Junio C Hamano wrote: Stefan Beller writes: Maybe my exposure to the code was accidentally in a way such that I ever only saw the version without int. The older part of the code tends to spell flag words with "unsigned" without "int", which is primarily historical fault of mine. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
GSoC proposal
As I was strongly encouraged to submit my GSoC proposal, I'll post it here and CC to my possible mentor. Please, provide with your feedback about my draft. You can also comment it right in the Google doc. Thanks in advance Proposal: https://docs.google.com/document/d/1Hpu9FfD3wb7qgWgTiKtIAie41OXK3ufgnhnNuRaEH4E -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] Modified flag field type in rev_list_info struct in bisect.h. There is no need for flag field to be signed, as it is not supposed to be used as decimal.
On 03/24/2016 10:51 PM, Stefan Beller wrote:
On Thu, Mar 24, 2016 at 12:41 PM, Motroni Igor wrote:
From: Pontifik
Here is a good place to put reasoning for why this is a good idea.
I see you have a long subject, so maybe we can shorten the first line
(down to less than ~ 80 characters) and put the longer explanation
here.
How about:
bisect: use unsigned for flag field
The flags are usually used as a unsigned variable, because it makes
bit operations easier to follow.
Yep, it's definitely a good idea to shorten subject in order to put more
explanations in body of a message.
Signed-off-by: Pontifik
From Documentation/SubmittingPatches:
Also notice that a real name is used in the Signed-off-by: line. Please
don't hide your real name.
Yep, I didn't mean to hide my real name, but coming across lots of new
stuff confused me in distinguishing whether I'm asked to enter real name
or nickname :)
---
bisect.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bisect.h b/bisect.h
index acd12ef..a979a7f 100644
--- a/bisect.h
+++ b/bisect.h
@@ -16,7 +16,7 @@ extern struct commit_list *filter_skipped(struct commit_list
*list,
struct rev_list_info {
struct rev_info *revs;
- int flags;
+ unsigned int flags;
You can also drop the int here and make it just
unsigned.
In fact, I just wanted to keep this code clear to understand (as I see
this). Unsigned short is also unsigned, but a reader should know that
"unsigned" type stands for "unsigned int". Anyway, I'll keep this in
mind in future, thanks a lot.
int show_timestamp;
int hdr_termination;
const char *header_prefix;
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
