Re: [PATCH] Document LF appearing in shallow command during send-pack/receive-pack

2014-08-27 Thread Jonathan Nieder 
Shawn Pearce wrote:

> The implementation sends an LF, but the protocol documentation was
> missing this detail.
>
> Signed-off-by: Shawn Pearce 
> ---
>  Documentation/technical/pack-protocol.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/technical/pack-protocol.txt 
> b/Documentation/technical/pack-protocol.txt
> index 18dea8d..569c48a 100644
> --- a/Documentation/technical/pack-protocol.txt
> +++ b/Documentation/technical/pack-protocol.txt
> @@ -467,7 +467,7 @@ references.
>  
>update-request=  *shallow command-list [pack-file]
>  
> -  shallow   =  PKT-LINE("shallow" SP obj-id)
> +  shallow   =  PKT-LINE("shallow" SP obj-id LF)

In git, the client sends LF and the server is happy with or
without LF.  JGit and libgit2 don't send 'shallow' lines.

Reviewed-by: Jonathan Nieder 

>  
>command-list  =  PKT-LINE(command NUL capability-list LF)
>  *PKT-LINE(command LF)
> -- 
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] Document LF appearing in shallow command during send-pack/receive-pack

2014-08-27 Thread Shawn Pearce 
The implementation sends an LF, but the protocol documentation was
missing this detail.

Signed-off-by: Shawn Pearce 
---
 Documentation/technical/pack-protocol.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/technical/pack-protocol.txt 
b/Documentation/technical/pack-protocol.txt
index 18dea8d..569c48a 100644
--- a/Documentation/technical/pack-protocol.txt
+++ b/Documentation/technical/pack-protocol.txt
@@ -467,7 +467,7 @@ references.
 
   update-request=  *shallow command-list [pack-file]
 
-  shallow   =  PKT-LINE("shallow" SP obj-id)
+  shallow   =  PKT-LINE("shallow" SP obj-id LF)
 
   command-list  =  PKT-LINE(command NUL capability-list LF)
   *PKT-LINE(command LF)
-- 
2.1.0.rc2.206.gedb03e5

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html