Re: [PATCH] allow git-p4 to create shelved changelists

2016-11-29 Thread Junio C Hamano
Luke Diamand  writes:

> On 28 November 2016 at 19:06, Junio C Hamano  wrote:
>> Vinicius Kursancew  writes:
>>
>>> This patch adds a "--shelve" option to the submit subcommand, it will
>>> save the changes to a perforce shelve instead of commiting them.
>
> Looks good to me, thanks!
>
> Works a treat.

Thanks.


Re: [PATCH] allow git-p4 to create shelved changelists

2016-11-29 Thread Luke Diamand
On 28 November 2016 at 19:06, Junio C Hamano  wrote:
> Vinicius Kursancew  writes:
>
>> This patch adds a "--shelve" option to the submit subcommand, it will
>> save the changes to a perforce shelve instead of commiting them.

Looks good to me, thanks!

Works a treat.

Ack.

>>
>> Vinicius Kursancew (1):
>>   git-p4: allow submit to create shelved changelists.
>>
>>  Documentation/git-p4.txt |  5 +
>>  git-p4.py| 36 ++--
>>  t/t9807-git-p4-submit.sh | 31 +++
>>  3 files changed, 58 insertions(+), 14 deletions(-)
>
> Thanks, but I am a wrong person to review this change, so I'll
> summon two people who appear in "git shortlog --since=18.months"
> output to help review it.
>
>


Re: [PATCH] allow git-p4 to create shelved changelists

2016-11-28 Thread Junio C Hamano
Vinicius Kursancew  writes:

> This patch adds a "--shelve" option to the submit subcommand, it will
> save the changes to a perforce shelve instead of commiting them.
>
> Vinicius Kursancew (1):
>   git-p4: allow submit to create shelved changelists.
>
>  Documentation/git-p4.txt |  5 +
>  git-p4.py| 36 ++--
>  t/t9807-git-p4-submit.sh | 31 +++
>  3 files changed, 58 insertions(+), 14 deletions(-)

Thanks, but I am a wrong person to review this change, so I'll
summon two people who appear in "git shortlog --since=18.months"
output to help review it.




[PATCH] allow git-p4 to create shelved changelists

2016-11-28 Thread Vinicius Kursancew
This patch adds a "--shelve" option to the submit subcommand, it will
save the changes to a perforce shelve instead of commiting them.

Vinicius Kursancew (1):
  git-p4: allow submit to create shelved changelists.

 Documentation/git-p4.txt |  5 +
 git-p4.py| 36 ++--
 t/t9807-git-p4-submit.sh | 31 +++
 3 files changed, 58 insertions(+), 14 deletions(-)

-- 
2.6.0-rc1