Re: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings

[Junio C Hamano]

"brian m. carlson"  writes:

> On Sun, Mar 25, 2018 at 12:57:36PM +0200, René Scharfe wrote:
>> Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.
>> 
>> Signed-off-by: Rene Scharfe 
>> ---
>> This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct
>> object to object_id).
>
> This looks good to me.

Thanks.

Re: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings

[brian m. carlson]

On Sun, Mar 25, 2018 at 12:57:36PM +0200, René Scharfe wrote:
> Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.
> 
> Signed-off-by: Rene Scharfe 
> ---
> This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct
> object to object_id).

This looks good to me.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204


signature.asc
Description: PGP signature

[PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings

[René Scharfe]

Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.

Signed-off-by: Rene Scharfe 
---
This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct
object to object_id).

 bisect.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bisect.c b/bisect.c
index f6d05bd66f..319d60edad 100644
--- a/bisect.c
+++ b/bisect.c
@@ -144,10 +144,10 @@ static void show_list(const char *debug, int counted, int 
nr,
fprintf(stderr, "%3d", weight(p));
else
fprintf(stderr, "---");
-   fprintf(stderr, " %.*s", 8, 
sha1_to_hex(commit->object.oid.hash));
+   fprintf(stderr, " %.*s", 8, oid_to_hex(>object.oid));
for (pp = commit->parents; pp; pp = pp->next)
fprintf(stderr, " %.*s", 8,
-   sha1_to_hex(pp->item->object.oid.hash));
+   oid_to_hex(>item->object.oid));
 
subject_len = find_commit_subject(buf, _start);
if (subject_len)
-- 
2.16.3