Re: [PATCH] git-completion.tcsh: fix redirect with noclobber

2015-06-09 Thread Junio C Hamano
Ariel Faigon github.2...@yendor.com writes:

 tcsh users who happen to have 'set noclobber' elsewhere in their
 ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and
 the tcsh completion file doesn't get generated/updated.

 Adding a `!` in the redirect works correctly for both clobber (default)
 and 'set noclobber' users.

 Helped-by: Junio C Hamano gits...@pobox.com
 Reviewed-by: Christian Couder christian.cou...@gmail.com
 Signed-off-by: Ariel Faigon github.2...@yendor.com
 ---

Thanks for enduring three iterations for a single-liner.  This
versio will show nicely in git log -p output ;-)

In case anybody is wondering, that Helped-by: notifications@github
was merely because I said this change makes sense, care to send it
over to us at git@vger? from github UI on Ariel's commit.  I do not
deserve helped-by for merely encouraging participation.

Will queue.  Thanks again.


  contrib/completion/git-completion.tcsh | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/contrib/completion/git-completion.tcsh 
 b/contrib/completion/git-completion.tcsh
 index 6104a42..4a790d8 100644
 --- a/contrib/completion/git-completion.tcsh
 +++ b/contrib/completion/git-completion.tcsh
 @@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then
   exit
  endif
  
 -cat  EOF  ${__git_tcsh_completion_script}
 +cat  EOF ! ${__git_tcsh_completion_script}
  #!bash
  #
  # This script is GENERATED and will be overwritten automatically.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] git-completion.tcsh: fix redirect with noclobber

2015-06-09 Thread Ariel Faigon
tcsh users who happen to have 'set noclobber' elsewhere in their
~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and
the tcsh completion file doesn't get generated/updated.

Adding a `!` in the redirect works correctly for both clobber (default)
and 'set noclobber' users.

Helped-by: Junio C Hamano gits...@pobox.com
Reviewed-by: Christian Couder christian.cou...@gmail.com
Signed-off-by: Ariel Faigon github.2...@yendor.com
---

 contrib/completion/git-completion.tcsh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/completion/git-completion.tcsh 
b/contrib/completion/git-completion.tcsh
index 6104a42..4a790d8 100644
--- a/contrib/completion/git-completion.tcsh
+++ b/contrib/completion/git-completion.tcsh
@@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then
exit
 endif
 
-cat  EOF  ${__git_tcsh_completion_script}
+cat  EOF ! ${__git_tcsh_completion_script}
 #!bash
 #
 # This script is GENERATED and will be overwritten automatically.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html