Re: [PATCH] git-send-email: add rfc2047 quoting for =?

[Jeff King]

On Wed, Oct 24, 2012 at 11:28:29PM +0200, Krzysztof Mazur wrote:

 For raw subjects rfc2047 quoting is needed not only for non-ASCII characters,
 but also for any possible rfc2047 in it.
 [...]
 - return ($s =~ /[^[:ascii:]]/);
 + return ($s =~ /[^[:ascii:]]/) || ($s =~ /=\?/);

Very nice and obvious bug-fix made easy by the previous refactoring. :)

 ---
 Oops, this ugly Subject was generated by git format-patch (both 1.8.0
 and km/send-email-compose-encoding).

Yeah, format-patch has the same behavior (to encode when we see =?).
So we know it is working. It is perhaps overkill in this case, since
there is not technically a valid encoded-word, and a smart parser would
be able to see that it should leave it alone. But it is probably better
to be slightly conservative in what we generate (and the =? token is
unlikely to come up in day-to-day usage).

-Peff
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] git-send-email: add rfc2047 quoting for =?

[Krzysztof Mazur]

For raw subjects rfc2047 quoting is needed not only for non-ASCII characters,
but also for any possible rfc2047 in it.

Signed-off-by: Krzysztof Mazur krzys...@podlesie.net
---
Oops, this ugly Subject was generated by git format-patch (both 1.8.0
and km/send-email-compose-encoding).

 git-send-email.perl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index eb1b876..cfd20fa 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -908,7 +908,7 @@ sub is_rfc2047_quoted {
 sub subject_needs_rfc2047_quoting {
my $s = shift;
 
-   return ($s =~ /[^[:ascii:]]/);
+   return ($s =~ /[^[:ascii:]]/) || ($s =~ /=\?/);
 }
 
 sub quote_subject {
-- 
1.8.0.rc0.30.g72615bf

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html