Re: [PATCH 0/2] Object store refactoring: make bitmap_git not global
On 06/07, Jonathan Tan wrote: > This is a continuation of the object store refactoring effort. > > We cannot truly free an object store without ensuring that any generated > bitmaps are first freed, so here are patches to drastically reduce the > lifetime of any bitmaps generated. As a bonus, the API is also improved, > and global state reduced. I've reviewed this series and haven't found any issues. Reviewed-by: Brandon Williams -- Brandon Williams
Re: [PATCH 0/2] Object store refactoring: make bitmap_git not global
On Thu, Jun 7, 2018 at 12:04 PM Jonathan Tan wrote: > > This is a continuation of the object store refactoring effort. > > We cannot truly free an object store without ensuring that any generated > bitmaps are first freed, so here are patches to drastically reduce the > lifetime of any bitmaps generated. As a bonus, the API is also improved, > and global state reduced. > Thanks for writing this series, I have no comments on it. Thanks, Stefan
[PATCH 0/2] Object store refactoring: make bitmap_git not global
This is a continuation of the object store refactoring effort. We cannot truly free an object store without ensuring that any generated bitmaps are first freed, so here are patches to drastically reduce the lifetime of any bitmaps generated. As a bonus, the API is also improved, and global state reduced. Jonathan Tan (2): pack-bitmap: remove bitmap_git global variable pack-bitmap: add free function builtin/pack-objects.c | 7 +- builtin/rev-list.c | 13 +- pack-bitmap-write.c| 10 +- pack-bitmap.c | 344 - pack-bitmap.h | 20 ++- 5 files changed, 234 insertions(+), 160 deletions(-) -- 2.17.0.768.g1526ddbba1.dirty
