Re: [PATCH 0/2] git-p4: support python3 in the tests
On 25 April 2016 at 23:07, Junio C Hamano wrote: > Luke Diamand writes: > >> This patchset updates the git-p4 tests so that they work with >> either Python2 or Python3. >> >> Note that this does *not* fix git-p4 to work with Python3 - that's >> a much bigger challenge. > > We use Python outside p4 tests (e.g. remote-svn test), and the way > they invoke the interpreter is to say "$PYTHON_PATH" and avoid > saying "python" which picks whatever random version of Python > interpreter happens to be the first on $PATH. Shouldn't the tests > touched by this series be doing the same? Yes, they should. I'll update them accordingly. But the real reason for doing this is that at some point, git-p4 has to start working with python3, since python2 is going away (albeit not until 2020). Luke -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] git-p4: support python3 in the tests
Luke Diamand writes: > This patchset updates the git-p4 tests so that they work with > either Python2 or Python3. > > Note that this does *not* fix git-p4 to work with Python3 - that's > a much bigger challenge. We use Python outside p4 tests (e.g. remote-svn test), and the way they invoke the interpreter is to say "$PYTHON_PATH" and avoid saying "python" which picks whatever random version of Python interpreter happens to be the first on $PATH. Shouldn't the tests touched by this series be doing the same? > > Luke Diamand (2): > git-p4 tests: cd to testdir before running python > git-p4 tests: work with python3 as well as python2 > > t/lib-git-p4.sh| 7 --- > t/t9802-git-p4-filetype.sh | 6 +++--- > 2 files changed, 7 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] git-p4: support python3 in the tests
This patchset updates the git-p4 tests so that they work with either Python2 or Python3. Note that this does *not* fix git-p4 to work with Python3 - that's a much bigger challenge. Luke Diamand (2): git-p4 tests: cd to testdir before running python git-p4 tests: work with python3 as well as python2 t/lib-git-p4.sh| 7 --- t/t9802-git-p4-filetype.sh | 6 +++--- 2 files changed, 7 insertions(+), 6 deletions(-) -- 2.8.1.218.gd2cea43.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
