Re: [PATCH 0/2] gitk: Better highlighting of search results
On Sat, Sep 22, 2012 at 09:40:23AM +0200, Stefan Haller wrote: Here's something that has been bugging me for a long time: when using the incremental search feature, it's hard to tell what happens when clicking the Search button (or type Ctrl-S) repeatedly. It does have the concept of a current search hit, and Ctrl-S advances to the next one; however, you can't see it because all search hits are highlighted in the same way (yellow). So when there are multiple hits visible on the current page, it will at some point scroll down to reveal more hits, but it's impossible to predict when this will happen. To improve this, we highlight the current search in orange and the other ones in yellow (like Chrome does it when you search on a Web page). Nice, thanks - applied. Paul. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] gitk: Better highlighting of search results
Here's something that has been bugging me for a long time: when using the incremental search feature, it's hard to tell what happens when clicking the Search button (or type Ctrl-S) repeatedly. It does have the concept of a current search hit, and Ctrl-S advances to the next one; however, you can't see it because all search hits are highlighted in the same way (yellow). So when there are multiple hits visible on the current page, it will at some point scroll down to reveal more hits, but it's impossible to predict when this will happen. To improve this, we highlight the current search in orange and the other ones in yellow (like Chrome does it when you search on a Web page). Needs to go on top of the recent Synchronize highlighting in file view when scrolling diff patch, v3. [PATCH 1/2] gitk: Highlight current search hit in orange [PATCH 2/2] gitk: Highlight first search result immediately on incremental search -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
