Re: [PATCH 0/2] minor GETTEXT_POISON fixes

[Jeff King]

On Tue, Feb 06, 2018 at 10:06:53AM +0100, Lars Schneider wrote:

> 
> > On 06 Feb 2018, at 09:42, Jeff King  wrote:
> > 
> > I set NO_GETTEXT=1 in my config.mak, and happened to notice that running
> > the tests with GETTEXT_POISON fails. I think this has been broken for
> > years, but I don't generally play with GETTEXT_POISON. ;)
> 
> On Travis we run GETTEXT_POISON with gettext installed.
> What do you think about an additional job with GETTEXT_POISON and 
> NO_GETTEXT=1?

I think it's probably a waste of CPU. ;)

It would be running the whole test suite to fix this one particular bug,
which I don't think is pretty likely to regress (at least not more than
any other bug). Whereas running with GETTEXT_POISON is meant to shake
out strings that maybe shouldn't be translated, which is a very likely
bug to get introduced.

-Peff

Re: [PATCH 0/2] minor GETTEXT_POISON fixes

[Lars Schneider]

> On 06 Feb 2018, at 09:42, Jeff King  wrote:
> 
> I set NO_GETTEXT=1 in my config.mak, and happened to notice that running
> the tests with GETTEXT_POISON fails. I think this has been broken for
> years, but I don't generally play with GETTEXT_POISON. ;)

On Travis we run GETTEXT_POISON with gettext installed.
What do you think about an additional job with GETTEXT_POISON and NO_GETTEXT=1?

- Lars

[PATCH 0/2] minor GETTEXT_POISON fixes

[Jeff King]

I set NO_GETTEXT=1 in my config.mak, and happened to notice that running
the tests with GETTEXT_POISON fails. I think this has been broken for
years, but I don't generally play with GETTEXT_POISON. ;)

  [1/2]: t0205: drop redundant test
  [2/2]: git-sh-i18n: check GETTEXT_POISON before USE_GETTEXT_SCHEME

 git-sh-i18n.sh| 8 
 t/t0205-gettext-poison.sh | 4 
 2 files changed, 4 insertions(+), 8 deletions(-)

-Peff