Re: [PATCH 0/8] X509 (gpgsm) commit signing support
Am Fri, 6 Jul 2018 01:18:35 + schrieb "brian m. carlson" : > On Tue, Jul 03, 2018 at 02:38:12PM +0200, Henning Schild wrote: > > This series adds support for signing commits with gpgsm. > > > > The first two patches are cleanups of gpg-interface, while the next > > four prepare for the introduction of the actual feature in patch 7. > > Finally patch 8 extends the testsuite to cover the new feature. > > > > This series can be seen as a follow up of a series that appeared > > under the name "gpg-interface: Multiple signing tools" in april > > 2018 [1]. After that series was not merged i decided to get my > > patches ready. The original series aimed at being generic for any > > sort of signing tool, while this series just introduced the X509 > > variant of gpg. (gpgsm) I collected authors and reviewers of that > > first series and already put them on cc. > > Overall, I think this is heading in a good direction. I left a few > comments, but it seemed pretty sane. Thanks, i hope others think so too and that will eventually get merged. Henning
Re: [PATCH 0/8] X509 (gpgsm) commit signing support
On Tue, Jul 03, 2018 at 02:38:12PM +0200, Henning Schild wrote: > This series adds support for signing commits with gpgsm. > > The first two patches are cleanups of gpg-interface, while the next > four prepare for the introduction of the actual feature in patch 7. > Finally patch 8 extends the testsuite to cover the new feature. > > This series can be seen as a follow up of a series that appeared under > the name "gpg-interface: Multiple signing tools" in april 2018 [1]. After > that series was not merged i decided to get my patches ready. The > original series aimed at being generic for any sort of signing tool, while > this series just introduced the X509 variant of gpg. (gpgsm) > I collected authors and reviewers of that first series and already put them > on cc. Overall, I think this is heading in a good direction. I left a few comments, but it seemed pretty sane. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204 signature.asc Description: PGP signature
[PATCH 0/8] X509 (gpgsm) commit signing support
This series adds support for signing commits with gpgsm. The first two patches are cleanups of gpg-interface, while the next four prepare for the introduction of the actual feature in patch 7. Finally patch 8 extends the testsuite to cover the new feature. This series can be seen as a follow up of a series that appeared under the name "gpg-interface: Multiple signing tools" in april 2018 [1]. After that series was not merged i decided to get my patches ready. The original series aimed at being generic for any sort of signing tool, while this series just introduced the X509 variant of gpg. (gpgsm) I collected authors and reviewers of that first series and already put them on cc. [1] https://public-inbox.org/git/20180409204129.43537-1-mastahy...@gmail.com/ Henning Schild (8): builtin/receive-pack: use check_signature from gpg-interface gpg-interface: make parse_gpg_output static and remove from interface header gpg-interface: add new config to select how to sign a commit gpg-interface: introduce an abstraction for multiple gpg formats t/t7510: check the validation of the new config gpg.format gpg-interface: do not hardcode the key string len anymore gpg-interface: introduce new signature format "X509" using gpgsm gpg-interface t: extend the existing GPG tests with GPGSM Documentation/config.txt | 7 builtin/receive-pack.c | 17 + gpg-interface.c| 94 ++ gpg-interface.h| 2 - t/lib-gpg.sh | 9 - t/lib-gpg/gpgsm-gen-key.in | 6 +++ t/t4202-log.sh | 66 t/t5534-push-signed.sh | 52 + t/t7003-filter-branch.sh | 15 t/t7030-verify-tag.sh | 47 ++- t/t7510-signed-commit.sh | 10 + t/t7600-merge.sh | 31 +++ 12 files changed, 321 insertions(+), 35 deletions(-) create mode 100644 t/lib-gpg/gpgsm-gen-key.in -- 2.16.4
