Re: [PATCH 0/9] get_short_oid UI improvements

[Derrick Stolee]

On 4/30/2018 6:07 PM, Ævar Arnfjörð Bjarmason wrote:

I started out just wanting to do 04/09 so I'd get prettier output, but
then noticed that ^{tag}, ^{commit}< ^{blob} and ^{tree} didn't behave
as expected with the disambiguation output, and that core.disambiguate
had never been documented.

Ævar Arnfjörð Bjarmason (9):
   sha1-name.c: remove stray newline
   sha1-array.h: align function arguments
   sha1-name.c: move around the collect_ambiguous() function
   get_short_oid: sort ambiguous objects by type, then SHA-1
   get_short_oid: learn to disambiguate by ^{tag}
   get_short_oid: learn to disambiguate by ^{blob}
   get_short_oid / peel_onion: ^{tree} should mean tree, not treeish
   get_short_oid / peel_onion: ^{tree} should mean commit, not commitish
   config doc: document core.disambiguate

  Documentation/config.txt| 14 ++
  cache.h |  5 ++-
  sha1-array.c| 15 +++
  sha1-array.h|  7 ++-
  sha1-name.c | 69 -
  t/t1512-rev-parse-disambiguation.sh | 32 ++---
  6 files changed, 120 insertions(+), 22 deletions(-)



This is a good series. Please take a look at my suggestion in Patch 4/9, 
but feel free to keep this series as written.


Reviewed-by: Derrick Stolee 

Re: [PATCH 0/9] get_short_oid UI improvements

[brian m. carlson]

On Mon, Apr 30, 2018 at 10:07:25PM +, Ævar Arnfjörð Bjarmason wrote:
> I started out just wanting to do 04/09 so I'd get prettier output, but
> then noticed that ^{tag}, ^{commit}< ^{blob} and ^{tree} didn't behave
> as expected with the disambiguation output, and that core.disambiguate
> had never been documented.
> 
> Ævar Arnfjörð Bjarmason (9):
>   sha1-name.c: remove stray newline
>   sha1-array.h: align function arguments
>   sha1-name.c: move around the collect_ambiguous() function
>   get_short_oid: sort ambiguous objects by type, then SHA-1
>   get_short_oid: learn to disambiguate by ^{tag}
>   get_short_oid: learn to disambiguate by ^{blob}
>   get_short_oid / peel_onion: ^{tree} should mean tree, not treeish
>   get_short_oid / peel_onion: ^{tree} should mean commit, not commitish
>   config doc: document core.disambiguate

As mentioned, I'm a bit unsure that patches 7 and 8 are entirely
correct.  I've mostly convinced myself that they are after looking at
peel_onion, but I'm still harboring lingering doubts for some reason.

The rest of the series looked fine to me.  Thanks for cleaning up my
stray newline.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204


signature.asc
Description: PGP signature

Re: [PATCH 0/9] get_short_oid UI improvements

[Stefan Beller]

On Mon, Apr 30, 2018 at 3:07 PM, Ævar Arnfjörð Bjarmason
 wrote:
> I started out just wanting to do 04/09 so I'd get prettier output, but
> then noticed that ^{tag}, ^{commit}< ^{blob} and ^{tree} didn't behave
> as expected with the disambiguation output, and that core.disambiguate
> had never been documented.
>

This whole series, including the comment in which you wonder
if the code is overly smart, is

Reviewed-by: Stefan Beller 

[PATCH 0/9] get_short_oid UI improvements

[Ævar Arnfjörð Bjarmason]

I started out just wanting to do 04/09 so I'd get prettier output, but
then noticed that ^{tag}, ^{commit}< ^{blob} and ^{tree} didn't behave
as expected with the disambiguation output, and that core.disambiguate
had never been documented.

Ævar Arnfjörð Bjarmason (9):
  sha1-name.c: remove stray newline
  sha1-array.h: align function arguments
  sha1-name.c: move around the collect_ambiguous() function
  get_short_oid: sort ambiguous objects by type, then SHA-1
  get_short_oid: learn to disambiguate by ^{tag}
  get_short_oid: learn to disambiguate by ^{blob}
  get_short_oid / peel_onion: ^{tree} should mean tree, not treeish
  get_short_oid / peel_onion: ^{tree} should mean commit, not commitish
  config doc: document core.disambiguate

 Documentation/config.txt| 14 ++
 cache.h |  5 ++-
 sha1-array.c| 15 +++
 sha1-array.h|  7 ++-
 sha1-name.c | 69 -
 t/t1512-rev-parse-disambiguation.sh | 32 ++---
 6 files changed, 120 insertions(+), 22 deletions(-)

-- 
2.17.0.290.gded63e768a