[PATCH 00/19] convert test -a/-o to and || patch series
These patch series convert test -a/-o to and ||. This is the second version. Changes: - Modified commit comment based on Jonathan Nieder suggestions (was don't use the -a or -o option with the test command) - Modified patch on git-submodule.sh based on Jonathan Nieder suggestions Elia Pinto (19): check_bindir: convert test -a/-o to and || contrib/examples/git-clone.sh: convert test -a/-o to and || contrib/examples/git-commit.sh: convert test -a/-o to and || contrib/examples/git-merge.sh: convert test -a/-o to and || contrib/examples/git-repack.sh: convert test -a/-o to and || contrib/examples/git-resolve.sh: convert test -a/-o to and || git-bisect.sh: convert test -a/-o to and || git-mergetool.sh: convert test -a/-o to and || git-rebase--interactive.sh: convert test -a/-o to and || git-submodule.sh: convert test -a/-o to and || t/t0025-crlf-auto.sh: convert test -a/-o to and || t/t0026-eol-config.sh: convert test -a/-o to and || t/t4102-apply-rename.sh: convert test -a/-o to and || t/t5000-tar-tree.sh: convert test -a/-o to and || t/t5403-post-checkout-hook.sh: convert test -a/-o to and || t/t5537-fetch-shallow.sh: convert test -a/-o to and || t/t5538-push-shallow.sh: convert test -a/-o to and || t/t9814-git-p4-rename.sh: convert test -a/-o to and || t/test-lib-functions.sh: convert test -a/-o to and || check_bindir|2 +- contrib/examples/git-clone.sh |2 +- contrib/examples/git-commit.sh |4 ++-- contrib/examples/git-merge.sh |4 ++-- contrib/examples/git-repack.sh |4 ++-- contrib/examples/git-resolve.sh |2 +- git-bisect.sh |2 +- git-mergetool.sh|4 ++-- git-rebase--interactive.sh |2 +- git-submodule.sh| 29 + t/t0025-crlf-auto.sh|6 +++--- t/t0026-eol-config.sh |8 t/t4102-apply-rename.sh |2 +- t/t5000-tar-tree.sh |2 +- t/t5403-post-checkout-hook.sh |8 t/t5537-fetch-shallow.sh|2 +- t/t5538-push-shallow.sh |2 +- t/t9814-git-p4-rename.sh|4 ++-- t/test-lib-functions.sh |4 ++-- 19 files changed, 49 insertions(+), 44 deletions(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/19] convert test -a/-o to and || patch series
Elia Pinto gitter.spi...@gmail.com writes: Elia Pinto (19): I went through the series (not very thoroughly) and it sounds good to me. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/19] convert test -a/-o to and || patch series
Elia Pinto gitter.spi...@gmail.com writes: These patch series convert test -a/-o to and ||. This is the second version. Perhaps slightly off-topic, but has the remainder of the previous $(...) series been perfected and ready to apply? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/19] convert test -a/-o to and || patch series
Hi, Elia Pinto wrote: These patch series convert test -a/-o to and ||. Should this come with a new check in t/check-non-portable-shell.pl so we don't regress in the future? Elia Pinto (19): [...] check_bindir|2 +- contrib/examples/git-clone.sh |2 +- contrib/examples/git-commit.sh |4 ++-- contrib/examples/git-merge.sh |4 ++-- contrib/examples/git-repack.sh |4 ++-- contrib/examples/git-resolve.sh |2 +- git-bisect.sh |2 +- git-mergetool.sh|4 ++-- git-rebase--interactive.sh |2 +- git-submodule.sh| 29 + t/t0025-crlf-auto.sh|6 +++--- t/t0026-eol-config.sh |8 t/t4102-apply-rename.sh |2 +- t/t5000-tar-tree.sh |2 +- t/t5403-post-checkout-hook.sh |8 t/t5537-fetch-shallow.sh|2 +- t/t5538-push-shallow.sh |2 +- t/t9814-git-p4-rename.sh|4 ++-- t/test-lib-functions.sh |4 ++-- 19 files changed, 49 insertions(+), 44 deletions(-) I still think one patch per file is too many patches for this. It would be easier to read with, e.g., whichever ones were most complex as separate patches and the rest (the easy ones) as a single patch. Thanks, Jonathan -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
