Re: [PATCH 08/12] remote.c: mark messages for translation

[Duy Nguyen]

On Mon, Oct 29, 2018 at 8:56 AM Junio C Hamano  wrote:
> There are other series in flight that touch the same area of code
> and in different ways, causing unnecessary conflicts, which does not
> help us either X-<.

I will of course fix all other comments, but I can hold this off if
it's causing too much trouble. I'm in no hurry to get anything merged
fast.
-- 
Duy

Re: [PATCH 08/12] remote.c: mark messages for translation

[Junio C Hamano]

Nguyễn Thái Ngọc Duy   writes:

> @@ -995,12 +995,12 @@ static int match_explicit_lhs(struct ref *src,
>* way to delete 'other' ref at the remote end.
>*/
>   if (try_explicit_object_name(rs->src, match) < 0)
> - return error("src refspec %s does not match any.", 
> rs->src);
> + return error(_("src refspec %s does not match any"), 
> rs->src);
>   if (allocated_match)
>   *allocated_match = 1;
>   return 0;
>   default:
> - return error("src refspec %s matches more than one.", rs->src);
> + return error(_("src refspec %s matches more than one"), 
> rs->src);
>   }
>  }

These minor changes that are not accompanied by their own
justification mean that the patches in this series cannot blindly be
trusted, which in turn means that I won't have bandwidth to process
this series properly for now.

I also saw die() -> BUG() that was not highlighted in the proposed
log message; the single instance I happened to notice looked
sensible, but I am not sure about the others.

There are other series in flight that touch the same area of code
and in different ways, causing unnecessary conflicts, which does not
help us either X-<.

[PATCH 08/12] remote.c: mark messages for translation

[Nguyễn Thái Ngọc Duy]

Signed-off-by: Nguyễn Thái Ngọc Duy 
---
 remote.c | 49 +
 1 file changed, 25 insertions(+), 24 deletions(-)

diff --git a/remote.c b/remote.c
index 81f4f01b00..11b33d1625 100644
--- a/remote.c
+++ b/remote.c
@@ -359,7 +359,7 @@ static int handle_config(const char *key, const char 
*value, void *cb)
return 0;
/* Handle remote..* variables */
if (*name == '/') {
-   warning("Config remote shorthand cannot begin with '/': %s",
+   warning(_("config remote shorthand cannot begin with '/': %s"),
name);
return 0;
}
@@ -406,7 +406,7 @@ static int handle_config(const char *key, const char 
*value, void *cb)
if (!remote->receivepack)
remote->receivepack = v;
else
-   error("more than one receivepack given, using the 
first");
+   error(_("more than one receivepack given, using the 
first"));
} else if (!strcmp(subkey, "uploadpack")) {
const char *v;
if (git_config_string(&v, key, value))
@@ -414,7 +414,7 @@ static int handle_config(const char *key, const char 
*value, void *cb)
if (!remote->uploadpack)
remote->uploadpack = v;
else
-   error("more than one uploadpack given, using the 
first");
+   error(_("more than one uploadpack given, using the 
first"));
} else if (!strcmp(subkey, "tagopt")) {
if (!strcmp(value, "--no-tags"))
remote->fetch_tags = -1;
@@ -620,7 +620,7 @@ static void handle_duplicate(struct ref *ref1, struct ref 
*ref2)
 * FETCH_HEAD_IGNORE entries always appear at
 * the end of the list.
 */
-   die(_("Internal error"));
+   BUG("Internal error");
}
}
free(ref2->peer_ref);
@@ -680,7 +680,7 @@ static int match_name_with_pattern(const char *key, const 
char *name,
size_t namelen;
int ret;
if (!kstar)
-   die("Key '%s' of pattern had no '*'", key);
+   die(_("key '%s' of pattern had no '*'"), key);
klen = kstar - key;
ksuffixlen = strlen(kstar + 1);
namelen = strlen(name);
@@ -690,7 +690,7 @@ static int match_name_with_pattern(const char *key, const 
char *name,
struct strbuf sb = STRBUF_INIT;
const char *vstar = strchr(value, '*');
if (!vstar)
-   die("Value '%s' of pattern has no '*'", value);
+   die(_("value '%s' of pattern has no '*'"), value);
strbuf_add(&sb, value, vstar - value);
strbuf_add(&sb, name + klen, namelen - klen - ksuffixlen);
strbuf_addstr(&sb, vstar + 1);
@@ -707,7 +707,7 @@ static void query_refspecs_multiple(struct refspec *rs,
int find_src = !query->src;
 
if (find_src && !query->dst)
-   error("query_refspecs_multiple: need either src or dst");
+   BUG("query_refspecs_multiple: need either src or dst");
 
for (i = 0; i < rs->nr; i++) {
struct refspec_item *refspec = &rs->items[i];
@@ -735,7 +735,7 @@ int query_refspecs(struct refspec *rs, struct refspec_item 
*query)
char **result = find_src ? &query->src : &query->dst;
 
if (find_src && !query->dst)
-   return error("query_refspecs: need either src or dst");
+   BUG("query_refspecs: need either src or dst");
 
for (i = 0; i < rs->nr; i++) {
struct refspec_item *refspec = &rs->items[i];
@@ -995,12 +995,12 @@ static int match_explicit_lhs(struct ref *src,
 * way to delete 'other' ref at the remote end.
 */
if (try_explicit_object_name(rs->src, match) < 0)
-   return error("src refspec %s does not match any.", 
rs->src);
+   return error(_("src refspec %s does not match any"), 
rs->src);
if (allocated_match)
*allocated_match = 1;
return 0;
default:
-   return error("src refspec %s matches more than one.", rs->src);
+   return error(_("src refspec %s matches more than one"), 
rs->src);
}
 }
 
@@ -1030,7 +1030,7 @@ static int match_explicit(struct ref *src, struct ref 
*dst,
if (!dst_value ||
((flag & REF_ISSYMREF) &&
 !starts_with(dst_value, "refs/heads/")))
-   die("%s cannot be resolved to branch.",
+   die(_("%s cannot be resolved to branch"),
matched_src->name);
}
 
@@ -1041,30 +1041,30 @@ static int match_explicit(str