[PATCH 1/4] t3400 (rebase): don't set GIT_AUTHOR_{NAME,EMAIL}

2013-05-10 Thread Ramkumar Ramachandra 
test-lib.sh already sets a sane GIT_AUTHOR_{NAME,EMAIL} for all test
scripts to use.  Don't unnecessarily duplicate the work.

Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
 t/t3400-rebase.sh | 4 
 1 file changed, 4 deletions(-)

diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh
index b58fa1a..a7ca2f1 100755
--- a/t/t3400-rebase.sh
+++ b/t/t3400-rebase.sh
@@ -10,10 +10,6 @@ among other things.
 '
 . ./test-lib.sh
 
-GIT_AUTHOR_NAME=author@name
-GIT_AUTHOR_EMAIL=bogus@email@address
-export GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL
-
 test_expect_success 'prepare repository with topic branches' '
git config core.logAllRefUpdates true 
echo First A 
-- 
1.8.3.rc1.52.gc14258d

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] t3400 (rebase): don't set GIT_AUTHOR_{NAME,EMAIL}

2013-05-10 Thread Eric Sunshine 
On Fri, May 10, 2013 at 10:29 AM, Ramkumar Ramachandra
artag...@gmail.com wrote:
 test-lib.sh already sets a sane GIT_AUTHOR_{NAME,EMAIL} for all test
 scripts to use.  Don't unnecessarily duplicate the work.

 Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
 ---
  t/t3400-rebase.sh | 4 
  1 file changed, 4 deletions(-)

 diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh
 index b58fa1a..a7ca2f1 100755
 --- a/t/t3400-rebase.sh
 +++ b/t/t3400-rebase.sh
 @@ -10,10 +10,6 @@ among other things.
  '
  . ./test-lib.sh

 -GIT_AUTHOR_NAME=author@name
 -GIT_AUTHOR_EMAIL=bogus@email@address

These values are intentionally bogus. Doesn't this change defeat the
purpose of 43c2325 (am: use get_author_ident_from_commit instead of
mailinfo when rebasing; 2010-06-16)?

 -export GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL
 -
  test_expect_success 'prepare repository with topic branches' '
 git config core.logAllRefUpdates true 
 echo First A 
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] t3400 (rebase): don't set GIT_AUTHOR_{NAME,EMAIL}

2013-05-10 Thread Ramkumar Ramachandra 
Eric Sunshine wrote:
 These values are intentionally bogus. Doesn't this change defeat the
 purpose of 43c2325 (am: use get_author_ident_from_commit instead of
 mailinfo when rebasing; 2010-06-16)?

Oh, oops.  I paid too little attention to this series.

Thanks for catching.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] t3400 (rebase): don't set GIT_AUTHOR_{NAME,EMAIL}

2013-05-10 Thread Junio C Hamano 
Eric Sunshine sunsh...@sunshineco.com writes:

 On Fri, May 10, 2013 at 10:29 AM, Ramkumar Ramachandra
 artag...@gmail.com wrote:
 test-lib.sh already sets a sane GIT_AUTHOR_{NAME,EMAIL} for all test
 scripts to use.  Don't unnecessarily duplicate the work.

 Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
 ---
  t/t3400-rebase.sh | 4 
  1 file changed, 4 deletions(-)

 diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh
 index b58fa1a..a7ca2f1 100755
 --- a/t/t3400-rebase.sh
 +++ b/t/t3400-rebase.sh
 @@ -10,10 +10,6 @@ among other things.
  '
  . ./test-lib.sh

 -GIT_AUTHOR_NAME=author@name
 -GIT_AUTHOR_EMAIL=bogus@email@address

 These values are intentionally bogus. Doesn't this change defeat the
 purpose of 43c2325 (am: use get_author_ident_from_commit instead of
 mailinfo when rebasing; 2010-06-16)?

 -export GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL
 -

Then perhaps there needs an in-code comment before these three lines
to explain why they are deliberately set to bogus values, no?

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html