Re: [PATCH 5/5] gitweb: make category headings into links when they are directories
> On 26 Mar 2015, at 19:49, Junio C Hamano wrote: > > Any comments from those who use or have their own code in Gitweb on > this topic? Thanks for chasing up my patches. I should have written a covering letter, to say that you can see these patches in action at https://git.csx.cam.ac.uk/x/ucs/ - try clicking on the category headings, and observe the pathinfo, breadcrumbs, and links under the search box. Tony. -- f.anthony.n.finchhttp://dotat.at-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/5] gitweb: make category headings into links when they are directories
Any comments from those who use or have their own code in Gitweb on this topic? * tf/gitweb-project-listing (2015-03-19) 5 commits - gitweb: make category headings into links when they are directories - gitweb: optionally set project category from its pathname - gitweb: add a link under the search box to clear a project filter - gitweb: if the PATH_INFO is incomplete, use it as a project_filter - gitweb: fix typo in man page Update gitweb to make it more pleasant to deal with a hierarchical forest of repositories. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 5/5] gitweb: make category headings into links when they are directories
When $projects_list_category_is_directory is turned on, project categories can be useful as project filters, so with that setting gitweb now makes the category headings into project_filter links (like the breadcrumbs). Signed-off-by: Tony Finch --- gitweb/gitweb.perl | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 0aab3e0..a02f3e4 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -5838,8 +5838,18 @@ sub git_project_list_body { if ($check_forks) { print "\n"; } - print "".esc_html($cat)."\n"; - print "\n"; + print ""; + if ($projects_list_directory_is_category) { + print $cgi->a({-href => + href(project => undef, + project_filter => $cat, + action => "project_list"), + -class => "list"}, + esc_html($cat)); + } else { + print esc_html($cat); + } + print "\n\n"; } git_project_list_rows($categories{$cat}, undef, undef, $check_forks); -- 2.2.1.68.g56d9796 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 5/5] gitweb: make category headings into links when they are directories
When $projects_list_category_is_directory is turned on, project categories can be useful as project filters, so with that setting gitweb now makes the category headings into project_filter links (like the breadcrumbs). Signed-off-by: Tony Finch --- gitweb/gitweb.perl | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index edbc058..32e65ae 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -5834,8 +5834,18 @@ sub git_project_list_body { if ($check_forks) { print "\n"; } - print "".esc_html($cat)."\n"; - print "\n"; + print ""; + if ($projects_list_directory_is_category) { + print $cgi->a({-href => + href(project => undef, + project_filter => $cat, + action => "project_list"), + -class => "list"}, + esc_html($cat)); + } else { + print esc_html($cat); + } + print "\n\n"; } git_project_list_rows($categories{$cat}, undef, undef, $check_forks); -- 2.1.0.rc0.229.gaee38de -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html