Re: [PATCH v2 0/2] Propagating flags carefully from the command line

[Jeff King]

On Wed, Jan 15, 2014 at 03:59:42PM -0800, Junio C Hamano wrote:

 So this is my second try.  The second one now gets rid of the call
 to mark_blob_uninteresting() as Peff suggested, because the first
 patch makes the function very well aware that it only should mark
 the objects that are reachable from the object, and by definition
 blobs do not reach anything.
 
 Junio C Hamano (2):
   revision: mark contents of an uninteresting tree uninteresting
   revision: propagate flag bits from tags to pointees

Sorry for a slow review, but I just read through your earlier comments
and this series. I agree there was definitely a bug in what we were
discussing earlier, and this looks like the right way to fix it. The end
result splits the flag-setting responsibility much more sensibly.

Thanks.

-Peff
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 0/2] Propagating flags carefully from the command line

[Junio C Hamano]

So this is my second try.  The second one now gets rid of the call
to mark_blob_uninteresting() as Peff suggested, because the first
patch makes the function very well aware that it only should mark
the objects that are reachable from the object, and by definition
blobs do not reach anything.

Junio C Hamano (2):
  revision: mark contents of an uninteresting tree uninteresting
  revision: propagate flag bits from tags to pointees

 revision.c   | 29 +
 t/t6000-rev-list-misc.sh | 17 +
 2 files changed, 34 insertions(+), 12 deletions(-)

-- 
1.8.5.3-493-gb139ac2

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html