Re: [PATCH v2 0/3] Introduce diff.submodule

2012-11-08 Thread Jeff King 
On Sun, Nov 04, 2012 at 11:28:17PM +0530, Ramkumar Ramachandra wrote:

 Jens Lehmann wrote:
  Am 01.11.2012 11:43, schrieb Ramkumar Ramachandra:
  Hi,
 
  v1 is here:
  http://mid.gmane.org/1349196670-2844-1-git-send-email-artag...@gmail.com
 
  I've fixed the issues pointed out in the review by Jens.
 
  Thanks, looking good to me.
 
 Peff, can we pick this up?

Thanks for prodding, I missed the original. I have a few comments, but
I'll respond directly.

Also, I was coincidentally looking at the same code today. You might
find this interesting:

  http://article.gmane.org/gmane.comp.version-control.git/209188

-Peff
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 0/3] Introduce diff.submodule

2012-11-01 Thread Ramkumar Ramachandra 
Hi,

v1 is here:
http://mid.gmane.org/1349196670-2844-1-git-send-email-artag...@gmail.com

I've fixed the issues pointed out in the review by Jens.

Sorry about the delay; need to find a new dayjob.

Ramkumar Ramachandra (3):
  Documentation: move diff.wordRegex from config.txt to diff-config.txt
  diff: introduce diff.submodule configuration variable
  submodule: display summary header in bold

 Documentation/config.txt |6 --
 Documentation/diff-config.txt|   13 +
 Documentation/diff-options.txt   |3 ++-
 builtin/diff.c   |4 
 cache.h  |1 +
 diff.c   |7 ++-
 submodule.c  |8 
 submodule.h  |2 +-
 t/t4041-diff-submodule-option.sh |   30 +-
 9 files changed, 60 insertions(+), 14 deletions(-)

-- 
1.7.8.1.362.g5d6df.dirty

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/3] Introduce diff.submodule

2012-11-01 Thread Jens Lehmann 
Am 01.11.2012 11:43, schrieb Ramkumar Ramachandra:
 Hi,
 
 v1 is here:
 http://mid.gmane.org/1349196670-2844-1-git-send-email-artag...@gmail.com
 
 I've fixed the issues pointed out in the review by Jens.

Thanks, looking good to me.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html