[PATCH v2 0/3] fixup remaining cvsimport tests

2013-01-11 Thread Chris Rorvick
Reroll w/ sign-off.

Chris Rorvick (3):
  t/lib-cvs.sh: allow cvsps version 3.x.
  t9600: fixup for new cvsimport
  t9604: fixup for new cvsimport

 t/lib-cvs.sh|  2 +-
 t/t9600-cvsimport.sh| 10 --
 t/t9604-cvsimport-timestamps.sh |  5 ++---
 3 files changed, 7 insertions(+), 10 deletions(-)

-- 
1.8.1.rc3.335.g88a67d6

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 0/3] fixup remaining cvsimport tests

2013-01-11 Thread Junio C Hamano
Chris Rorvick ch...@rorvick.com writes:

 Reroll w/ sign-off.

 Chris Rorvick (3):
   t/lib-cvs.sh: allow cvsps version 3.x.
   t9600: fixup for new cvsimport
   t9604: fixup for new cvsimport

  t/lib-cvs.sh|  2 +-
  t/t9600-cvsimport.sh| 10 --
  t/t9604-cvsimport-timestamps.sh |  5 ++---
  3 files changed, 7 insertions(+), 10 deletions(-)

Thanks.

I too noticed the droppage of -a support, which may not be a big
deal (people can drop it from their script, run cvsimport and they
can drop newer commits from the resulting Git history to emulate the
old behaviour without -a that attempted to find a quiescent point
if they really want to and suspect that the upstream CVS repository
was not quiescent during the import).

Likewise for -x.  You said no longer can be told and that is
technically true, but it is more like no longer need to be told, as
stale cache cannot get in the way, so it is probably not a big
deal, either, for people to drop it from their script.

About the changed behaviour regarding origin, I suspect that it is
a change for the better, but we would probably need documentation
updates to cover it (and deleted options and (mis)features) before
this topic graduates.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 0/3] fixup remaining cvsimport tests

2013-01-11 Thread Chris Rorvick
On Sat, Jan 12, 2013 at 12:36 AM, Junio C Hamano gits...@pobox.com wrote:
 I too noticed the droppage of -a support, which may not be a big
 deal (people can drop it from their script, run cvsimport and they
 can drop newer commits from the resulting Git history to emulate the
 old behaviour without -a that attempted to find a quiescent point
 if they really want to and suspect that the upstream CVS repository
 was not quiescent during the import).

Is there any value to -a when fuzz is exposed (-z)?  I mean this is a
functional sense.  I think there is a lot of value to maintaining the
interfaces of both cvsimport and cvsps where possible.

 Likewise for -x.  You said no longer can be told and that is
 technically true, but it is more like no longer need to be told, as
 stale cache cannot get in the way, so it is probably not a big
 deal, either, for people to drop it from their script.

:-)  I originally wrote need and then changed it to be clearer on
why it was being removed.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html