Re: [PATCH v2 0/5] %(trailers) improvements in pretty format
Eric Sunshine writes: > If "key" is for including particular trailers, intuition might lead > people to think that "nokey" is for excluding certain trailers. > Perhaps a different name for "nokey", such as "valueonly" or > "stripkey", would be better. Good point. I guess "valueonly" would be preferred as it says what it shows, not what it hides.
Re: [PATCH v2 0/5] %(trailers) improvements in pretty format
On Sun, Nov 4, 2018 at 10:23 AM Anders Waldenborg wrote: > This adds support for three new options to %(trailers): > * key -- show only trailers with specified key > * nokey -- don't show key part of trailers > * separator -- allow specifying custom separator between trailers If "key" is for including particular trailers, intuition might lead people to think that "nokey" is for excluding certain trailers. Perhaps a different name for "nokey", such as "valueonly" or "stripkey", would be better.
[PATCH v2 0/5] %(trailers) improvements in pretty format
This adds support for three new options to %(trailers): * key -- show only trailers with specified key * nokey -- don't show key part of trailers * separator -- allow specifying custom separator between trailers Anders Waldenborg (5): pretty: single return path in %(trailers) handling pretty: allow showing specific trailers pretty: add support for "nokey" option in %(trailers) pretty: extract fundamental placeholders to separate function pretty: add support for separator option in %(trailers) Documentation/pretty-formats.txt | 17 +--- pretty.c | 71 ++-- t/t4205-log-pretty-formats.sh| 60 +++ trailer.c| 28 ++--- trailer.h| 3 ++ 5 files changed, 156 insertions(+), 23 deletions(-) -- 2.17.1
