Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2
Le 08/06/2013 02:14, Eric Sunshine a écrit : These two changes are unrelated and could be split into distinct patches (IMHO, though others may disagree). Two distinct patches or two distinct commits? I assumed it was two distinct commits, but thinking about it, removing a library could have its own patch. -- Célestin Matte -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2
Célestin Matte celestin.ma...@ensimag.fr writes: Le 08/06/2013 02:14, Eric Sunshine a écrit : These two changes are unrelated and could be split into distinct patches (IMHO, though others may disagree). Two distinct patches or two distinct commits? That's the same. You write commits locally, send them as patches, and Junio uses git am to turn the patches back into commits. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2
Le 08/06/2013 20:41, Matthieu Moy a écrit : Célestin Matte celestin.ma...@ensimag.fr writes: Le 08/06/2013 02:14, Eric Sunshine a écrit : These two changes are unrelated and could be split into distinct patches (IMHO, though others may disagree). Two distinct patches or two distinct commits? That's the same. You write commits locally, send them as patches, and Junio uses git am to turn the patches back into commits. Oh, I thought a part of a patch was called a commit. So the question was rather: Should it be sent to this list independently from this series of patches?. -- Célestin Matte -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2
Célestin Matte celestin.ma...@ensimag.fr writes: Oh, I thought a part of a patch was called a commit. 1 patch = 1 commit 1 patch series = several commits sent together. Will normally end-up in a branch in Junio's repo (named with initials/topic) -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2
On Sat, Jun 8, 2013 at 2:45 PM, Célestin Matte celestin.ma...@ensimag.fr wrote: Le 08/06/2013 20:41, Matthieu Moy a écrit : Célestin Matte celestin.ma...@ensimag.fr writes: Le 08/06/2013 02:14, Eric Sunshine a écrit : These two changes are unrelated and could be split into distinct patches (IMHO, though others may disagree). Two distinct patches or two distinct commits? That's the same. You write commits locally, send them as patches, and Junio uses git am to turn the patches back into commits. Oh, I thought a part of a patch was called a commit. So the question was rather: Should it be sent to this list independently from this series of patches?. Terms patch and commit tend to be used interchangeably, as Matthieu notes. There is no need to send the split up patches to the list independently from this series. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2
Signed-off-by: Célestin Matte celestin.ma...@ensimag.fr
Signed-off-by: Matthieu Moy matthieu@grenoble-inp.fr
---
contrib/mw-to-git/git-remote-mediawiki.perl |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index ae6dd2e..1c34ada 100755
--- a/contrib/mw-to-git/git-remote-mediawiki.perl
+++ b/contrib/mw-to-git/git-remote-mediawiki.perl
@@ -22,7 +22,6 @@ binmode STDERR, :encoding(UTF-8);
binmode STDOUT, :encoding(UTF-8);
use URI::Escape;
-use IPC::Open2;
use Readonly;
# Mediawiki filenames can contain forward slashes. This variable decides by
which pattern they should be replaced
@@ -338,7 +337,8 @@ sub get_mw_pages {
sub run_git {
my $args = shift;
my $encoding = (shift || encoding(UTF-8));
- open(my $git, -|:$encoding, git . $args);
+ open(my $git, -|:$encoding, git . $args)
+ or die Unable to open: $!\n;
my $res = do {
local $/ = undef;
$git
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2
On Fri, Jun 7, 2013 at 5:42 PM, Célestin Matte
celestin.ma...@ensimag.fr wrote:
Signed-off-by: Célestin Matte celestin.ma...@ensimag.fr
Signed-off-by: Matthieu Moy matthieu@grenoble-inp.fr
---
contrib/mw-to-git/git-remote-mediawiki.perl |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index ae6dd2e..1c34ada 100755
--- a/contrib/mw-to-git/git-remote-mediawiki.perl
+++ b/contrib/mw-to-git/git-remote-mediawiki.perl
@@ -22,7 +22,6 @@ binmode STDERR, :encoding(UTF-8);
binmode STDOUT, :encoding(UTF-8);
use URI::Escape;
-use IPC::Open2;
use Readonly;
# Mediawiki filenames can contain forward slashes. This variable decides by
which pattern they should be replaced
@@ -338,7 +337,8 @@ sub get_mw_pages {
sub run_git {
my $args = shift;
my $encoding = (shift || encoding(UTF-8));
- open(my $git, -|:$encoding, git . $args);
+ open(my $git, -|:$encoding, git . $args)
+ or die Unable to open: $!\n;
my $res = do {
local $/ = undef;
$git
These two changes are unrelated and could be split into distinct
patches (IMHO, though others may disagree).
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
