[PATCH v2 2/2] test/send-email: add to-cover test
Does it work? I am not sure. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- t/t9001-send-email.sh | 16 1 file changed, 16 insertions(+) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 3119c8c..3b17884 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -1334,6 +1334,22 @@ test_expect_success $PREREQ '--force sends cover letter template anyway' ' test -n $(ls msgtxt*) ' +test_expect_success $PREREQ 'to-cover adds To to all mail' ' + clean_fake_sendmail + rm -fr outdir + git format-patch --cover-letter -2 -o outdir + git send-email \ + --force \ + --from=Example nob...@example.com \ + --to=nob...@example.com \ + --smtp-server=$(pwd)/fake.sendmail \ + outdir/0002-*.patch \ + outdir/-*.patch \ + outdir/0001-*.patch \ + 2errors out + ! grep SUBJECT HERE errors + test -n $(ls msgtxt*) +' test_expect_success $PREREQ 'sendemail.aliasfiletype=mailrc' ' clean_fake_sendmail echo alias sbd someb...@example.org .mailrc -- MST -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/2] test/send-email: add to-cover test
Michael S. Tsirkin m...@redhat.com writes: Does it work? I am not sure. Then why was it sent here? diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 3119c8c..3b17884 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -1334,6 +1334,22 @@ test_expect_success $PREREQ '--force sends cover letter template anyway' ' test -n $(ls msgtxt*) ' +test_expect_success $PREREQ 'to-cover adds To to all mail' ' + clean_fake_sendmail + rm -fr outdir + git format-patch --cover-letter -2 -o outdir + git send-email \ + --force \ + --from=Example nob...@example.com \ + --to=nob...@example.com \ + --smtp-server=$(pwd)/fake.sendmail \ + outdir/0002-*.patch \ + outdir/-*.patch \ + outdir/0001-*.patch \ + 2errors out + ! grep SUBJECT HERE errors + test -n $(ls msgtxt*) +' Is this a copy of an existing --force can disable the safety to catch a mistake to send a cover letter template without any update? How are you checking if you are propagating to/cc from the cover to other messages with this test? Puzzled. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html