Re: [PATCH v2 2/6] send-email: fix suppress-cc=self on cccmd

2013-06-03 Thread Junio C Hamano 
Michael S. Tsirkin m...@redhat.com writes:

 When cccmd is used, old-style suppress-from filter
 is applied by the newer suppress-cc=self isn't.
 Fix this up.

 Signed-off-by: Michael S. Tsirkin m...@redhat.com
 ---
  git-send-email.perl | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/git-send-email.perl b/git-send-email.perl
 index bd13cc8..a138615 100755
 --- a/git-send-email.perl
 +++ b/git-send-email.perl
 @@ -1462,7 +1462,7 @@ sub recipients_cmd {
   $address =~ s/^\s*//g;
   $address =~ s/\s*$//g;
   $address = sanitize_address($address);
 - next if ($address eq $sanitized_sender and $suppress_from);
 + next if ($address eq $sender and $suppress_cc{'self'});

If $suppress_from is defined, $suppress_cc{'self'} gets its value,
so the latter half of this change is very understandable.

The original comparison uses $address that is sanitized (whose
definition is roughly mangled/quoted with rfc2047 etc to fit on
To/Cc headers) against $sanitized_sender, which means for a

$sender = 'Michael S. Tsirkin m...@redhat.com';

we used

$sanitized_sender = 'Michael S. Tsirkin m...@redhat.com';

for comparison, but the new code does not quote the $recipient_name
part inside dq for the single dot after the middle name.  Is this a
desirable change?

   push @addresses, $address;
   printf(($prefix) Adding %s: %s from: '%s'\n,
  $what, $address, $cmd) unless $quiet;
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/6] send-email: fix suppress-cc=self on cccmd

2013-06-03 Thread Michael S. Tsirkin 
On Mon, Jun 03, 2013 at 11:04:31AM -0700, Junio C Hamano wrote:
 Michael S. Tsirkin m...@redhat.com writes:
 
  What I tried to do here is split the changes to small chunks and I
  picked a chunk of a later patch in an earlier one by mistake.
 
  So this is fixed up by patch 4/6 in the series, which redefines
  sender to have the sanitized value, everywhere.
 
  I guess I'll have to repost moving this former chunk to patch 4.
 
 Yeah, that may be a good idea.
 
 Thanks.

Or just smash 2+4 together ...
Confused. You are doing this or want me ot?

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/6] send-email: fix suppress-cc=self on cccmd

2013-05-30 Thread Michael S. Tsirkin 
When cccmd is used, old-style suppress-from filter
is applied by the newer suppress-cc=self isn't.
Fix this up.

Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
 git-send-email.perl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index bd13cc8..a138615 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1462,7 +1462,7 @@ sub recipients_cmd {
$address =~ s/^\s*//g;
$address =~ s/\s*$//g;
$address = sanitize_address($address);
-   next if ($address eq $sanitized_sender and $suppress_from);
+   next if ($address eq $sender and $suppress_cc{'self'});
push @addresses, $address;
printf(($prefix) Adding %s: %s from: '%s'\n,
   $what, $address, $cmd) unless $quiet;
-- 
MST

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html