Re: [PATCH v2 6/7] build: make clean should not remove configure-generated files

2012-07-23 Thread Junio C Hamano
Stefano Lattarini stefano.lattar...@gmail.com writes:

 ... and here we should add invocation:

 ... the make install invocation ...

 falls back to the default prefix of '$HOME', thus installing git
 in the user's home directory -- definitely unexpected.

 Can you fix those nits locally before merging to 'next', or should
 I send a re-roll?

Too late X-.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 6/7] build: make clean should not remove configure-generated files

2012-07-19 Thread Stefano Lattarini
Those filed hold variables, settings and information set by the
configuration process run by './configure'; in Autotools-based
build system that kind of stuff should only be removed by
make distclean.  Having it removed by make clean is not only
inconsistent, but causes real confusion for that part of the Git
audience that is used to the Autotools semantics; for example,
an autotools old-timer that has run:

./configure --prefix /opt/git

in the past, without running make distclean afterwards, would
expect a make install issued after a make clean to rebuild and
install git in '/opt/git'; but with the current behaviour, the
make clean invocation removes (among the other things) the file
'config.mak.autogen', so that the make install falls back to the
default prefix of '$HOME', thus installing git in the user's home
directory -- definitely unexpected.

Signed-off-by: Stefano Lattarini stefano.lattar...@gmail.com
---
 Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 285c660..88a76a3 100644
--- a/Makefile
+++ b/Makefile
@@ -2742,6 +2742,9 @@ dist-doc:
 
 distclean: clean
$(RM) configure
+   $(RM) config.log config.status config.cache
+   $(RM) config.mak.autogen config.mak.append
+   $(RM) -r autom4te.cache
 
 profile-clean:
$(RM) $(addsuffix *.gcda,$(addprefix $(PROFILE_DIR)/, $(object_dirs)))
@@ -2756,8 +2759,6 @@ clean: profile-clean
$(RM) -r $(dep_dirs)
$(RM) -r po/build/
$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) 
tags cscope*
-   $(RM) -r autom4te.cache
-   $(RM) config.log config.mak.autogen config.mak.append config.status 
config.cache
$(RM) -r $(GIT_TARNAME) .doc-tmp-dir
$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
-- 
1.7.10.2.1067.g553d16e

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html