Re: [PATCH v3] Documentation: declare "core.ignorecase" as internal variable
On 27.06.2018 21:11, Junio C Hamano wrote: Marc Strapetz writes: [1. text/plain] The current description of "core.ignoreCase" reads like an option which is intended to be changed by the user while it's actually expected to be set by Git on initialization only. Subsequently, Git relies on the proper configuration of this variable, as noted by Bryan Turner [1]: Git on a case-insensitive filesystem (APFS, HFS+, FAT32, exFAT, vFAT, NTFS, etc.) is not designed to be run with anything other than core.ignoreCase=true. [1] https://marc.info/?l=git=152998665813997=2 mid:cagyf7-gee8jrgpkme9rhkptheq6p1+ebpmmwatmh01uo3bf...@mail.gmail.com Signed-off-by: Marc Strapetz --- Documentation/config.txt | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) Hmph. Do other people have difficulty applying this patch to their trees? It is just several lines long so I could retype it myself, but I guess "Content-Type: text/plain; charset=utf-8; format=flowed" has destroyed formatting of the patch rather badly. I had copy-pasted the patch into Thunderbird. The received email was looking fine in the inbox, however it seems that some leading whitespaces have been added to several lines (when comparing raw contents of v3 and v4). I have resent the patch with git send-email now. -Marc
Re: [PATCH v3] Documentation: declare "core.ignorecase" as internal variable
At 12:11 -0700 27 Jun 2018, Junio C Hamano wrote: Hmph. Do other people have difficulty applying this patch to their trees? It is just several lines long so I could retype it myself, but I guess "Content-Type: text/plain; charset=utf-8; format=flowed" has destroyed formatting of the patch rather badly. Yes, format=flowed requires lines that start with a space (along with '>' or 'From ') to be space-stuffed, adding a leading space. This will affect context lines in patches. I was able to apply it cleanly (I think) by sending the message to: sed '/@@/,$s/^ / /' | git am That's replacing two leading spaces with one.
Re: [PATCH v3] Documentation: declare "core.ignorecase" as internal variable
Marc Strapetz writes: > [1. text/plain] > The current description of "core.ignoreCase" reads like an option which > is intended to be changed by the user while it's actually expected to > be set by Git on initialization only. Subsequently, Git relies on the > proper configuration of this variable, as noted by Bryan Turner [1]: > > Git on a case-insensitive filesystem (APFS, HFS+, FAT32, exFAT, > vFAT, NTFS, etc.) is not designed to be run with anything other > than core.ignoreCase=true. > > [1] https://marc.info/?l=git=152998665813997=2 > mid:cagyf7-gee8jrgpkme9rhkptheq6p1+ebpmmwatmh01uo3bf...@mail.gmail.com > > Signed-off-by: Marc Strapetz > --- > Documentation/config.txt | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > Hmph. Do other people have difficulty applying this patch to their trees? It is just several lines long so I could retype it myself, but I guess "Content-Type: text/plain; charset=utf-8; format=flowed" has destroyed formatting of the patch rather badly. > diff --git a/Documentation/config.txt b/Documentation/config.txt > index 1cc18a828..c70cfe956 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -390,16 +390,19 @@ core.hideDotFiles:: > default mode is 'dotGitOnly'. > > core.ignoreCase:: > - If true, this option enables various workarounds to enable > + Internal variable which enables various workarounds to enable > Git to work better on filesystems that are not case sensitive, > - like FAT. For example, if a directory listing finds > - "makefile" when Git expects "Makefile", Git will assume > + like APFS, HFS+, FAT, NTFS, etc. For example, if a directory listing > + finds "makefile" when Git expects "Makefile", Git will assume > it is really the same file, and continue to remember it as > "Makefile". > + > The default is false, except linkgit:git-clone[1] or linkgit:git-init[1] > will probe and set core.ignoreCase true if appropriate when the repository > is created. > ++ > +Git relies on the proper configuration of this variable for your operating > +and file system. Modifying this value may result in unexpected behavior. > > core.precomposeUnicode:: > This option is only used by Mac OS implementation of Git.
[PATCH v3] Documentation: declare "core.ignorecase" as internal variable
The current description of "core.ignoreCase" reads like an option which is intended to be changed by the user while it's actually expected to be set by Git on initialization only. Subsequently, Git relies on the proper configuration of this variable, as noted by Bryan Turner [1]: Git on a case-insensitive filesystem (APFS, HFS+, FAT32, exFAT, vFAT, NTFS, etc.) is not designed to be run with anything other than core.ignoreCase=true. [1] https://marc.info/?l=git=152998665813997=2 mid:cagyf7-gee8jrgpkme9rhkptheq6p1+ebpmmwatmh01uo3bf...@mail.gmail.com Signed-off-by: Marc Strapetz --- Documentation/config.txt | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index 1cc18a828..c70cfe956 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -390,16 +390,19 @@ core.hideDotFiles:: default mode is 'dotGitOnly'. core.ignoreCase:: - If true, this option enables various workarounds to enable + Internal variable which enables various workarounds to enable Git to work better on filesystems that are not case sensitive, - like FAT. For example, if a directory listing finds - "makefile" when Git expects "Makefile", Git will assume + like APFS, HFS+, FAT, NTFS, etc. For example, if a directory listing + finds "makefile" when Git expects "Makefile", Git will assume it is really the same file, and continue to remember it as "Makefile". + The default is false, except linkgit:git-clone[1] or linkgit:git-init[1] will probe and set core.ignoreCase true if appropriate when the repository is created. ++ +Git relies on the proper configuration of this variable for your operating +and file system. Modifying this value may result in unexpected behavior. core.precomposeUnicode:: This option is only used by Mac OS implementation of Git. -- 2.17.0.rc0.3.gb1b5a51b2
