Re: [PATCH v3 0/4] wt-status.c: commitable flag
"Stephen P. Smith" writes: > A couple of years ago, during a patch review Junio found that the > commitable bit as implemented in wt-status.c was broken. > > Stephen P. Smith (4): > Move has_unmerged earlier in the file. > wt-status: rename commitable to committable > t7501: add test of "commit --dry-run --short" > wt-status.c: Set the committable flag in the collect phase. > > builtin/commit.c | 18 +- > t/t7501-commit.sh | 10 -- > wt-status.c | 45 +++-- > wt-status.h | 2 +- > 4 files changed, 45 insertions(+), 30 deletions(-) Thanks.
Re: [PATCH v3 0/4] wt-status.c: commitable flag
On Thursday, September 6, 2018 12:38:55 AM MST Ævar Arnfjörð Bjarmason wrote: > On Thu, Sep 06 2018, Stephen P. Smith wrote: > Sometimes you send mail from this address as "Stephen & Linda Smith > ", do we also need Linda Smith's Signed-Off-By? :) My wife and I share one email account. If I use the GUI email client to respond to emails then her name is on the From line (I could edit future emails). When I am submitting patches/updates, I do so under my name since it is "Stephen P. Smith" that is creating the patch. I've never had anyone ask before.
Re: [PATCH v3 0/4] wt-status.c: commitable flag
On Thu, Sep 06 2018, Stephen P. Smith wrote: This all looks good to me this time around. > Stephen P. Smith (4): > Move has_unmerged earlier in the file. > wt-status: rename commitable to committable > t7501: add test of "commit --dry-run --short" > wt-status.c: Set the committable flag in the collect phase. Sometimes you send mail from this address as "Stephen & Linda Smith ", do we also need Linda Smith's Signed-Off-By? :)
[PATCH v3 0/4] wt-status.c: commitable flag
A couple of years ago, during a patch review Junio found that the commitable bit as implemented in wt-status.c was broken. Stephen P. Smith (4): Move has_unmerged earlier in the file. wt-status: rename commitable to committable t7501: add test of "commit --dry-run --short" wt-status.c: Set the committable flag in the collect phase. builtin/commit.c | 18 +- t/t7501-commit.sh | 10 -- wt-status.c | 45 +++-- wt-status.h | 2 +- 4 files changed, 45 insertions(+), 30 deletions(-) -- 2.18.0
