Re: [PATCH v3 3/3] git-p4: Skip t9819 test case on case insensitive file systems

2015-10-12 Thread Luke Diamand
Looks good to me, Ack.

On 11 October 2015 at 18:55,   wrote:
> From: Lars Schneider 
>
> Windows and OS X file systems are case insensitive by default.
> Consequently the "git-p4-case-folding" test case does not apply to
> them.
>
> Signed-off-by: Lars Schneider 
> ---
>  t/t9819-git-p4-case-folding.sh | 6 ++
>  1 file changed, 6 insertions(+)
>
> diff --git a/t/t9819-git-p4-case-folding.sh b/t/t9819-git-p4-case-folding.sh
> index 78f1d0f..d808c00 100755
> --- a/t/t9819-git-p4-case-folding.sh
> +++ b/t/t9819-git-p4-case-folding.sh
> @@ -4,6 +4,12 @@ test_description='interaction with P4 case-folding'
>
>  . ./lib-git-p4.sh
>
> +if test_have_prereq CASE_INSENSITIVE_FS
> +then
> +   skip_all='skipping P4 case-folding tests; case insensitive file 
> system detected'
> +   test_done
> +fi
> +
>  test_expect_success 'start p4d with case folding enabled' '
> start_p4d -C1
>  '
> --
> 2.5.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v3 3/3] git-p4: Skip t9819 test case on case insensitive file systems

2015-10-11 Thread larsxschneider
From: Lars Schneider 

Windows and OS X file systems are case insensitive by default.
Consequently the "git-p4-case-folding" test case does not apply to
them.

Signed-off-by: Lars Schneider 
---
 t/t9819-git-p4-case-folding.sh | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/t/t9819-git-p4-case-folding.sh b/t/t9819-git-p4-case-folding.sh
index 78f1d0f..d808c00 100755
--- a/t/t9819-git-p4-case-folding.sh
+++ b/t/t9819-git-p4-case-folding.sh
@@ -4,6 +4,12 @@ test_description='interaction with P4 case-folding'
 
 . ./lib-git-p4.sh
 
+if test_have_prereq CASE_INSENSITIVE_FS
+then
+   skip_all='skipping P4 case-folding tests; case insensitive file system 
detected'
+   test_done
+fi
+
 test_expect_success 'start p4d with case folding enabled' '
start_p4d -C1
 '
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html