Re: [PATCH v6 0/7] Trace env variables in run_command()

2018-01-19 Thread Jeff King
On Thu, Jan 18, 2018 at 04:45:05PM +0700, Nguyễn Thái Ngọc Duy wrote:

> v6 squashes Junio's changes in 6/7 and moves trace_run_command() from
> trace.c to run-command.c.

Thanks, this version looks good to me.

-Peff


[PATCH v6 0/7] Trace env variables in run_command()

2018-01-18 Thread Nguyễn Thái Ngọc Duy
v6 squashes Junio's changes in 6/7 and moves trace_run_command() from
trace.c to run-command.c.

Jeff King (2):
  sq_quote_argv: drop maxlen parameter
  trace: avoid unnecessary quoting

Nguyễn Thái Ngọc Duy (5):
  trace.c: move strbuf_release() out of print_trace_line()
  run-command.c: introduce trace_run_command()
  run-command.c: print program 'git' when tracing git_cmd mode
  run-command.c: print env vars in trace_run_command()
  run-command.c: print new cwd in trace_run_command()

 builtin/am.c|  2 +-
 builtin/rev-parse.c |  4 +--
 quote.c | 30 ++--
 quote.h | 10 +-
 run-command.c   | 88 -
 t/helper/test-run-command.c |  9 +
 t/t0061-run-command.sh  | 37 +++
 trace.c |  9 +++--
 8 files changed, 178 insertions(+), 11 deletions(-)

-- 
2.15.1.600.g899a5f85c6