Re: [PATCH v7 4/7] git-remote-mediawiki: Update tests to run with the new bin-wrapper

2013-07-03 Thread Matthieu Moy
benoit.per...@ensimag.fr writes:

 --- a/contrib/mw-to-git/t/test-gitmw-lib.sh
 +++ b/contrib/mw-to-git/t/test-gitmw-lib.sh
 @@ -62,12 +62,8 @@ test_check_precond () {
   test_done
   fi
  
 - if [ ! -f $GIT_BUILD_DIR/git-remote-mediawiki ];
 - then
 - echo No remote mediawiki for git found. Copying it in git
 - echo cp $GIT_BUILD_DIR/contrib/mw-to-git/git-remote-mediawiki 
 $GIT_BUILD_DIR/
 - ln -s $GIT_BUILD_DIR/contrib/mw-to-git/git-remote-mediawiki 
 $GIT_BUILD_DIR
 - fi
 + GIT_EXEC_PATH=$(cd $(dirname $0)  cd ../..  pwd)
 + PATH=$GIT_EXEC_PATH'/bin-wrapper:'$PATH
  
   if [ ! -d $WIKI_DIR_INST/$WIKI_DIR_NAME ];
   then

Cool!

I like the way adding a new feature has positive side effects on the
rest of the code.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v7 4/7] git-remote-mediawiki: Update tests to run with the new bin-wrapper

2013-07-02 Thread benoit . person
From: Benoit Person benoit.per...@ensimag.fr

Until now, if git-remote-mediawiki was not installed, the test suite
copied it to the toplevel directory. This solution pollutes the
directory with untracked files. Plus, we would need to copy the new
git-mw.perl file to test it too.

Signed-off-by: Benoit Person benoit.per...@ensimag.fr
Signed-off-by: Matthieu Moy matthieu@grenoble-inp.fr
---
 contrib/mw-to-git/t/test-gitmw-lib.sh | 8 ++--
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/contrib/mw-to-git/t/test-gitmw-lib.sh 
b/contrib/mw-to-git/t/test-gitmw-lib.sh
index bb76cee..ca6860f 100755
--- a/contrib/mw-to-git/t/test-gitmw-lib.sh
+++ b/contrib/mw-to-git/t/test-gitmw-lib.sh
@@ -62,12 +62,8 @@ test_check_precond () {
test_done
fi
 
-   if [ ! -f $GIT_BUILD_DIR/git-remote-mediawiki ];
-   then
-   echo No remote mediawiki for git found. Copying it in git
-   echo cp $GIT_BUILD_DIR/contrib/mw-to-git/git-remote-mediawiki 
$GIT_BUILD_DIR/
-   ln -s $GIT_BUILD_DIR/contrib/mw-to-git/git-remote-mediawiki 
$GIT_BUILD_DIR
-   fi
+   GIT_EXEC_PATH=$(cd $(dirname $0)  cd ../..  pwd)
+   PATH=$GIT_EXEC_PATH'/bin-wrapper:'$PATH
 
if [ ! -d $WIKI_DIR_INST/$WIKI_DIR_NAME ];
then
-- 
1.8.3.1.590.gc07d91b

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html