Re: [PATCH v8 0/7] git-p4: add support for large file systems
On 03 Oct 2015, at 10:23, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Luke Diamand writes:
>>
>>> All looks good to me, Ack.
>>>
>>> One tiny thing perhaps Junio could comment on: the git commit message
>>> for 75abe9fa5b39980de27dfc33dd5b4f4b5926f34c, "git-p4: add optional
>>> type specifier to gitConfig reader" uses what looks like UTF-8 encoded
>>> left and right quotes, rather than regular ASCII quotes ("). I don't
>>> know if that matters.
>>
>> Yeah, I noticed them, too. In general, I'd prefer to avoid these
>> pretty-quotes myself, as they typically do not add much information
>> (unless nesting matters, which is usually not the case in the log
>> message, or something) and the primary effect of them is to force us
>> to step outside ASCII, which causes editors and pagers to misalign
>> for some people.
>>
>> But it is not too huge an issue that it is worth to go back and fix
>> them, either.
>
> Well, I looked at it again and it also replaced double-dash before
> option names like --bool and --int with something funny (are these
> em-dashes?), which is a more serious bogosity than pretty quotes, so
> I ended up amending the message for that commit after all.
>
Oh. This was not intentional. I wonder how that happened. I will watch out for
it in the future.
Thanks for fixing,
Lars
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v8 0/7] git-p4: add support for large file systems
Junio C Hamano writes:
> Luke Diamand writes:
>
>> All looks good to me, Ack.
>>
>> One tiny thing perhaps Junio could comment on: the git commit message
>> for 75abe9fa5b39980de27dfc33dd5b4f4b5926f34c, "git-p4: add optional
>> type specifier to gitConfig reader" uses what looks like UTF-8 encoded
>> left and right quotes, rather than regular ASCII quotes ("). I don't
>> know if that matters.
>
> Yeah, I noticed them, too. In general, I'd prefer to avoid these
> pretty-quotes myself, as they typically do not add much information
> (unless nesting matters, which is usually not the case in the log
> message, or something) and the primary effect of them is to force us
> to step outside ASCII, which causes editors and pagers to misalign
> for some people.
>
> But it is not too huge an issue that it is worth to go back and fix
> them, either.
Well, I looked at it again and it also replaced double-dash before
option names like --bool and --int with something funny (are these
em-dashes?), which is a more serious bogosity than pretty quotes, so
I ended up amending the message for that commit after all.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v8 0/7] git-p4: add support for large file systems
Luke Diamand writes:
> On 26 September 2015 at 08:54, wrote:
>> From: Lars Schneider
>>
>> diff to v7:
>> * fix commit message line length (thanks Junio)
>> * fix sync command for large file system support (thanks Luke!)
>> * add test case for sync command
>> * rename git-p4.pushLargeFiles to git-p4.largeFilePush for consistency with
>> other git-p4.largeFile* configs
>> * fix relative path handling for clone operation which caused a crash in the
>> disk space check and t9819 (thanks Luke!)
>> * use test_path_is_missing instead of !test_path_is_file (thanks Luke!)
>>
>> The patch is again based on maint (ee6ad5f) as patches v1-v6 before.
>
>
> All looks good to me, Ack.
>
> One tiny thing perhaps Junio could comment on: the git commit message
> for 75abe9fa5b39980de27dfc33dd5b4f4b5926f34c, "git-p4: add optional
> type specifier to gitConfig reader" uses what looks like UTF-8 encoded
> left and right quotes, rather than regular ASCII quotes ("). I don't
> know if that matters.
Yeah, I noticed them, too. In general, I'd prefer to avoid these
pretty-quotes myself, as they typically do not add much information
(unless nesting matters, which is usually not the case in the log
message, or something) and the primary effect of them is to force us
to step outside ASCII, which causes editors and pagers to misalign
for some people.
But it is not too huge an issue that it is worth to go back and fix
them, either.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v8 0/7] git-p4: add support for large file systems
On 26 September 2015 at 08:54, wrote:
> From: Lars Schneider
>
> diff to v7:
> * fix commit message line length (thanks Junio)
> * fix sync command for large file system support (thanks Luke!)
> * add test case for sync command
> * rename git-p4.pushLargeFiles to git-p4.largeFilePush for consistency with
> other git-p4.largeFile* configs
> * fix relative path handling for clone operation which caused a crash in the
> disk space check and t9819 (thanks Luke!)
> * use test_path_is_missing instead of !test_path_is_file (thanks Luke!)
>
> The patch is again based on maint (ee6ad5f) as patches v1-v6 before.
All looks good to me, Ack.
One tiny thing perhaps Junio could comment on: the git commit message
for 75abe9fa5b39980de27dfc33dd5b4f4b5926f34c, "git-p4: add optional
type specifier to gitConfig reader" uses what looks like UTF-8 encoded
left and right quotes, rather than regular ASCII quotes ("). I don't
know if that matters.
Thanks,
Luke
>
> Cheers,
> Lars
>
> Lars Schneider (7):
> git-p4: add optional type specifier to gitConfig reader
> git-p4: add gitConfigInt reader
> git-p4: return an empty list if a list config has no values
> git-p4: add file streaming progress in verbose mode
> git-p4: check free space during streaming
> git-p4: add support for large file systems
> git-p4: add Git LFS backend for large file system
>
> Documentation/git-p4.txt | 32 +
> git-p4.py | 270 +++---
> t/t9823-git-p4-mock-lfs.sh | 192 ++
> t/t9824-git-p4-git-lfs.sh | 288
> +
> 4 files changed, 766 insertions(+), 16 deletions(-)
> create mode 100755 t/t9823-git-p4-mock-lfs.sh
> create mode 100755 t/t9824-git-p4-git-lfs.sh
>
> --
> 2.5.1
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v8 0/7] git-p4: add support for large file systems
larsxschnei...@gmail.com writes: > From: Lars Schneider > > diff to v7: > * fix commit message line length (thanks Junio) > * fix sync command for large file system support (thanks Luke!) > * add test case for sync command > * rename git-p4.pushLargeFiles to git-p4.largeFilePush for consistency with > other git-p4.largeFile* configs > * fix relative path handling for clone operation which caused a crash in the > disk space check and t9819 (thanks Luke!) > * use test_path_is_missing instead of !test_path_is_file (thanks Luke!) Thanks. Also v7's 5/7 had what should have been part of 6/7, resulting in double assignemnt to largeFileSystemConstructor, but this reroll seems to fix that. Will queue. > > The patch is again based on maint (ee6ad5f) as patches v1-v6 before. > > Cheers, > Lars > > Lars Schneider (7): > git-p4: add optional type specifier to gitConfig reader > git-p4: add gitConfigInt reader > git-p4: return an empty list if a list config has no values > git-p4: add file streaming progress in verbose mode > git-p4: check free space during streaming > git-p4: add support for large file systems > git-p4: add Git LFS backend for large file system > > Documentation/git-p4.txt | 32 + > git-p4.py | 270 +++--- > t/t9823-git-p4-mock-lfs.sh | 192 ++ > t/t9824-git-p4-git-lfs.sh | 288 > + > 4 files changed, 766 insertions(+), 16 deletions(-) > create mode 100755 t/t9823-git-p4-mock-lfs.sh > create mode 100755 t/t9824-git-p4-git-lfs.sh > > -- > 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v8 0/7] git-p4: add support for large file systems
From: Lars Schneider diff to v7: * fix commit message line length (thanks Junio) * fix sync command for large file system support (thanks Luke!) * add test case for sync command * rename git-p4.pushLargeFiles to git-p4.largeFilePush for consistency with other git-p4.largeFile* configs * fix relative path handling for clone operation which caused a crash in the disk space check and t9819 (thanks Luke!) * use test_path_is_missing instead of !test_path_is_file (thanks Luke!) The patch is again based on maint (ee6ad5f) as patches v1-v6 before. Cheers, Lars Lars Schneider (7): git-p4: add optional type specifier to gitConfig reader git-p4: add gitConfigInt reader git-p4: return an empty list if a list config has no values git-p4: add file streaming progress in verbose mode git-p4: check free space during streaming git-p4: add support for large file systems git-p4: add Git LFS backend for large file system Documentation/git-p4.txt | 32 + git-p4.py | 270 +++--- t/t9823-git-p4-mock-lfs.sh | 192 ++ t/t9824-git-p4-git-lfs.sh | 288 + 4 files changed, 766 insertions(+), 16 deletions(-) create mode 100755 t/t9823-git-p4-mock-lfs.sh create mode 100755 t/t9824-git-p4-git-lfs.sh -- 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
